Try to help with some code review

diff --git a/doc/todo/Bestdir_along_with_bestlink_in_IkiWiki.pm.mdwn b/doc/todo/Bestdir_along_with_bestlink_in_IkiWiki.pm.mdwn
index 95c38f794a281760dc90fcb87af8d0774fcc20eb..be4249460d2bb2a8665f38adf2a170570c5fbe73 100644 (file)
--- a/doc/todo/Bestdir_along_with_bestlink_in_IkiWiki.pm.mdwn
+++ b/doc/todo/Bestdir_along_with_bestlink_in_IkiWiki.pm.mdwn
@@ -1,5 +1,8 @@
 This patch adds function bestdir() which returns best directory from the directory structure. This is in addition to the bestlink() function which is there in IkiWiki.pm 
 
 This patch adds function bestdir() which returns best directory from the directory structure. This is in addition to the bestlink() function which is there in IkiWiki.pm 
 

+> Um, what is this for? :-) It would probably be a lot easier to review if it
+> had documentation, and/or a plugin that used it. --[[smcv]]
+

 -------
 
     Index: IkiWiki.pm
 -------
 
     Index: IkiWiki.pm

diff --git a/doc/todo/source_link.mdwn b/doc/todo/source_link.mdwn
index b051361a8486db732d34e3ec99625a9f566b5619..9d9ec969713b3778b0581ca5a343471d9efee6c9 100644 (file)
--- a/doc/todo/source_link.mdwn
+++ b/doc/todo/source_link.mdwn
@@ -4,6 +4,11 @@ How about a direct link from the page header to the source of the latest version
 
 I just implemented this.  There is one [[patch]] to the default page template, and a new plugin.  -- [[Will]]
 
 
 I just implemented this.  There is one [[patch]] to the default page template, and a new plugin.  -- [[Will]]
 

+> The use of sessioncgi here seems undesirable: on wikis where anonymity is
+> not allowed, you'll be asked to log in. Couldn't you achieve the same thing
+> by loading the index with IkiWiki::loadindex, like [[plugins/goto]] does?
+> --[[smcv]]
+

 ----
 
     diff --git a/templates/page.tmpl b/templates/page.tmpl
 ----
 
     diff --git a/templates/page.tmpl b/templates/page.tmpl

diff --git a/doc/todo/varioki_--_add_template_variables___40__with_closures_for_values__41___in_ikiwiki.setup.mdwn b/doc/todo/varioki_--_add_template_variables___40__with_closures_for_values__41___in_ikiwiki.setup.mdwn
index b28469993864708a54e16520440a64ba8dfc271b..d292a1184892132e880365370900f8c71fc0243c 100644 (file)
--- a/doc/todo/varioki_--_add_template_variables___40__with_closures_for_values__41___in_ikiwiki.setup.mdwn
+++ b/doc/todo/varioki_--_add_template_variables___40__with_closures_for_values__41___in_ikiwiki.setup.mdwn
@@ -33,6 +33,12 @@ ManojSrivastava
 > > directory,  which is not very easy for a plain ol' user.  Not everyone is the
 > >  sysadmin of their own machines with access to system dirs. --ManojSrivastava
 
 > > directory,  which is not very easy for a plain ol' user.  Not everyone is the
 > >  sysadmin of their own machines with access to system dirs. --ManojSrivastava
 

+>>> It seems worth mentioning here that the `libdir` configuration parameter
+>>> lets you install additional plugins in a user-controlled directory
+>>> (*libdir*`/IkiWiki/Plugin`), avoiding needing root; indeed, a full local
+>>> ikiwiki installation without any involvement from the sysadmin is
+>>> [[possible|tips/DreamHost]]. --[[smcv]]
+

 <pre>
                 varioki => {'motto'    => '"Manoj\'s musings"',
                         'arrayvar' => '[0, 1, 2, 3]',
 <pre>
                 varioki => {'motto'    => '"Manoj\'s musings"',
                         'arrayvar' => '[0, 1, 2, 3]',