git: don't redundantly pass "--" to git_sha1

git_sha1 already puts "--" before its arguments, so

    git_sha1_file($dir, 'doc/index.mdwn')

would have incorrectly invoked

    git rev-list --max-count=1 HEAD -- -- doc/index.mdwn

If there is no file in the wiki named "--", that's harmless, because
it merely names the latest revision in which either "--" or
"doc/index.mdwn" changed. However, it could return incorrect results
if there is somehow a file named "--".

(cherry picked from commit 0463357392471f58ccd2c7f39cafabd8472e129b)

diff --git a/IkiWiki/Plugin/git.pm b/IkiWiki/Plugin/git.pm
index c81c8eae70f76e2658e3236df22bd4f8077a650f..010d6d54c6dbb27c256b035c1b5f8a58df2c2d45 100644 (file)
--- a/IkiWiki/Plugin/git.pm
+++ b/IkiWiki/Plugin/git.pm
@@ -578,7 +578,7 @@ sub rcs_find_changes ($) {
 sub git_sha1_file ($$) {
        my $dir=shift;
        my $file=shift;
-       return git_sha1($dir, "--", $file);
+       return git_sha1($dir, $file);
 }
 
 sub git_sha1 ($@) {