looks good to merge, suggestions for further testing

diff --git a/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn b/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn
index 07e925a0343f502e007c92214f23fb547cd07f94..9690b8b7bec84bb156d67ac8e6d5fd7e8d193e73 100644 (file)
--- a/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn
+++ b/doc/bugs/urlto_API_change_breaks_wikis_with_po_plugin.mdwn
@@ -3,9 +3,25 @@ signature changes. Else a wiki with the po plugin enabled cannot be
 refreshed / rebuilt because of (correct) Perl errors.
 
 My po branch contains a fix.
 refreshed / rebuilt because of (correct) Perl errors.
 
 My po branch contains a fix.

+--[[intrigeri]]
+
+> The commit looks sane to me, for what it's worth. Joey, please
+> consider merging? --[[smcv]]

 
 Also, I fear the lack of any useful `$from` parameter might break some
 l10n'd link niceness when using `po_link_to = current` but I have not
 investigated this yet.
 
 Also, I fear the lack of any useful `$from` parameter might break some
 l10n'd link niceness when using `po_link_to = current` but I have not
 investigated this yet.

-

 --[[intrigeri]]
 --[[intrigeri]]

+
+> If `urlto` is called without a second parameter, it means we need
+> a URL valid from either the CGI URL or any page in the wiki,
+> (so we'd previously have set the third parameter true), but we
+> don't *necessarily* need an absolute URL - so return what you'd
+> have returned if asked for an absolute URL, but looking like
+> `/bugs/` rather than `http://ikiwiki.info/bugs/` if possible.
+>
+> It looks as though `beautify_urlpath` under `po_link_to = current`,
+> and 3-argument `urlto`, aren't tested by `t/po.t` - perhaps you
+> could add some test cases there? To test 3-argument `urlto` you'd
+> need to add `$config{baseurl} = "http://example.com"` or
+> something. --[[smcv]]