editdiff: Broken since 2.62 due to wrong syntax, now fixed.

diff --git a/IkiWiki/Plugin/editdiff.pm b/IkiWiki/Plugin/editdiff.pm
index 2b1fac55d18122e7a7dd335845b10b880277ff90..f5d7837fc4c4712de2b693497ce3dd1b7a977b59 100644 (file)
--- a/IkiWiki/Plugin/editdiff.pm
+++ b/IkiWiki/Plugin/editdiff.pm
@@ -56,7 +56,7 @@ sub formbuilder_setup { #{{{
        my %params=@_;
        my $form=$params{form};
 
-       return if defined ! $form->field("do") || $form->field("do") ne "edit";
+       return if ! defined $form->field("do") || $form->field("do") ne "edit";
 
        my $page=$form->field("page");
        $page = IkiWiki::possibly_foolish_untaint($page);

diff --git a/debian/changelog b/debian/changelog
index 611138cb8b84ebb8f058a5dd5b2648f263799e84..b05e8390ba0201de5dd3d0c83a22ec6ed1f15c74 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,6 +2,7 @@ ikiwiki (2.65) UNRELEASED; urgency=low
 
   * aggregate: Allow expirecount to work on the first pass. (expireage still
     needs to wait for the pages to be rendered though)
+  * editdiff: Broken since 2.62 due to wrong syntax, now fixed.
 
  -- Joey Hess <joeyh@debian.org>  Wed, 17 Sep 2008 14:26:56 -0400
 

diff --git a/doc/plugins/editdiff/discussion.mdwn b/doc/plugins/editdiff/discussion.mdwn
index 8a1a59f79233770f0fbc9e38584cdbc6da76ebf4..386a4ba5b3abc32ed6f011bd058ffb9e7229be2c 100644 (file)
--- a/doc/plugins/editdiff/discussion.mdwn
+++ b/doc/plugins/editdiff/discussion.mdwn
@@ -1 +1,3 @@
 I've enabled the plugin on an SVN-backed wiki, but am not seeing the Diff button when editing. (I do see the Rename and Remove buttons from having enabled those plugins.) Any ideas why it wouldn't be showing up? --[[schmonz]]
+
+> It was broken, I've fixed it. --[[Joey]]