]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/commitdiff
avoid shelling
authorJoey Hess <joey@kitenet.net>
Fri, 18 Jun 2010 16:50:31 +0000 (12:50 -0400)
committerJoey Hess <joey@kitenet.net>
Fri, 18 Jun 2010 16:50:31 +0000 (12:50 -0400)
IkiWiki/Plugin/bzr.pm

index e7c1b8d8e1a801d1ffb1318d65266bc9396a0de0..9bee0c4b27611eda8966a05c773cd6e7930802d9 100644 (file)
@@ -287,9 +287,7 @@ sub rcs_diff ($) {
 }
 
 sub extract_timestamp (@) {
-       # XXX filename passes through the shell here, should try to avoid
-       # that just in case
-       open (my $out, "@_ |");
+       open (my $out, "-|", @_);
        my @log = bzr_log($out);
 
        if (length @log < 1) {