hnb: Fixed broken use of mkstemp that had caused dangling temp files, and prevented...

diff --git a/IkiWiki/Plugin/hnb.pm b/IkiWiki/Plugin/hnb.pm
index 32c9cf3ada5b1ed3ed65114177fbcade05d0eaf2..5157a6b93ce54c80ffac7330e50033cde57eddb4 100644 (file)
--- a/IkiWiki/Plugin/hnb.pm
+++ b/IkiWiki/Plugin/hnb.pm
@@ -33,8 +33,8 @@ sub htmlize (@) {
        # hnb outputs version number etc. every time to STDOUT, so
        # using files makes it easier to seprarate.
 
        # hnb outputs version number etc. every time to STDOUT, so
        # using files makes it easier to seprarate.
 

-       my $tmpin  = mkstemp( "/tmp/ikiwiki-hnbin.XXXXXXXXXX"  );
-       my $tmpout = mkstemp( "/tmp/ikiwiki-hnbout.XXXXXXXXXX" );
+       my ($infh, $tmpin)  = mkstemp( "/tmp/ikiwiki-hnbin.XXXXXXXXXX"  );
+       my ($outfh, $tmpout) = mkstemp( "/tmp/ikiwiki-hnbout.XXXXXXXXXX" );

 
        open(TMP, '>', $tmpin) or die "Can't write to $tmpin: $!";
        print TMP $params{content};
 
        open(TMP, '>', $tmpin) or die "Can't write to $tmpin: $!";
        print TMP $params{content};

diff --git a/debian/changelog b/debian/changelog
index ae1d23479a0004a497f167fa88fc1ded1f46d811..15ae21a55c729179623c13b21d31e11464daef7e 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -12,6 +12,8 @@ ikiwiki (3.20100624) UNRELEASED; urgency=low
   * Fixed some confusion and bugginess about whether
     rcs_getctime/rcs_getmtime were passed absolute or relative filenames.
     (Make it relative like everything else.)
   * Fixed some confusion and bugginess about whether
     rcs_getctime/rcs_getmtime were passed absolute or relative filenames.
     (Make it relative like everything else.)

+  * hnb: Fixed broken use of mkstemp that had caused dangling temp files,
+    and prevented actually rendering hnb files.

 
  -- Joey Hess <joeyh@debian.org>  Wed, 23 Jun 2010 15:30:04 -0400
 
 
  -- Joey Hess <joeyh@debian.org>  Wed, 23 Jun 2010 15:30:04 -0400