build: Ensure that pm_to_blib finishes before rewriting shebang lines

Otherwise, rewriting shebang lines can race with pm_to_blib,
potentially resulting in files being corrupt or empty.

diff --git a/CHANGELOG b/CHANGELOG
index 69721498feb1e715e0703562dbd6fc7802fa36b8..22d9a3660e79470d53324415e81e33490e3d191f 100644 (file)
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -7,6 +7,7 @@ ikiwiki (3.20180106) UNRELEASED; urgency=medium
   * build: `set -e` before each `for` loop, so that errors are reliably
     trapped
   * build: Use if/then instead of `||` so that the `-e` flag works
+  * build: Ensure that pm_to_blib finishes before rewriting shebang lines
 
  -- Simon McVittie <smcv@debian.org>  Mon, 08 Jan 2018 10:51:10 +0000
 

diff --git a/Makefile.PL b/Makefile.PL
index 907ff30c9159c4b316dc31029d16693e60435b4e..6f1724697a938537cd224dcd869bd17d8a7fb05b 100755 (executable)
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -61,7 +61,7 @@ extra_build: perl_shebangs $(outprogs) ikiwiki.setup docwiki sysconfdir
 docwiki:
        $(PERL) -Iblib/lib $(extramodules) $(tflag) ikiwiki.in --setup docwiki.setup --refresh
 
-perl_shebangs:
+perl_shebangs: pm_to_blib
 ifneq "$(PERL)" "/usr/bin/perl"
        set -e; \
        for file in $(shebang_scripts); do \