review of needstranslation() pagespec

Minor wording fix; changelog; etc.

diff --git a/IkiWiki/Plugin/po.pm b/IkiWiki/Plugin/po.pm
index f12c69d5f58f5e33856bb8de128c6d13ffb7ad26..0b225166823ef6b83d931ab3af6b981e1cc3cf0b 100644 (file)
--- a/IkiWiki/Plugin/po.pm
+++ b/IkiWiki/Plugin/po.pm
@@ -1225,7 +1225,7 @@ sub match_needstranslation ($$;@) {
 
        my $percenttranslated=IkiWiki::Plugin::po::percenttranslated($page);
        if ($percenttranslated eq 'N/A') {
-               return IkiWiki::FailReason->new("file is not a translation page");
+               return IkiWiki::FailReason->new("file is not a translatable page");
        }
        elsif ($percenttranslated < 100) {
                return IkiWiki::SuccessReason->new("file has $percenttranslated translated");

diff --git a/debian/changelog b/debian/changelog
index 7d857d9c0987c04da5e286a43f3cf25271a6e7f1..bdcf528842217b842ab2c8353524fdecdb195982 100644 (file)
--- a/debian/changelog
+++ b/debian/changelog
@@ -20,6 +20,7 @@ ikiwiki (3.20100624) UNRELEASED; urgency=low
   * git: Added git_wrapper_background_command option. Can be used to eg, 
     make the git wrapper push to github in the background after ikiwiki
     runs.
+  * po: Added needstranslation() pagespec. (intrigeri)
 
  -- Joey Hess <joeyh@debian.org>  Wed, 23 Jun 2010 15:30:04 -0400
 

diff --git a/doc/todo/po_needstranslation_pagespec.mdwn b/doc/todo/po_needstranslation_pagespec.mdwn
index acc5641a4f4fcb42f076d9e41622c70f7f0e4418..77449dc2b1a6d6e6b14b4c09ffea7547a1228dbd 100644 (file)
--- a/doc/todo/po_needstranslation_pagespec.mdwn
+++ b/doc/todo/po_needstranslation_pagespec.mdwn
@@ -2,4 +2,8 @@ Commit b225fdc44d4b3d in my po branch adds a `needstranslation()`
 PageSpec. It makes it easy to list pages that need translation work.
 Please review. --[[intrigeri]]
 
-[[!tag patch]]
+> Looks good, cherry-picked. The only improvment I can 
+> think of is that `needstranslation(50)` could match
+> only pages less than 50% translated. --[[Joey]] 
+
+[[!tag patch done]]