]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/commitdiff
thank you; gettext
authorjmtd <jmtd@web>
Wed, 10 Nov 2021 09:21:51 +0000 (05:21 -0400)
committeradmin <admin@branchable.com>
Wed, 10 Nov 2021 09:21:51 +0000 (05:21 -0400)
doc/todo/report_on_specific_markdown_implementation_used.mdwn

index 171cc8b291427e2f8e052f20865abc1b7db988bb..7efaca1d89dfed16fb7443e891cac9c4dedcde38 100644 (file)
@@ -7,5 +7,11 @@ Patch: <https://github.com/jmtd/ikiwiki/commit/79297a0879e4f05f421b560bbbc74c227
 
 > +1 && LGTM, but i'm not sure that needs gettext since it's debugging? -- [[anarcat]]
 
+>> Thank you. RE gettext, I think there's value in localizing even debug messages. But
+>> I might have not approached it ideally, I did wonder whether instead of `gettext("mdwn: using Text::Markdown::markdown")`
+>> I should have done something like `"mdwn: ".gettext("using ")."Text::Markdown::markdown"`.
+>> I bow to the superior gettext knowledge of just about anyone. *— [[Jon]], 2021-11-10* 
+
 [[!tag patch]]
 [[!template id=gitbranch branch=jon/mdwn-debug-log-chosen-impl author="[[Jon]]"]]
+