]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/commitdiff
(no commit message)
authorhttps://www.google.com/accounts/o8/id?id=AItOawmUWmB1M35_jviFvGPYDIH-a-_Al-7OrXM <Daniel@web>
Sat, 16 Jul 2011 01:28:00 +0000 (21:28 -0400)
committeradmin <admin@branchable.com>
Sat, 16 Jul 2011 01:28:00 +0000 (21:28 -0400)
doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn [new file with mode: 0644]

diff --git a/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn b/doc/todo/Add_instructive_commit_messages_for_removing_pages.mdwn
new file mode 100644 (file)
index 0000000..f000878
--- /dev/null
@@ -0,0 +1,22 @@
+As [[Add instructive commit messages for add _47_ edit pages]], but for `remove.pm`.
+
+I use a `join()` since it at least looks like the plugin is able to remove several pages at once (`foreach` looping over file parameters), thus holding multiple entries in `@pages`. I haven't seen this happen, though.
+
+Diff follows. --[[Daniel Andersson]]
+
+[[!tag patch]]
+
+---
+
+       diff -r 4f2ad3a5377e Plugin/remove.pm
+       --- a/Plugin/remove.pm  Fri Jul 15 17:39:04 2011 +0200
+       +++ b/Plugin/remove.pm  Sat Jul 16 03:20:35 2011 +0200
+       @@ -228,7 +228,7 @@
+                                               IkiWiki::rcs_remove($file);
+                                       }
+                                       IkiWiki::rcs_commit_staged(
+       -                                       message => gettext("removed"),
+       +                                       message => sprintf(gettext("remove %s"), join(', ', @files)),
+                                               session => $session,
+                                       );
+                                       IkiWiki::enable_commit_hook();