img: stop ImageMagick trying to be clever if filenames contain a colon

$im->Read() takes a filename-like argument with several sets of special
syntax. Most of the possible metacharacters are escaped by the
default `wiki_file_chars` (and in any case not particularly disruptive),
but the colon ":" is not.

It seems the way to force ImageMagick to treat colons within the
filename as literal is to prepend a colon, so do that.

diff --git a/IkiWiki/Plugin/img.pm b/IkiWiki/Plugin/img.pm
index 17a58ca7a476b9b01e953d5ce10ce6c3200f8e7b..169f5e7137a99739501c170561b164d3c4e8825d 100644 (file)
--- a/IkiWiki/Plugin/img.pm
+++ b/IkiWiki/Plugin/img.pm
@@ -76,7 +76,7 @@ sub preprocess (@) {
        my $im = Image::Magick->new();
        my $imglink;
        my $imgdatalink;
-       my $r = $im->Read("$srcfile\[$pagenumber]");
+       my $r = $im->Read(":$srcfile\[$pagenumber]");
        error sprintf(gettext("failed to read %s: %s"), $file, $r) if $r;
 
        if (! defined $im->Get("width") || ! defined $im->Get("height")) {

diff --git a/t/img.t b/t/img.t
index 2ea3abb24c353ffb16752988c2ace6064b839539..a7b92531f5c9c71b4f8a6122d66f02af9dd2b123 100755 (executable)
--- a/t/img.t
+++ b/t/img.t
@@ -24,6 +24,11 @@ my $SVGS_WORK = defined $magick->QueryFormat("svg");
 ok(! system("rm -rf t/tmp; mkdir -p t/tmp/in"));
 
 ok(! system("cp t/img/redsquare.png t/tmp/in/redsquare.png"));
+# colons in filenames are a corner case for img
+ok(! system("cp t/img/redsquare.png t/tmp/in/hello:world.png"));
+ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c.png"));
+ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c:d.png"));
+ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c:d:e:f:g:h:i:j.png"));
 
 if ($SVGS_WORK) {
        writefile("emptysquare.svg", "t/tmp/in",
@@ -42,6 +47,9 @@ writefile("imgconversions.mdwn", "t/tmp/in", <<EOF
 [[!img redsquare.png]]
 [[!img redsquare.png size=10x]]
 [[!img redsquare.png size=30x50]] expecting 30x30
+[[!img hello:world.png size=x8]] expecting 8x8
+[[!img a:b:c.png size=x4]]
+[[!img a:b:c:d:e:f:g:h:i:j.png size=x6]]
 $maybe_svg_img
 [[!img twopages.pdf size=12x]]
 [[!img twopages.pdf size=16x pagenumber=1]]
@@ -57,7 +65,7 @@ ok(! system($command));
 sub size($) {
        my $filename = shift;
        my $im = Image::Magick->new();
-       my $r = $im->Read($filename);
+       my $r = $im->Read(":$filename");
        return "no image" if $r;
        my $w = $im->Get("width");
        my $h = $im->Get("height");
@@ -78,6 +86,10 @@ if ($SVGS_WORK) {
 
 is(size("$outpath/12x-twopages.png"), "12x12");
 is(size("$outpath/16x-p1-twopages.png"), "16x2");
+ok($outhtml =~ /width="8" height="8".*expecting 8x8/);
+is(size("$outpath/x8-hello:world.png"), "8x8");
+is(size("$outpath/x4-a:b:c.png"), "4x4");
+is(size("$outpath/x6-a:b:c:d:e:f:g:h:i:j.png"), "6x6");
 
 # now let's remove them again
 
@@ -90,6 +102,9 @@ if (1) { # for easier testing
        ok(! -e "$outpath/10x-simple-svg.png");
        ok(! -e "$outpath/10x-simple-pdf.png");
        ok(! -e "$outpath/10x-p1-simple-pdf.png");
+       ok(! -e "$outpath/x8-hello:world.png");
+       ok(! -e "$outpath/x4-a:b:c.png");
+       ok(! -e "$outpath/x6-a:b:c:d:e:f:g:h:i:j.png");
 
        # cleanup
        ok(! system("rm -rf t/tmp"));