todo/comments: reorganise by status

diff --git a/doc/todo/comments.mdwn b/doc/todo/comments.mdwn
index cbc98277246f80782ee88ff073dc654cff34b609..33d688ab337d2be60801ad9f33054235d8614748 100644 (file)
--- a/doc/todo/comments.mdwn
+++ b/doc/todo/comments.mdwn
@@ -1,24 +1,29 @@
-Known issues with the [[plugins/comments]] plugin:
+# Known issues with the [[plugins/comments]] plugin

 
 

-* There is some common code cargo-culted from other plugins (notably inline and editpage) which
-  should probably be shared
-
-  > Actually, there's less of this now than there used to be - a lot of simple
-  > things that were shared have become unshareable as they became more
-  > complex. --[[smcv]]
+## Unimplemented

 
 * Previews always say "unknown IP address"
 
 
 * Previews always say "unknown IP address"
 

-* Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID
+* Instead of just a link to add a comment, it could have a form to enter
+  the title, similar to the form for adding a new blog post.

 
 

-  > Done in my comments git branch --[[smcv]]
+  > I'm not sure this is so useful? On Livejournal titles are allowed on
+  > comments, but very rarely used (and indeed usually not very useful);
+  > it's hard enough to get some people to title their blog posts :-)
+  > --[[smcv]]

 
 

-  > Not seeing it there, which branch? --[[Joey]]
+* If a spammer posts a comment, it is either impossible or hard to clean
+  up via the web. Would be nice to have some kind of link on the comment
+  that allows trusted users to remove it (using the remove plugin of
+  course).

 
 

-  >> Bah, git push --all is not the default... 'comments' branch now (I've also rebased it).
-  >> Sorry, I'm on mobile Internet at the moment... --[[smcv]]
+  > Won't the remove plugin refuse to remove internal pages? This would be
+  > a good feature to have, though. --[[smcv]]

 
 

-  >>> merged by [[Joey]] in commit 0f03af38 --[[smcv]]
+* Now that inline has some comments-specific functionality anyway, it would
+  be good to output `<link rel="comments">` in Atom and the equivalent in RSS.
+
+## Patches pending merge

 
 * The default template should have a (?) icon next to unauthenticated users (with the IP address
   as title) and an OpenID icon next to OpenIDs
 
 * The default template should have a (?) icon next to unauthenticated users (with the IP address
   as title) and an OpenID icon next to OpenIDs


@@ -36,7 +41,7 @@ Known issues with the [[plugins/comments]] plugin:
   >>>> Sorry, I should have spotted that (the assumption failed on my demo
   >>>> site, but the push to that site was when I was on the way out, so I
   >>>> didn't have time to investigate). As a note for other ikiwiki hackers,
   >>>> Sorry, I should have spotted that (the assumption failed on my demo
   >>>> site, but the push to that site was when I was on the way out, so I
   >>>> didn't have time to investigate). As a note for other ikiwiki hackers,

-  >>>> I should have used 
+  >>>> I should have used

   >>>> `<img src="<TMPL_VAR NAME=BASEURL>wikiicons/openid.png" />`. --[[smcv]]
 
   >>> I got to wondering if the icons are needed. On my comments branch
   >>>> `<img src="<TMPL_VAR NAME=BASEURL>wikiicons/openid.png" />`. --[[smcv]]
 
   >>> I got to wondering if the icons are needed. On my comments branch


@@ -53,42 +58,16 @@ Known issues with the [[plugins/comments]] plugin:
   >>>> Minimizing the number of "resource" files in the basewiki also seems
   >>>> a good goal. --[[smcv]]
 
   >>>> Minimizing the number of "resource" files in the basewiki also seems
   >>>> a good goal. --[[smcv]]
 

-* Should the comments be visually set off more from the page above?
-  Rather than just a horizontal rule, I'm thinking put the comments
-  in a box like is used for inlined pages.
-
-  > I did put them in a box in the CSS... I agree the default template
-  > could do with visual improvement though. --[[smcv]]
-
-  >> I'll consider this solved by [[Joey]]'s changes. --[[smcv]]
-
-* Instead of just a link to add a comment, it could have a form to enter
-  the title, similar to the form for adding a new blog post.
-
-  > I'm not sure this is so useful? On Livejournal titles are allowed on
-  > comments, but very rarely used (and indeed usually not very useful);
-  > it's hard enough to get some people to title their blog posts :-)
-  > --[[smcv]]
-
-* If a spammer posts a comment, it is either impossible or hard to clean
-  up via the web. Would be nice to have some kind of link on the comment
-  that allows trusted users to remove it (using the remove plugin of
-  course).
-
-  > Won't the remove plugin refuse to remove internal pages? This would be
-  > a good feature to have, though. --[[smcv]]
+## Won't fix

 
 

-* One can use inline to set up a feed of all comments posted to any page.
-  Using template=comment they are displayed right. Only problem
-  is there is no indication in that template of what page each comment in the
-  feed is a comment on. So, if a comment is inlined into a different page,
-  I think it should show a link back to the page commented on.
-  (BTW, the rss feed in this situation seems ok; there the link element
-  points back to the parent page.
+* There is some common code cargo-culted from other plugins (notably inline and editpage) which
+  should probably be shared

 
 

-  > done --[[Joey]] 
+  > Actually, there's less of this now than there used to be - a lot of simple
+  > things that were shared have become unshareable as they became more
+  > complex. --[[smcv]]

 
 

-* It would be useful to have a pagespec that always matches all comments on 
+* It would be useful to have a pagespec that always matches all comments on

   pages matching a glob. Something like `comment(blog/*)`.
   Perhaps postcomment could also be folded into this? Then the pagespec
   would match both existing comments, as well as new comments that are
   pages matching a glob. Something like `comment(blog/*)`.
   Perhaps postcomment could also be folded into this? Then the pagespec
   would match both existing comments, as well as new comments that are


@@ -106,9 +85,41 @@ Known issues with the [[plugins/comments]] plugin:
   > would also let X edit/delete comments on blog pages (including those
   > written by others) in arbitrary ways, which doesn't seem good. --[[smcv]]
 
   > would also let X edit/delete comments on blog pages (including those
   > written by others) in arbitrary ways, which doesn't seem good. --[[smcv]]
 

-  > I had a look at implementing comment() and fell afoul of 
+  > I had a look at implementing comment() and fell afoul of

   > some optimisations that assume only internal() will be used to match
   > some optimisations that assume only internal() will be used to match

-  > internal pages. So probably this isn't worth doing. --[[Joey]] 
+  > internal pages. So probably this isn't worth doing. --[[Joey]]
+
+## Done
+
+* Add `COMMENTOPENID`: the authenticated/verified user name, if and only if it was an OpenID
+
+  > Done in my comments git branch --[[smcv]]
+
+  > Not seeing it there, which branch? --[[Joey]]
+
+  >> Bah, git push --all is not the default... 'comments' branch now (I've also rebased it).
+  >> Sorry, I'm on mobile Internet at the moment... --[[smcv]]
+
+  >>> merged by [[Joey]] in commit 0f03af38 --[[smcv]]
+
+* Should the comments be visually set off more from the page above?
+  Rather than just a horizontal rule, I'm thinking put the comments
+  in a box like is used for inlined pages.
+
+  > I did put them in a box in the CSS... I agree the default template
+  > could do with visual improvement though. --[[smcv]]
+
+  >> I'll consider this solved by [[Joey]]'s changes. --[[smcv]]
+
+* One can use inline to set up a feed of all comments posted to any page.
+  Using template=comment they are displayed right. Only problem
+  is there is no indication in that template of what page each comment in the
+  feed is a comment on. So, if a comment is inlined into a different page,
+  I think it should show a link back to the page commented on.
+  (BTW, the rss feed in this situation seems ok; there the link element
+  points back to the parent page.
+
+  > done --[[Joey]]

 
 * One of Joey's commit messages says "Not ideal, it would be nicer to jump to
   the actual comment posted, but no anchor is available". In fact there is
 
 * One of Joey's commit messages says "Not ideal, it would be nicer to jump to
   the actual comment posted, but no anchor is available". In fact there is


@@ -116,7 +127,4 @@ Known issues with the [[plugins/comments]] plugin:
   with id="comment_123" or something. I'll fix this, unless Joey gets there
   first. --[[smcv]]
 
   with id="comment_123" or something. I'll fix this, unless Joey gets there
   first. --[[smcv]]
 

-  > done --[[Joey]] 
-
-* Now that inline has some comments-specific functionality anyway, it would
-  be good to output `<link rel="comments">` in Atom and the equivalent in RSS.
+  > done --[[Joey]]