Fix [[!meta name=foo]] by closing the open quote.

diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm
index e7b96bdf142f47e221e321b4ecb8ce68ab4989f8..ea099f955ac1c486cdd2baf6636e330a8eae569c 100644 (file)
--- a/IkiWiki/Plugin/meta.pm
+++ b/IkiWiki/Plugin/meta.pm
@@ -294,6 +294,7 @@ sub preprocess (@) {
        elsif ($key eq 'name') {
                push @{$metaheaders{$page}}, scrub('<meta name="'.
                        encode_entities($value).
        elsif ($key eq 'name') {
                push @{$metaheaders{$page}}, scrub('<meta name="'.
                        encode_entities($value).

+                       '" '.

                        join(' ', map { "$_=\"$params{$_}\"" } keys %params).
                        ' />', $page, $destpage);
        }
                        join(' ', map { "$_=\"$params{$_}\"" } keys %params).
                        ' />', $page, $destpage);
        }

diff --git a/t/meta.t b/t/meta.t
index ab25c2f83b1c29e3c7ece69e6704ebf95d330273..c95e23531c035fc64d3a07f034104493e1d934dd 100755 (executable)
--- a/t/meta.t
+++ b/t/meta.t
@@ -125,12 +125,11 @@ write_build_read_compare(
 #      qr{<link href="http://wonka\.link\.example" />},
 #);
 
 #      qr{<link href="http://wonka\.link\.example" />},
 #);
 

-# XXX buggy? is this my bug? maybe twitter:foo would just work if this worked
-#write_build_read_compare(
-#      'name',
-#      q{[[!meta name="thingy" value1="hi" value2="hello"]]},
-#      qr{<meta name="thingy" value1="hi" value2="hello" />},
-#);
+write_build_read_compare(
+       'name',
+       q{[[!meta name="thingy" value1="hi" value2="hello"]]},
+       qr{<meta name="thingy" value[0-9]{1}=".+?" value[0-9]{1}=".+?" />},
+);

 
 write_build_read_compare(
        'keywords',
 
 write_build_read_compare(
        'keywords',


@@ -149,11 +148,11 @@ write_build_read_compare(
 #      '[[!meta twitter:card="player"]]',
 #      qr{<meta name="twitter:card" content="player" />},
 #);
 #      '[[!meta twitter:card="player"]]',
 #      qr{<meta name="twitter:card" content="player" />},
 #);

-#
-#write_build_read_compare(
-#      'twittercard2',
-#      '[[!meta name="twitter:card" content="player"]]',
-#      qr{<meta name="twitter:card" content="player" />},
-#);
+
+write_build_read_compare(
+       'twittercard2',
+       '[[!meta name="twitter:card" content="player"]]',
+       qr{<meta name="twitter:card" content="player" />},
+);

 
 done_testing();
 
 done_testing();