img: stop ImageMagick trying to be clever if filenames contain a colon

[git.ikiwiki.info.git] / t / img.t

diff --git a/t/img.t b/t/img.t
index 95d39bc0978acdb1ae00d03780e7ea67faf87b67..a7b92531f5c9c71b4f8a6122d66f02af9dd2b123 100755 (executable)
--- a/t/img.t
+++ b/t/img.t
@@ -18,18 +18,39 @@ use Test::More;
 BEGIN { use_ok("IkiWiki"); }
 BEGIN { use_ok("Image::Magick"); }
 
+my $magick = new Image::Magick;
+my $SVGS_WORK = defined $magick->QueryFormat("svg");
+
 ok(! system("rm -rf t/tmp; mkdir -p t/tmp/in"));
 
 ok(! system("cp t/img/redsquare.png t/tmp/in/redsquare.png"));
-writefile("emptysquare.svg", "t/tmp/in", '<svg width="30" height="30"/>');
+# colons in filenames are a corner case for img
+ok(! system("cp t/img/redsquare.png t/tmp/in/hello:world.png"));
+ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c.png"));
+ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c:d.png"));
+ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c:d:e:f:g:h:i:j.png"));
+
+if ($SVGS_WORK) {
+       writefile("emptysquare.svg", "t/tmp/in",
+               '<svg width="30" height="30"><rect x="0" y="0" width="30" height="30" fill="blue"/></svg>');
+}
+
 # using different image sizes for different pages, so the pagenumber selection can be tested easily
 ok(! system("cp t/img/twopages.pdf t/tmp/in/twopages.pdf"));
 
+my $maybe_svg_img = "";
+if ($SVGS_WORK) {
+       $maybe_svg_img = "[[!img emptysquare.svg size=10x]]";
+}
+
 writefile("imgconversions.mdwn", "t/tmp/in", <<EOF
 [[!img redsquare.png]]
 [[!img redsquare.png size=10x]]
 [[!img redsquare.png size=30x50]] expecting 30x30
-[[!img emptysquare.svg size=10x]]
+[[!img hello:world.png size=x8]] expecting 8x8
+[[!img a:b:c.png size=x4]]
+[[!img a:b:c:d:e:f:g:h:i:j.png size=x6]]
+$maybe_svg_img
 [[!img twopages.pdf size=12x]]
 [[!img twopages.pdf size=16x pagenumber=1]]
 EOF
@@ -44,7 +65,7 @@ ok(! system($command));
 sub size($) {
        my $filename = shift;
        my $im = Image::Magick->new();
-       my $r = $im->Read($filename);
+       my $r = $im->Read(":$filename");
        return "no image" if $r;
        my $w = $im->Get("width");
        my $h = $im->Get("height");
@@ -57,10 +78,18 @@ my $outhtml = readfile("$outpath.html");
 is(size("$outpath/10x-redsquare.png"), "10x10");
 ok(! -e "$outpath/30x-redsquare.png");
 ok($outhtml =~ /width="30" height="30".*expecting 30x30/);
-# if this fails, you need libmagickcore-6.q16-2-extra installed
-is(size("$outpath/10x-emptysquare.png"), "10x10");
+
+if ($SVGS_WORK) {
+       # if this fails, you need libmagickcore-6.q16-2-extra installed
+       is(size("$outpath/10x-emptysquare.png"), "10x10");
+}
+
 is(size("$outpath/12x-twopages.png"), "12x12");
 is(size("$outpath/16x-p1-twopages.png"), "16x2");
+ok($outhtml =~ /width="8" height="8".*expecting 8x8/);
+is(size("$outpath/x8-hello:world.png"), "8x8");
+is(size("$outpath/x4-a:b:c.png"), "4x4");
+is(size("$outpath/x6-a:b:c:d:e:f:g:h:i:j.png"), "6x6");
 
 # now let's remove them again
 
@@ -73,6 +102,9 @@ if (1) { # for easier testing
        ok(! -e "$outpath/10x-simple-svg.png");
        ok(! -e "$outpath/10x-simple-pdf.png");
        ok(! -e "$outpath/10x-p1-simple-pdf.png");
+       ok(! -e "$outpath/x8-hello:world.png");
+       ok(! -e "$outpath/x4-a:b:c.png");
+       ok(! -e "$outpath/x6-a:b:c:d:e:f:g:h:i:j.png");
 
        # cleanup
        ok(! system("rm -rf t/tmp"));