2 # Copyright © 2006-2008 Joey Hess <joey@ikiwiki.info>
3 # Copyright © 2008 Simon McVittie <http://smcv.pseudorandom.co.uk/>
4 # Licensed under the GNU GPL, version 2, or any later version published by the
5 # Free Software Foundation
6 package IkiWiki::Plugin::comments;
12 use POSIX qw(strftime);
14 use constant PREVIEW => "Preview";
15 use constant POST_COMMENT => "Post comment";
16 use constant CANCEL => "Cancel";
22 hook(type => "checkconfig", id => 'comments', call => \&checkconfig);
23 hook(type => "getsetup", id => 'comments', call => \&getsetup);
24 hook(type => "preprocess", id => 'comment', call => \&preprocess);
25 hook(type => "preprocess", id => 'commentmoderation', call => \&preprocess_moderation);
26 # here for backwards compatability with old comments
27 hook(type => "preprocess", id => '_comment', call => \&preprocess);
28 hook(type => "sessioncgi", id => 'comment', call => \&sessioncgi);
29 hook(type => "htmlize", id => "_comment", call => \&htmlize);
30 hook(type => "htmlize", id => "_comment_pending",
31 call => \&htmlize_pending);
32 hook(type => "pagetemplate", id => "comments", call => \&pagetemplate);
33 hook(type => "formbuilder_setup", id => "comments",
34 call => \&formbuilder_setup);
35 # Load goto to fix up user page links for logged-in commenters
36 IkiWiki::loadplugin("goto");
37 IkiWiki::loadplugin("inline");
47 comments_pagespec => {
49 example => 'blog/* and !*/Discussion',
50 description => 'PageSpec of pages where comments are allowed',
51 link => 'ikiwiki/PageSpec',
55 comments_closed_pagespec => {
57 example => 'blog/controversial or blog/flamewar',
58 description => 'PageSpec of pages where posting new comments is not allowed',
59 link => 'ikiwiki/PageSpec',
63 comments_pagename => {
65 default => 'comment_',
66 description => 'Base name for comments, e.g. "comment_" for pages like "sandbox/comment_12"',
67 safe => 0, # manual page moving required
70 comments_allowdirectives => {
73 description => 'Interpret directives in comments?',
77 comments_allowauthor => {
80 description => 'Allow anonymous commenters to set an author name?',
87 description => 'commit comments to the VCS',
88 # old uncommitted comments are likely to cause
89 # confusion if this is changed
96 $config{comments_commit} = 1
97 unless defined $config{comments_commit};
98 $config{comments_pagespec} = ''
99 unless defined $config{comments_pagespec};
100 $config{comments_closed_pagespec} = ''
101 unless defined $config{comments_closed_pagespec};
102 $config{comments_pagename} = 'comment_'
103 unless defined $config{comments_pagename};
108 return $params{content};
111 sub htmlize_pending {
113 return sprintf(gettext("this comment needs %s"),
115 IkiWiki::cgiurl(do => "commentmoderation").'">'.
116 gettext("moderation").'</a>');
119 # FIXME: copied verbatim from meta
122 if (exists $IkiWiki::Plugin::htmlscrubber::{safe_url_regexp} &&
123 defined $IkiWiki::Plugin::htmlscrubber::safe_url_regexp) {
124 return $url=~/$IkiWiki::Plugin::htmlscrubber::safe_url_regexp/;
133 my $page = $params{page};
135 my $format = $params{format};
136 if (defined $format && ! exists $IkiWiki::hooks{htmlize}{$format}) {
137 error(sprintf(gettext("unsupported page format %s"), $format));
140 my $content = $params{content};
141 if (! defined $content) {
142 error(gettext("comment must have content"));
144 $content =~ s/\\"/"/g;
146 if ($config{comments_allowdirectives}) {
147 $content = IkiWiki::preprocess($page, $params{destpage},
151 # no need to bother with htmlize if it's just HTML
152 $content = IkiWiki::htmlize($page, $params{destpage}, $format, $content)
155 IkiWiki::run_hooks(sanitize => sub {
158 destpage => $params{destpage},
163 # set metadata, possibly overriding [[!meta]] directives from the
169 my $commentauthorurl;
171 if (defined $params{username}) {
172 $commentuser = $params{username};
174 my $oiduser = eval { IkiWiki::openiduser($commentuser) };
176 if (defined $oiduser) {
177 # looks like an OpenID
178 $commentauthorurl = $commentuser;
179 $commentauthor = (defined $params{nickname} && length $params{nickname}) ? $params{nickname} : $oiduser;
180 $commentopenid = $commentuser;
183 $commentauthorurl = IkiWiki::cgiurl(
185 page => IkiWiki::userpage($commentuser)
188 $commentauthor = $commentuser;
192 if (defined $params{ip}) {
193 $commentip = $params{ip};
195 $commentauthor = gettext("Anonymous");
198 $commentstate{$page}{commentuser} = $commentuser;
199 $commentstate{$page}{commentopenid} = $commentopenid;
200 $commentstate{$page}{commentip} = $commentip;
201 $commentstate{$page}{commentauthor} = $commentauthor;
202 $commentstate{$page}{commentauthorurl} = $commentauthorurl;
203 if (! defined $pagestate{$page}{meta}{author}) {
204 $pagestate{$page}{meta}{author} = $commentauthor;
206 if (! defined $pagestate{$page}{meta}{authorurl}) {
207 $pagestate{$page}{meta}{authorurl} = $commentauthorurl;
210 if ($config{comments_allowauthor}) {
211 if (defined $params{claimedauthor}) {
212 $pagestate{$page}{meta}{author} = $params{claimedauthor};
215 if (defined $params{url}) {
216 my $url=$params{url};
218 eval q{use URI::Heuristic};
220 $url=URI::Heuristic::uf_uristr($url);
224 $pagestate{$page}{meta}{authorurl} = $url;
229 $pagestate{$page}{meta}{author} = $commentauthor;
230 $pagestate{$page}{meta}{authorurl} = $commentauthorurl;
233 if (defined $params{subject}) {
234 # decode title the same way meta does
235 eval q{use HTML::Entities};
236 $pagestate{$page}{meta}{title} = decode_entities($params{subject});
239 if ($params{page} =~ m/\/\Q$config{comments_pagename}\E\d+_/) {
240 $pagestate{$page}{meta}{permalink} = urlto(IkiWiki::dirname($params{page}), undef, 1).
241 "#".page_to_id($params{page});
244 eval q{use Date::Parse};
246 my $time = str2time($params{date});
247 $IkiWiki::pagectime{$page} = $time if defined $time;
253 sub preprocess_moderation {
256 $params{desc}=gettext("Comment Moderation")
257 unless defined $params{desc};
259 if (length $config{cgiurl}) {
261 IkiWiki::cgiurl(do => 'commentmoderation').
262 '">'.$params{desc}.'</a>';
265 return $params{desc};
269 sub sessioncgi ($$) {
273 my $do = $cgi->param('do');
274 if ($do eq 'comment') {
275 editcomment($cgi, $session);
277 elsif ($do eq 'commentmoderation') {
278 commentmoderation($cgi, $session);
280 elsif ($do eq 'commentsignin') {
281 IkiWiki::cgi_signin($cgi, $session);
286 # Mostly cargo-culted from IkiWiki::plugin::editpage
287 sub editcomment ($$) {
291 IkiWiki::decode_cgi_utf8($cgi);
293 eval q{use CGI::FormBuilder};
296 my @buttons = (POST_COMMENT, PREVIEW, CANCEL);
297 my $form = CGI::FormBuilder->new(
298 fields => [qw{do sid page subject editcontent type author url}],
301 required => [qw{editcontent}],
304 action => $config{cgiurl},
307 template => { template('editcomment.tmpl') },
310 IkiWiki::decode_form_utf8($form);
311 IkiWiki::run_hooks(formbuilder_setup => sub {
312 shift->(title => "comment", form => $form, cgi => $cgi,
313 session => $session, buttons => \@buttons);
315 IkiWiki::decode_form_utf8($form);
317 my $type = $form->param('type');
318 if (defined $type && length $type && $IkiWiki::hooks{htmlize}{$type}) {
319 $type = IkiWiki::possibly_foolish_untaint($type);
322 $type = $config{default_pageext};
327 if (exists $IkiWiki::hooks{htmlize}) {
328 foreach my $key (grep { !/^_/ } keys %{$IkiWiki::hooks{htmlize}}) {
329 push @page_types, [$key, $IkiWiki::hooks{htmlize}{$key}{longname} || $key];
332 @page_types=sort @page_types;
334 $form->field(name => 'do', type => 'hidden');
335 $form->field(name => 'sid', type => 'hidden', value => $session->id,
337 $form->field(name => 'page', type => 'hidden');
338 $form->field(name => 'subject', type => 'text', size => 72);
339 $form->field(name => 'editcontent', type => 'textarea', rows => 10);
340 $form->field(name => "type", value => $type, force => 1,
341 type => 'select', options => \@page_types);
343 $form->tmpl_param(username => $session->param('name'));
345 if ($config{comments_allowauthor} and
346 ! defined $session->param('name')) {
347 $form->tmpl_param(allowauthor => 1);
348 $form->field(name => 'author', type => 'text', size => '40');
349 $form->field(name => 'url', type => 'text', size => '40');
352 $form->tmpl_param(allowauthor => 0);
353 $form->field(name => 'author', type => 'hidden', value => '',
355 $form->field(name => 'url', type => 'hidden', value => '',
359 if (! defined $session->param('name')) {
360 # Make signinurl work and return here.
361 $form->tmpl_param(signinurl => IkiWiki::cgiurl(do => 'commentsignin'));
362 $session->param(postsignin => $ENV{QUERY_STRING});
363 IkiWiki::cgi_savesession($session);
366 # The untaint is OK (as in editpage) because we're about to pass
367 # it to file_pruned anyway
368 my $page = $form->field('page');
369 $page = IkiWiki::possibly_foolish_untaint($page);
370 if (! defined $page || ! length $page ||
371 IkiWiki::file_pruned($page)) {
372 error(gettext("bad page name"));
375 my $baseurl = urlto($page, undef, 1);
377 $form->title(sprintf(gettext("commenting on %s"),
378 IkiWiki::pagetitle($page)));
380 $form->tmpl_param('helponformattinglink',
381 htmllink($page, $page, 'ikiwiki/formatting',
383 linktext => 'FormattingHelp'),
384 allowdirectives => $config{allow_directives});
386 if ($form->submitted eq CANCEL) {
387 # bounce back to the page they wanted to comment on, and exit.
388 # CANCEL need not be considered in future
389 IkiWiki::redirect($cgi, urlto($page, undef, 1));
393 if (not exists $pagesources{$page}) {
394 error(sprintf(gettext(
395 "page '%s' doesn't exist, so you can't comment"),
399 if (pagespec_match($page, $config{comments_closed_pagespec},
400 location => $page)) {
401 error(sprintf(gettext(
402 "comments on page '%s' are closed"),
406 # Set a flag to indicate that we're posting a comment,
407 # so that postcomment() can tell it should match.
409 IkiWiki::check_canedit($page, $cgi, $session);
412 my $content = "[[!comment format=$type\n";
414 if (defined $session->param('name')) {
415 my $username = $session->param('name');
416 $username =~ s/"/"/g;
417 $content .= " username=\"$username\"\n";
419 if (defined $session->param('nickname')) {
420 my $nickname = $session->param('nickname');
421 $nickname =~ s/"/"/g;
422 $content .= " nickname=\"$nickname\"\n";
424 elsif (defined $session->remote_addr()) {
425 my $ip = $session->remote_addr();
426 if ($ip =~ m/^([.0-9]+)$/) {
427 $content .= " ip=\"$1\"\n";
431 if ($config{comments_allowauthor}) {
432 my $author = $form->field('author');
433 if (defined $author && length $author) {
434 $author =~ s/"/"/g;
435 $content .= " claimedauthor=\"$author\"\n";
437 my $url = $form->field('url');
438 if (defined $url && length $url) {
439 $url =~ s/"/"/g;
440 $content .= " url=\"$url\"\n";
444 my $subject = $form->field('subject');
445 if (defined $subject && length $subject) {
446 $subject =~ s/"/"/g;
449 $subject = "comment ".(num_comments($page, $config{srcdir}) + 1);
451 $content .= " subject=\"$subject\"\n";
453 $content .= " date=\"" . decode_utf8(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime)) . "\"\n";
455 my $editcontent = $form->field('editcontent');
456 $editcontent="" if ! defined $editcontent;
457 $editcontent =~ s/\r\n/\n/g;
458 $editcontent =~ s/\r/\n/g;
459 $editcontent =~ s/"/\\"/g;
460 $content .= " content=\"\"\"\n$editcontent\n\"\"\"]]\n";
462 my $location=unique_comment_location($page, $content, $config{srcdir});
464 # This is essentially a simplified version of editpage:
465 # - the user does not control the page that's created, only the parent
466 # - it's always a create operation, never an edit
467 # - this means that conflicts should never happen
468 # - this means that if they do, rocks fall and everyone dies
470 if ($form->submitted eq PREVIEW) {
471 my $preview=previewcomment($content, $location, $page, time);
472 IkiWiki::run_hooks(format => sub {
473 $preview = shift->(page => $page,
474 content => $preview);
476 $form->tmpl_param(page_preview => $preview);
479 $form->tmpl_param(page_preview => "");
482 if ($form->submitted eq POST_COMMENT && $form->validate) {
483 IkiWiki::checksessionexpiry($cgi, $session);
486 my $ok=IkiWiki::check_content(content => $form->field('editcontent'),
487 subject => $form->field('subject'),
488 $config{comments_allowauthor} ? (
489 author => $form->field('author'),
490 url => $form->field('url'),
500 $location=unique_comment_location($page, $content, $config{srcdir}, "._comment_pending");
501 writefile("$location._comment_pending", $config{srcdir}, $content);
503 # Refresh so anything that deals with pending
504 # comments can be updated.
505 require IkiWiki::Render;
507 IkiWiki::saveindex();
509 IkiWiki::printheader($session);
510 print IkiWiki::misctemplate(gettext(gettext("comment stored for moderation")),
512 gettext("Your comment will be posted after moderator review").
517 # FIXME: could probably do some sort of graceful retry
518 # on error? Would require significant unwinding though
519 my $file = "$location._comment";
520 writefile($file, $config{srcdir}, $content);
524 if ($config{rcs} and $config{comments_commit}) {
525 my $message = gettext("Added a comment");
526 if (defined $form->field('subject') &&
527 length $form->field('subject')) {
529 gettext("Added a comment: %s"),
530 $form->field('subject'));
533 IkiWiki::rcs_add($file);
534 IkiWiki::disable_commit_hook();
535 $conflict = IkiWiki::rcs_commit_staged(
539 IkiWiki::enable_commit_hook();
540 IkiWiki::rcs_update();
543 # Now we need a refresh
544 require IkiWiki::Render;
546 IkiWiki::saveindex();
548 # this should never happen, unless a committer deliberately
549 # breaks it or something
550 error($conflict) if defined $conflict;
552 # Jump to the new comment on the page.
553 # The trailing question mark tries to avoid broken
554 # caches and get the most recent version of the page.
555 IkiWiki::redirect($cgi, urlto($page, undef, 1).
556 "?updated#".page_to_id($location));
560 IkiWiki::showform ($form, \@buttons, $session, $cgi,
561 forcebaseurl => $baseurl, page => $page);
567 sub commentmoderation ($$) {
571 IkiWiki::needsignin($cgi, $session);
572 if (! IkiWiki::is_admin($session->param("name"))) {
573 error(gettext("you are not logged in as an admin"));
576 IkiWiki::decode_cgi_utf8($cgi);
578 if (defined $cgi->param('sid')) {
579 IkiWiki::checksessionexpiry($cgi, $session);
581 my $rejectalldefer=$cgi->param('rejectalldefer');
585 foreach my $id (keys %vars) {
586 if ($id =~ /(.*)\._comment(?:_pending)?$/) {
587 $id=decode_utf8($id);
588 my $action=$cgi->param($id);
589 next if $action eq 'Defer' && ! $rejectalldefer;
591 # Make sure that the id is of a legal
593 my ($f) = $id =~ /$config{wiki_file_regexp}/;
594 if (! defined $f || ! length $f ||
595 IkiWiki::file_pruned($f)) {
596 error("illegal file");
599 my $page=IkiWiki::dirname($f);
600 my $file="$config{srcdir}/$f";
603 $file="$config{wikistatedir}/comments_pending/".$f;
606 if ($action eq 'Accept') {
607 my $content=eval { readfile($file) };
608 next if $@; # file vanished since form was displayed
609 my $dest=unique_comment_location($page, $content, $config{srcdir})."._comment";
610 writefile($dest, $config{srcdir}, $content);
611 if ($config{rcs} and $config{comments_commit}) {
612 IkiWiki::rcs_add($dest);
617 require IkiWiki::Render;
618 IkiWiki::prune($file);
624 if ($config{rcs} and $config{comments_commit}) {
625 my $message = gettext("Comment moderation");
626 IkiWiki::disable_commit_hook();
627 $conflict=IkiWiki::rcs_commit_staged(
631 IkiWiki::enable_commit_hook();
632 IkiWiki::rcs_update();
635 # Now we need a refresh
636 require IkiWiki::Render;
638 IkiWiki::saveindex();
640 error($conflict) if defined $conflict;
645 my ($id, $dir, $ctime)=@{$_};
646 my $content=readfile("$dir/$id");
647 my $preview=previewcomment($content, $id,
653 } sort { $b->[2] <=> $a->[2] } comments_pending();
655 my $template=template("commentmoderation.tmpl");
658 comments => \@comments,
660 IkiWiki::printheader($session);
661 my $out=$template->output;
662 IkiWiki::run_hooks(format => sub {
663 $out = shift->(page => "", content => $out);
665 print IkiWiki::misctemplate(gettext("comment moderation"), $out);
669 sub formbuilder_setup (@) {
672 my $form=$params{form};
673 if ($form->title eq "preferences" &&
674 IkiWiki::is_admin($params{session}->param("name"))) {
675 push @{$params{buttons}}, "Comment Moderation";
676 if ($form->submitted && $form->submitted eq "Comment Moderation") {
677 commentmoderation($params{cgi}, $params{session});
682 sub comments_pending () {
685 eval q{use File::Find};
689 my $origdir=getcwd();
691 my $find_comments=sub {
694 return unless -d $dir;
696 chdir($dir) || die "chdir $dir: $!";
701 my $file=decode_utf8($_);
703 return if ! length $file || IkiWiki::file_pruned($file)
704 || -l $_ || -d _ || $file !~ /\Q$extension\E$/;
705 my ($f) = $file =~ /$config{wiki_file_regexp}/; # untaint
707 my $ctime=(stat($_))[10];
708 push @ret, [$f, $dir, $ctime];
713 chdir($origdir) || die "chdir $origdir: $!";
716 $find_comments->($config{srcdir}, "._comment_pending");
718 $find_comments->("$config{wikistatedir}/comments_pending/",
724 sub previewcomment ($$$) {
730 my $preview = IkiWiki::htmlize($location, $page, '_comment',
731 IkiWiki::linkify($location, $page,
732 IkiWiki::preprocess($location, $page,
733 IkiWiki::filter($location, $page, $content), 0, 1)));
735 my $template = template("comment.tmpl");
736 $template->param(content => $preview);
737 $template->param(ctime => displaytime($time, undef, 1));
738 $template->param(html5 => $config{html5});
740 IkiWiki::run_hooks(pagetemplate => sub {
741 shift->(page => $location,
743 template => $template);
746 $template->param(have_actions => 0);
748 return $template->output;
751 sub commentsshown ($) {
754 return ! pagespec_match($page, "comment(*)",
755 location => $page) &&
756 pagespec_match($page, $config{comments_pagespec},
760 sub commentsopen ($) {
763 return length $config{cgiurl} > 0 &&
764 (! length $config{comments_closed_pagespec} ||
765 ! pagespec_match($page, $config{comments_closed_pagespec},
769 sub pagetemplate (@) {
772 my $page = $params{page};
773 my $template = $params{template};
774 my $shown = ($template->query(name => 'commentslink') ||
775 $template->query(name => 'commentsurl') ||
776 $template->query(name => 'atomcommentsurl') ||
777 $template->query(name => 'comments')) &&
778 commentsshown($page);
780 if ($template->query(name => 'comments')) {
781 my $comments = undef;
783 $comments = IkiWiki::preprocess_inline(
784 pages => "comment($page)",
785 template => 'comment',
789 destpage => $params{destpage},
790 feedfile => 'comments',
795 if (defined $comments && length $comments) {
796 $template->param(comments => $comments);
799 if ($shown && commentsopen($page)) {
800 $template->param(addcommenturl => addcommenturl($page));
805 if ($template->query(name => 'commentsurl')) {
806 $template->param(commentsurl =>
807 urlto($page, undef, 1).'#comments');
810 if ($template->query(name => 'atomcommentsurl') && $config{usedirs}) {
811 # This will 404 until there are some comments, but I
812 # think that's probably OK...
813 $template->param(atomcommentsurl =>
814 urlto($page, undef, 1).'comments.atom');
817 if ($template->query(name => 'commentslink')) {
818 my $num=num_comments($page, $config{srcdir});
821 $link = htmllink($page, $params{destpage}, $page,
822 linktext => sprintf(ngettext("%i comment", "%i comments", $num), $num),
823 anchor => "comments",
827 elsif (commentsopen($page)) {
828 $link = "<a href=\"".addcommenturl($page)."\">".
829 #translators: Here "Comment" is a verb;
830 #translators: the user clicks on it to
831 #translators: post a comment.
835 $template->param(commentslink => $link)
840 # everything below this point is only relevant to the comments
842 if (!exists $commentstate{$page}) {
846 if ($template->query(name => 'commentid')) {
847 $template->param(commentid => page_to_id($page));
850 if ($template->query(name => 'commentuser')) {
851 $template->param(commentuser =>
852 $commentstate{$page}{commentuser});
855 if ($template->query(name => 'commentopenid')) {
856 $template->param(commentopenid =>
857 $commentstate{$page}{commentopenid});
860 if ($template->query(name => 'commentip')) {
861 $template->param(commentip =>
862 $commentstate{$page}{commentip});
865 if ($template->query(name => 'commentauthor')) {
866 $template->param(commentauthor =>
867 $commentstate{$page}{commentauthor});
870 if ($template->query(name => 'commentauthorurl')) {
871 $template->param(commentauthorurl =>
872 $commentstate{$page}{commentauthorurl});
875 if ($template->query(name => 'removeurl') &&
876 IkiWiki::Plugin::remove->can("check_canremove") &&
877 length $config{cgiurl}) {
878 $template->param(removeurl => IkiWiki::cgiurl(do => 'remove',
880 $template->param(have_actions => 1);
884 sub addcommenturl ($) {
887 return IkiWiki::cgiurl(do => 'comment', page => $page);
890 sub num_comments ($$) {
894 my @comments=glob("$dir/$page/$config{comments_pagename}*._comment");
895 return int @comments;
898 sub unique_comment_location ($$$$) {
900 eval q{use Digest::MD5 'md5_hex'};
902 my $content_md5=md5_hex(Encode::encode_utf8(shift));
904 my $ext=shift || "._comment";
907 my $i = num_comments($page, $dir);
910 $location = "$page/$config{comments_pagename}${i}_${content_md5}";
911 } while (-e "$dir/$location$ext");
917 # Converts a comment page name into a unique, legal html id
918 # attribute value, that can be used as an anchor to link to the
922 eval q{use Digest::MD5 'md5_hex'};
925 return "comment-".md5_hex(Encode::encode_utf8(($page)));
928 package IkiWiki::PageSpec;
930 sub match_postcomment ($$;@) {
934 if (! $postcomment) {
935 return IkiWiki::FailReason->new("not posting a comment");
937 return match_glob($page, $glob, @_);
940 sub match_comment ($$;@) {
944 # To see if it's a comment, check the source file type.
945 # Deal with comments that were just deleted.
946 my $source=exists $IkiWiki::pagesources{$page} ?
947 $IkiWiki::pagesources{$page} :
948 $IkiWiki::delpagesources{$page};
949 my $type=defined $source ? IkiWiki::pagetype($source) : undef;
950 if (! defined $type || $type ne "_comment") {
951 return IkiWiki::FailReason->new("$page is not a comment");
954 return match_glob($page, "$glob/*", internal => 1, @_);
957 sub match_comment_pending ($$;@) {
961 my $source=exists $IkiWiki::pagesources{$page} ?
962 $IkiWiki::pagesources{$page} :
963 $IkiWiki::delpagesources{$page};
964 my $type=defined $source ? IkiWiki::pagetype($source) : undef;
965 if (! defined $type || $type ne "_comment_pending") {
966 return IkiWiki::FailReason->new("$page is not a pending comment");
969 return match_glob($page, "$glob/*", internal => 1, @_);