1 I would like to add next plugin to Ikiwiki. It's `progressbar` or simply `progress`.
2 I'm not sure what plugin name better is, probably that shorter ;) I know that
3 [DokuWiki](http://wiki.splitbrain.org/plugin:progressbar) has similar plugin,
4 so I think it can be useful also for Ikiwiki users.
6 Here is proposition of the plugin syntax:
10 Of course, `done` argument is integer from 0 to 100.
12 A here is its HTML result:
14 <div class="progress">
15 <div class="progress-done" style="width: 50%">50%</div>
18 Note: I was trying with `<span>` tags too, but that tag is inline, so I can't
19 set `width` property for it.
21 > In the poll plugin, I ended up using a `<hr>` for the progress-like
22 > thing. One reason I did so is because it actually works in text-mode
23 > browsers (w3m, lynx), that do not support css or colorized
24 > divs. Since the hr is an element they display, just setting its width can
25 > make a basic progress-type display. The style then makes it display
26 > better in more capable browsers.
28 > The other advantage to that approach is that the htmlscrubber lets
29 > through the `class` and `width` fields, that are all that are needed for
30 > it to work. No need to work around htmlscrubber.
32 > So I suggest adapting this to use similar html. --[[Joey]]
34 >> I just had a brief play with this. It seems there are some trade-offs involved.
35 >> The `width` attribute of an `<hr>` tag is deprecated, but that's not the big one.
36 >> I can't see how to place text next to an `<hr>` tag. I note that in the
37 >> [[plugins/poll]] plugin there is text above and below the 'graph line', but none
38 >> on the same line as the graph. I prefer the way the current code renders,
39 >> with the percentage complete appearing as text inside the graph.
41 >> So, if we use `hr` we get:
43 >> - Graph line on text / non-css browsers
44 >> - No percentage complete text on the same line as the graph line
47 >> If we use `div` we get:
49 >> - Need to clean up after HTMLScrubber (which is not hard - already implemented)
50 >> - Get the percentage written as text on text / non-css browsers
51 >> - Get the percentage on the same line as the graph in css browsers
53 >> I'm strongly in favour of having the percentage text label on the graph, and on
54 >> text based browsers I think having the text label is enough -- the lack of the line
55 >> in that case doesn't bother me.
56 >> So, given the choice between the two suggested techniques, I'd take the second and
57 >> stay with div... unless you know how to get text next to (or within) an `<hr>` tag. -- [[Will]]
59 Default CSS styles for the plugin can be like below:
62 border: 1px solid #ddd;
63 /* border: 2px solid #ddd; */
68 border: 2px solid #aaa;
76 vertical-align: middle;
79 You can use alternative, commented CSS code for `div.progress` if you dislike
80 padding around done strip.
82 Any comments? --[[Paweł|ptecza]]
84 > Please make sure to always set a foreground color if a background color is
85 > set, and use '!important' so the foreground color can be overridden. (CSS
86 > best practices) --[[Joey]]
88 >> Below is the CSS I've been using -- [[Will]]
93 border: 1px solid #888;
96 color: black !important;
100 background: #ea6 !important;
101 color: black !important;
106 > This looks like a nice idea. If I could add one further suggestion: Allow your
107 > ratio to be a pair of pagespecs. Then you could have something like:
109 \[[!progress totalpages="bugs/* and backlink(milestoneB)" donepages="bugs/* and backlink(milestoneB) and !link(bugs/done)"]]
111 > to have a progress bar marking how many bugs were compete for a
112 > particular milestone. -- [[Will]]
114 >> Thanks a lot for your comment, Will! It seems very interesting for me.
115 >> I need to think more about improving that plugin. --[[Paweł|ptecza]]
117 >> Attached is a [[patch]] (well, source) for this. You also need to add the proposed CSS above to `style.css`.
118 >> At the moment this plugin interacts poorly with the [[plugins/htmlscrubber]] plugin.
119 >> HTMLScrubber plugin removes the `style` attribute from the `progress-done` `div` tag, and so it defaults
120 >> to a width of 100%. -- [[Will]]
122 >>> Thank you for the code! I know how to fix that problem, because I had
123 >>> the same issue while writing [[todo/color_plugin]] :) --[[Paweł|ptecza]]
125 >>>> Ahh - good idea. Patch updated to work with HTMLScrubber. --[[Will]]
127 >>>>> I like it, but I think that Joey should take a look at that patch too :)
128 >>>>> --[[Paweł|ptecza]]
131 package IkiWiki::Plugin::progress;
137 my $percentage_pattern = qr/[0-9]+\%/; # pattern to validate percentages
140 hook(type => "getsetup", id => "progress", call => \&getsetup);
141 hook(type => "preprocess", id => "progress", call => \&preprocess);
142 hook(type => "format", id => "progress", call => \&format);
145 sub getsetup () { #{{{
153 sub preprocess (@) { #{{{
158 if (defined $params{percent}) {
159 $fill = $params{percent};
160 ($fill) = $fill =~ m/($percentage_pattern)/; # fill is untainted now
162 elsif (defined $params{totalpages} and defined $params{donepages}) {
163 add_depends($params{page}, $params{totalpages});
164 add_depends($params{page}, $params{donepages});
166 my @pages=keys %pagesources;
169 foreach my $page (@pages) {
170 $totalcount++ if pagespec_match($page, $params{totalpages}, location => $params{page});
171 $donecount++ if pagespec_match($page, $params{donepages}, location => $params{page});
174 if ($totalcount == 0) {
177 my $number = $donecount/$totalcount*100;
178 $fill = sprintf("%u%%", $number);
182 error("Missing parameters to progress plugin. Need either `percent` or `totalpages` and `donepages` parameters.");
186 <div class="progress">
187 <div class="progress-done" style="width: $fill">$fill</div>
196 # If HTMLScrubber has removed the style attribute, then bring it back
198 $params{content} =~ s!<div class="progress-done">($percentage_pattern)</div>!<div class="progress-done" style="width: $1">$1</div>!g;
200 return $params{content};
205 Here is a potential documentation page:
209 [[!template id=plugin name=progress author="[[Will]]"]]
212 Provides a \\[[!progress ]] [[ikiwiki/Directive]] that is
213 replaced with a progress bar.
215 There are two possible parameter sets. The first is a single parameter
216 `percent` which holds a percentage figure for how complete the progress bar is.
218 The second possible set of parameters is a pair of [[ikiwiki/PageSpec]]s,
219 `totalpages` and `donepages`. The progress plugin counts the number of
220 pages in each pagespec and shows the percentage of the total pages that are
223 This plugin is included in ikiwiki, but is not enabled by default.
225 If it is turned on it can show what percentage of pages have discussion pages:
227 \[[!progress totalpages="* and !*/Discussion" donepages="*/Discussion"]]