doc/recentchanges/change_5954915a4fe8a889b8217cac99fae53cbe7f1e97._change

   1 [[!meta author="""joey"""]]
   2
   3 [[!meta authorurl="""http://ikiwiki.info/ikiwiki.cgi?page=users%2Fjoey&amp;do=goto"""]]
   4
   5 [[!meta title="""change to todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both on ikiwiki"""]]
   6
   7 [[!meta permalink="http://ikiwiki.info/recentchanges/#change-5954915a4fe8a889b8217cac99fae53cbe7f1e97"]]
   8
   9 <div id="change-5954915a4fe8a889b8217cac99fae53cbe7f1e97" class="metadata">
  10 <span class="desc"><br />Changed pages:</span>
  11 <span class="pagelinks">
  12
  13 <a href="http://git.ikiwiki.info/?p=ikiwiki;a=blobdiff;f=doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn;h=f8ec4c420469f47168ced54b93dbe75fa39dfdab;hp=80925b458287767620d8862f782e77b1bd7dda63;hb=5954915a4fe8a889b8217cac99fae53cbe7f1e97;hpb=d916cd2f71f1c22dad947d7b2134edbbb15e7b8e" title="diff" rel="nofollow">[[diff|wikiicons/diff.png]]</a><a href="http://ikiwiki.info/ikiwiki.cgi?page=todo%2Fwant_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both&amp;do=goto" rel="nofollow">todo/want to avoid ikiwiki using http or https in urls to allow serving both</a>
  14
  15
  16 </span>
  17 <span class="desc"><br />Changed by:</span>
  18 <span class="committer">
  19
  20 <a href="http://ikiwiki.info/ikiwiki.cgi?page=users%2Fjoey&amp;do=goto" rel="nofollow">joey</a>
  21
  22 </span>
  23 <span class="desc"><br />Commit type:</span>
  24 <span class="committype">git</span>
  25 <span class="desc"><br />Date:</span>
  26 <span class="changedate"><span class="relativedate" title="Mon, 22 Nov 2010 20:04:11 +0000">20:04:11 11/22/10</span></span>
  27 <span class="desc"><br /></span>
  28 </div>
  29
  30 <span class="revert">
  31 <a href="http://ikiwiki.info/ikiwiki.cgi?rev=5954915a4fe8a889b8217cac99fae53cbe7f1e97&amp;do=revert" title="revert" rel="nofollow">[[revert|wikiicons/revert.png]]</a>
  32 </span>
  33
  34 <div class="changelog">
  35
  36
  37 response<br />
  38
  39
  40 </div>
  41
  42 <div class="diff">
  43 <pre>
  44 diff --git a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
  45 index 80925b4..f8ec4c4 100644
  46 --- a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
  47 +++ b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
  48 @@ -201,6 +201,10 @@ New API added by this branch:
  49    &gt;&gt;
  50    &gt;&gt; I personally think breaking the docwiki is enough to block that.
  51    &gt;&gt;
  52 +  &gt;&gt;&gt; Well, the docwiki doesn&#39;t have an url configured at all, so I assumed
  53 +  &gt;&gt;&gt; it would need to fall back to current behavior in that case. I had
  54 +  &gt;&gt;&gt; not thought about browsing wiki&#39;s html files though, good point.
  55 +  &gt;&gt;
  56    &gt;&gt; How about this?
  57    &gt;&gt;
  58    &gt;&gt; * `urlto($link, $page)` with `$page` defined: relative
  59 @@ -210,12 +214,24 @@ New API added by this branch:
  60    &gt;&gt;   normally undef): absolute, starts with `http&#91;s&#93;://`
  61    &gt;&gt;
  62    &gt;&gt; --&#91;&#91;smcv&#93;&#93;
  63 +  &gt;&gt;
  64 +  &gt;&gt;&gt; That makes a great deal of sense, bravo for actually removing
  65 +  &gt;&gt;&gt; parameters in the common case while maintaining backwards
  66 +  &gt;&gt;&gt; compatability!
  67 +  &gt;&gt;&gt;
  68 +  &gt;&gt;&gt; It does highlight that it would be better to have a
  69 +  &gt;&gt;&gt; `absolute_urlto($link)` (or maybe `absolute(urlto($link))` )
  70 +  &gt;&gt;&gt; rather than the 3 parameter form. --&#91;&#91;Joey&#93;&#93;
  71
  72  * `IkiWiki::baseurl` has a new second argument which works like the
  73    third argument of `urlto`
  74
  75    &gt; I assume you have no objection to this --&#91;&#91;smcv&#93;&#93;
  76
  77 +  &gt;&gt; It&#39;s so little used that I don&#39;t really care if it&#39;s a bit ugly.
  78 +  &gt;&gt; (But I assume changes to `urlto` will follow through here anyway.)
  79 +  &gt;&gt; --&#91;&#91;Joey&#93;&#93;
  80 +
  81  * `IkiWiki::cgiurl` uses `$local_cgiurl` if passed `local_cgiurl =&gt; 1`
  82
  83    &gt; Possibly changed to making this always be local unless `cgiurl =&gt; $x`
  84 @@ -225,6 +241,8 @@ New API added by this branch:
  85    except `cgiurl` and/or `local_cgiurl`
  86
  87    &gt; I assume you have no objection to this --&#91;&#91;smcv&#93;&#93;
  88 +  &gt;
  89 +  &gt;&gt; Nod, although I don&#39;t know of a use case. --&#91;&#91;Joey&#93;&#93;
  90
  91  Bugs:
  92
  93 @@ -243,6 +261,10 @@ Bugs:
  94    &gt;&gt; would you accept a patch that makes `cgiurl` default to a local
  95    &gt;&gt; (starts-with-`/`) result? If you would, that&#39;d reduce the diff. --&#91;&#91;smcv&#93;&#93;
  96
  97 +  &gt;&gt;&gt; Yes, I absolutely think it should default to local. (Note that
  98 +  &gt;&gt;&gt; if `absolute()` were implemented as suggested above, it could also
  99 +  &gt;&gt;&gt; be used with cgiurl if necessary.) --&#91;&#91;Joey&#93;&#93;
 100 +
 101  * It occurs to me that `IkiWiki::cgiurl` could probably benefit from being
 102    exported? Perhaps also `IkiWiki::baseurl`?
 103
 104
 105 </pre>
 106 </div>
 107
 108 <!-- 5954915a4fe8a889b8217cac99fae53cbe7f1e97 -->