doc/recentchanges/change_178d6a16c2fff68edfbe6a1af5c8a9fa91db6039._change

   1 [[!meta author="""joey"""]]
   2
   3 [[!meta authorurl="""http://ikiwiki.info/ikiwiki.cgi?page=users%2Fjoey&amp;do=goto"""]]
   4
   5 [[!meta title="""change to todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both on ikiwiki"""]]
   6
   7 [[!meta permalink="http://ikiwiki.info/recentchanges/#change-178d6a16c2fff68edfbe6a1af5c8a9fa91db6039"]]
   8
   9 <div id="change-178d6a16c2fff68edfbe6a1af5c8a9fa91db6039" class="metadata">
  10 <span class="desc"><br />Changed pages:</span>
  11 <span class="pagelinks">
  12
  13 <a href="http://git.ikiwiki.info/?p=ikiwiki;a=blobdiff;f=doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn;h=4fafc2bbc249ac9e22869129f8702e0a6d54a5ba;hp=20d22b9ab837dfc3d5c9e0a787479b49fd2d6043;hb=178d6a16c2fff68edfbe6a1af5c8a9fa91db6039;hpb=a6c3d71787c528888c3f66c7ded8dd0c8f430b7e" title="diff" rel="nofollow">[[diff|wikiicons/diff.png]]</a><a href="http://ikiwiki.info/ikiwiki.cgi?page=todo%2Fwant_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both&amp;do=goto" rel="nofollow">todo/want to avoid ikiwiki using http or https in urls to allow serving both</a>
  14
  15
  16 </span>
  17 <span class="desc"><br />Changed by:</span>
  18 <span class="committer">
  19
  20 <a href="http://ikiwiki.info/ikiwiki.cgi?page=users%2Fjoey&amp;do=goto" rel="nofollow">joey</a>
  21
  22 </span>
  23 <span class="desc"><br />Commit type:</span>
  24 <span class="committype">git</span>
  25 <span class="desc"><br />Date:</span>
  26 <span class="changedate"><span class="relativedate" title="Mon, 22 Nov 2010 18:05:37 +0000">18:05:37 11/22/10</span></span>
  27 <span class="desc"><br /></span>
  28 </div>
  29
  30 <span class="revert">
  31 <a href="http://ikiwiki.info/ikiwiki.cgi?rev=178d6a16c2fff68edfbe6a1af5c8a9fa91db6039&amp;do=revert" title="revert" rel="nofollow">[[revert|wikiicons/revert.png]]</a>
  32 </span>
  33
  34 <div class="changelog">
  35
  36
  37 comments (finally)<br />
  38
  39
  40 </div>
  41
  42 <div class="diff">
  43 <pre>
  44 diff --git a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
  45 index 20d22b9..4fafc2b 100644
  46 --- a/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
  47 +++ b/doc/todo/want_to_avoid_ikiwiki_using_http_or_https_in_urls_to_allow_serving_both.mdwn
  48 @@ -181,6 +181,16 @@ New API added by this branch:
  49
  50  * `urlto(x, y, &#39;local&#39;)` uses `$local_url` instead of `$config{url}`
  51
  52 +  &gt; Yikes. I see why you wanted to keep it to 3 parameters (4 is too many,
  53 +  &gt; and po overrides it), but I dislike overloading the third parameter
  54 +  &gt; like that.
  55 +  &gt;
  56 +  &gt; There are fairly few calls to `urlto($foo, $bar)`, so why not
  57 +  &gt; make that always return the semi-local url form, and leave the third
  58 +  &gt; parameter for the cases that need a true fully-qualified url.
  59 +  &gt; The new form for local urls will typically be only a little bit longer,
  60 +  &gt; except in the unusual case where the cgiurl is elsewhere. --&#91;&#91;Joey&#93;&#93;
  61 +
  62  * `IkiWiki::baseurl` has a new second argument which works like the
  63    third argument of `urlto`
  64
  65 @@ -199,9 +209,13 @@ Bugs:
  66    `cgiurl(cgiurl =&gt; $config{cgiurl}, ...)`,
  67    although that does look a bit strange
  68
  69 +  &gt; I agree that makes sense. --&#91;&#91;Joey&#93;&#93;
  70 +
  71  * It occurs to me that `IkiWiki::cgiurl` could probably benefit from being
  72    exported? Perhaps also `IkiWiki::baseurl`?
  73
  74 +  &gt; Possibly, see &#91;&#91;firm_up_plugin_interface&#93;&#93;. --&#91;&#91;Joey&#93;&#93;
  75 +
  76  * Or, to reduce use of the unexported `baseurl` function, it might make
  77    sense to give `urlto` a special case that references the root of the wiki,
  78    with a trailing slash ready to append stuff: perhaps `urlto(&#39;/&#39;)`,
  79 @@ -210,3 +224,6 @@ Bugs:
  80          do_something(baseurl =&gt; urlto(&#39;/&#39;, undef, local)`);
  81          do_something_else(urlto(&#39;/&#39;).&#39;style.css&#39;);
  82          IkiWiki::redirect(urlto(&#39;/&#39;, undef, 1));
  83 +
  84 +  &gt; AFACIS, `baseurl` is only called in 3 places so I don&#39;t think that&#39;s
  85 +  &gt; needed. --&#91;&#91;Joey&#93;&#93;
  86
  87 </pre>
  88 </div>
  89
  90 <!-- 178d6a16c2fff68edfbe6a1af5c8a9fa91db6039 -->