]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/blob - doc/bugs/MultiMarkdown_footnote_support_seems_to_be_broken.mdwn
MultiMarkdown footnote un-inversion: done
[git.ikiwiki.info.git] / doc / bugs / MultiMarkdown_footnote_support_seems_to_be_broken.mdwn
1 Hello,
3 I have just updated an ikiwiki installation of mine from the `master` branch in 2014
4 to the current `master` (430f69034f7c9f64325ef48da3b3eaf0d685dcc5), and found out that the
5 the footnote support with MultiMarkdown is broken. After some investigation, I believe that
6 the breakage was introduced in 4db4e589e4c73f076b666a77b86743695454a3ce, with Discount support
7 for footnotes. The conditional for the footnote support in MultiMarkdown is inverted.
9 I've been running with this patch to fix it:
11     From 8c624b3cc67bf41b3987a27b15a8dee5fe1087f7 Mon Sep 17 00:00:00 2001
12     From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
13     Date: Thu, 29 Aug 2019 16:51:45 +0200
14     Subject: [PATCH] Fix inverted conditional for multimarkdown footnote support
15     
16     ---
17      IkiWiki/Plugin/mdwn.pm | 4 +---
18      1 file changed, 1 insertion(+), 3 deletions(-)
19     
20     diff --git a/IkiWiki/Plugin/mdwn.pm b/IkiWiki/Plugin/mdwn.pm
21     index eefa29a97..cff4204ef 100644
22     --- a/IkiWiki/Plugin/mdwn.pm
23     +++ b/IkiWiki/Plugin/mdwn.pm
24     @@ -77,9 +77,7 @@ sub htmlize (@) {
25                                 $markdown_sub=sub {
26                                         my %flags=( use_metadata => 0 );
27      
28     -                                   if ($config{mdwn_footnotes}) {
29     -                                           $flags{disable_footnotes}=1;
30     -                                   }
31     +                                   $flags{disable_footnotes}= not $config{mdwn_footnotes};
32      
33                                         Text::MultiMarkdown::markdown(shift, \%flags);
34                                 }
35     -- 
36     2.21.0.595.g6364b05174
38 [[!tag patch]]
39 [[done]]
41 > Applied (along with some accompanying tests) in e642784. Thanks for
42 > finding and fixing the bug.
43 > --[[schmonz]]