From f99850b5d3fc8d3c884f97c529881097342c8802 Mon Sep 17 00:00:00 2001 From: guilhem Date: Sat, 6 Jun 2015 12:51:08 -0400 Subject: [PATCH] --- ...7___should_not_be_allowed_in_image_filenames.mdwn | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 doc/bugs/Colons___8216__:__8217___should_not_be_allowed_in_image_filenames.mdwn diff --git a/doc/bugs/Colons___8216__:__8217___should_not_be_allowed_in_image_filenames.mdwn b/doc/bugs/Colons___8216__:__8217___should_not_be_allowed_in_image_filenames.mdwn new file mode 100644 index 000000000..3ecde81f8 --- /dev/null +++ b/doc/bugs/Colons___8216__:__8217___should_not_be_allowed_in_image_filenames.mdwn @@ -0,0 +1,12 @@ +`IkiWiki::Plugin::img` appends `[$pagenumber]` to the filename to deal with multipage documents such as PDFs. +However, `Image::Magick` doesn't seem to like page selection for filenames containing a colon. This is also the case for imagemagick binaries: + + $ identify 'screenshot_2015-06-06_18:37:53.png' + screenshot_2015-06-06_18:37:53.png PNG 453x122 453x122+0+0 8-bit sRGB 11.2KB 0.000u 0:00.000 + $ identify 'screenshot_2015-06-06_18:37:53.png[0]' + identify: no decode delegate for this image format `37' @ error/constitute.c/ReadImage/501. + $ mv 'screenshot_2015-06-06_18:37:53.png' 'screenshot_2015-06-06_18-37-53.png' + $ identify 'screenshot_2015-06-06_18-37-53.png[0]' + screenshot_2015-06-06_18-37-53.png[0]=>screenshot_2015-06-06_18-37-53.png PNG 453x122 453x122+0+0 8-bit sRGB 11.2KB 0.000u 0:00.000 + +This might be an imagemagick bug, but it's also possible that colons are interpreted somehow. Anyway, to render such images properly in ikiwiki I had to remove the colons. An easy fix is to remove ‘:’ from `wiki_file_chars`, but this can break existing installations. A better solution would be to make `IkiWiki::Plugin::img` croak on such image filenames (which anyway are currently not rendered, but `Image::Magick`'s error message is quite cryptic). -- 2.39.5