From 9f3f0e7418204677fc0524d99dbe5b2aebe6ce5a Mon Sep 17 00:00:00 2001
From: smcv <smcv@web>
Date: Thu, 17 Jul 2014 06:07:22 -0400
Subject: [PATCH] yes please
---
...escaling_distorts_with_small_pictures.mdwn | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/doc/bugs/image_rescaling_distorts_with_small_pictures.mdwn b/doc/bugs/image_rescaling_distorts_with_small_pictures.mdwn
index c74818a46..a8c8deebf 100644
--- a/doc/bugs/image_rescaling_distorts_with_small_pictures.mdwn
+++ b/doc/bugs/image_rescaling_distorts_with_small_pictures.mdwn
@@ -22,3 +22,23 @@ If you use the rescaling feature of the directive [[ikiwiki/directive/img/]] wit
>> the branch also enhances on how images are handled in preview, falling back
>> to data: urls if the image has not been rendered in a saved version. please
>> review. --[[chrysn]]
+
+>>> Mostly [[looks good to me|users/smcv/ready]].
+>>>
+>>> Minor things, which wouldn't stop me merging it if I could:
+>>>
+>>> * `$imgdatalink = "data:image/".$im->Get("magick").";base64,".encode_base64($blob[0]);`:
+>>> is the ImageMagick file type always valid as the second part of
+>>> a MIME type?
+>>> * In this code:
+>>>
+>>> +open (my $outhtmlfd, "<", "$outpath.html");
+>>> +local $/=undef;
+>>> +my $outhtml = <$outhtmlfd>;
+>>> +close $outhtmlfd;
+>>>
+>>> no block is closed, so the "local" is ineffective, so the `<>` operator
+>>> remains in read-entire-file mode afterwards. To avoid odd side-effects,
+>>> I would suggest using `readfile()` like `t/trail.t` does.
+>>>
+>>> --[[smcv]]
--
2.39.5