From 84a0b15eb68917829267bacac005f2bcefee914a Mon Sep 17 00:00:00 2001 From: Simon McVittie Date: Sun, 8 May 2016 15:41:35 +0100 Subject: [PATCH] Add t/img.t regression test also taken from version 3.20160506 (chrysn, joeyh, schmonz, smcv) --- debian/changelog | 2 + t/img.t | 178 ++++++++++++++++++++++++++++++++++++++++++++ t/img/redsquare.jpg | Bin 0 -> 294 bytes t/img/redsquare.png | Bin 0 -> 84 bytes t/img/twopages.pdf | Bin 0 -> 2295 bytes 5 files changed, 180 insertions(+) create mode 100755 t/img.t create mode 100644 t/img/redsquare.jpg create mode 100644 t/img/redsquare.png create mode 100644 t/img/twopages.pdf diff --git a/debian/changelog b/debian/changelog index f0e617731..6a3cb77c6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -25,6 +25,8 @@ ikiwiki (3.20120629.3) UNRELEASED; urgency=medium - Use data: URLs to embed images in page previews (chrysn) - Raise an error if the image's size cannot be determined (chrysn) - Handle filenames containing a colon correctly (smcv) + * Add t/img.t regression test also taken from version 3.20160506 + (chrysn, joeyh, schmonz, smcv) -- Simon McVittie Sun, 08 May 2016 15:33:51 +0100 diff --git a/t/img.t b/t/img.t new file mode 100755 index 000000000..5531c38d0 --- /dev/null +++ b/t/img.t @@ -0,0 +1,178 @@ +#!/usr/bin/perl +# +# unit test that creates test images (png, svg, multi-page pdf), runs ikiwiki +# on them, checks the resulting images for plausibility based on their image +# sizes, and checks if they vanish when not required in the build process any +# more +# +# if you have trouble here, be aware that there are three debian packages that +# can provide Image::Magick: perlmagick, libimage-magick-perl and +# graphicsmagick-libmagick-dev-compat +# +package IkiWiki; + +use warnings; +use strict; +use Test::More; +plan(skip_all => "Image::Magick not available") + unless eval q{use Image::Magick; 1}; + +use IkiWiki; + +my $installed = $ENV{INSTALLED_TESTS}; + +my @command; +if ($installed) { + @command = qw(ikiwiki); +} +else { + ok(! system("make -s ikiwiki.out")); + @command = qw(perl -I. ./ikiwiki.out + --underlaydir=underlays/basewiki + --set underlaydirbase=underlays + --templatedir=templates); +} + +push @command, qw(--set usedirs=0 --plugin img t/tmp/in t/tmp/out --verbose); + +my $magick = new Image::Magick; + +$magick->Read("t/img/twopages.pdf"); +my $PDFS_WORK = defined $magick->Get("width"); + +ok(! system("rm -rf t/tmp; mkdir -p t/tmp/in")); + +ok(! system("cp t/img/redsquare.png t/tmp/in/redsquare.png")); +ok(! system("cp t/img/redsquare.jpg t/tmp/in/redsquare.jpg")); +ok(! system("cp t/img/redsquare.jpg t/tmp/in/redsquare.jpeg")); +# colons in filenames are a corner case for img +ok(! system("cp t/img/redsquare.png t/tmp/in/hello:world.png")); +ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c.png")); +ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c:d.png")); +ok(! system("cp t/img/redsquare.png t/tmp/in/a:b:c:d:e:f:g:h:i:j.png")); + +writefile("bluesquare.svg", "t/tmp/in", + ''); +ok(! system("cp t/tmp/in/bluesquare.svg t/tmp/in/really-svg.png")); +ok(! system("cp t/tmp/in/bluesquare.svg t/tmp/in/really-svg.bmp")); +ok(! system("cp t/tmp/in/bluesquare.svg t/tmp/in/really-svg.pdf")); + +# using different image sizes for different pages, so the pagenumber selection can be tested easily +ok(! system("cp t/img/twopages.pdf t/tmp/in/twopages.pdf")); +ok(! system("cp t/img/twopages.pdf t/tmp/in/really-pdf.jpeg")); +ok(! system("cp t/img/twopages.pdf t/tmp/in/really-pdf.jpg")); +ok(! system("cp t/img/twopages.pdf t/tmp/in/really-pdf.png")); +ok(! system("cp t/img/twopages.pdf t/tmp/in/really-pdf.svg")); + +my $maybe_pdf_img = ""; +if ($PDFS_WORK) { + $maybe_pdf_img = <new(); + my $r = $im->Read(":$filename"); + return "no image" if $r; + my $w = $im->Get("width"); + my $h = $im->Get("height"); + return "${w}x${h}"; +} + +my $outpath = "t/tmp/out/imgconversions"; +my $outhtml = readfile("$outpath.html"); + +is(size("$outpath/10x-redsquare.png"), "10x10"); +ok(! -e "$outpath/30x-redsquare.png"); +ok($outhtml =~ /width="30" height="30".*expecting 30x30/); +ok($outhtml =~ /width="42".*expecting 42x/); +ok($outhtml =~ /height="43".*expecting x43/); +ok($outhtml =~ /width="42" height="43".*expecting 42x43/); + +SKIP: { + skip "PDF support not installed (try ghostscript)", 2 + unless $PDFS_WORK; + is(size("$outpath/12x-twopages.png"), "12x12"); + is(size("$outpath/16x-p1-twopages.png"), "16x2"); +} + +ok($outhtml =~ /width="8" height="8".*expecting 8x8/); +is(size("$outpath/x8-hello:world.png"), "8x8"); +is(size("$outpath/x4-a:b:c.png"), "4x4"); +is(size("$outpath/x6-a:b:c:d:e:f:g:h:i:j.png"), "6x6"); + +is(size("$outpath/11x-redsquare.jpg"), "11x11"); +is(size("$outpath/12x-redsquare.jpeg"), "12x12"); +like($outhtml, qr{src="(\./)?imgconversions/11x-redsquare\.jpg" width="11" height="11"}); +like($outhtml, qr{src="(\./)?imgconversions/12x-redsquare\.jpeg" width="12" height="12"}); + +# We do not misinterpret images +my $quot = qr/(?:"|")/; +like($outhtml, qr/${quot}really-svg\.png${quot} does not seem to be a valid png file/); +ok(! -e "$outpath/666x-really-svg.png"); +ok(! -e "$outpath/666x-really-svg.bmp"); +like($outhtml, qr/${quot}really-pdf\.jpeg${quot} does not seem to be a valid jpeg file/); +ok(! -e "$outpath/666x-really-pdf.jpeg"); +like($outhtml, qr/${quot}really-pdf\.jpg${quot} does not seem to be a valid jpeg file/); +ok(! -e "$outpath/666x-really-pdf.jpg"); +like($outhtml, qr/${quot}really-pdf\.png${quot} does not seem to be a valid png file/); +ok(! -e "$outpath/666x-really-pdf.png"); + +# disable support for uncommon formats and try again +ok(! system(@command, "--rebuild")); +ok(! -e "$outpath/10x-bluesquare.png"); +ok(! -e "$outpath/12x-twopages.png"); +ok(! -e "$outpath/16x-p1-twopages.png"); + +# now let's remove them again + +if (1) { # for easier testing + writefile("imgconversions.mdwn", "t/tmp/in", "nothing to see here"); + + ok(! system(@command, "--refresh")); + + ok(! -e "$outpath/10x-redsquare.png"); + ok(! -e "$outpath/10x-bluesquare.png"); + ok(! -e "$outpath/12x-twopages.png"); + ok(! -e "$outpath/16x-p1-twopages.png"); + ok(! -e "$outpath/x8-hello:world.png"); + ok(! -e "$outpath/x4-a:b:c.png"); + ok(! -e "$outpath/x6-a:b:c:d:e:f:g:h:i:j.png"); + + # cleanup + ok(! system("rm -rf t/tmp")); +} +done_testing; + +1; diff --git a/t/img/redsquare.jpg b/t/img/redsquare.jpg new file mode 100644 index 0000000000000000000000000000000000000000..565d7f33ba0147ec3e4a6a08ac043c31ab2681fd GIT binary patch literal 294 zcmb7@7Qp}j literal 0 HcmV?d00001 diff --git a/t/img/twopages.pdf b/t/img/twopages.pdf new file mode 100644 index 0000000000000000000000000000000000000000..8be9b65394d717d78aad89a728c7846b6c7c25bf GIT binary patch literal 2295 zcmd6oy>1gh5XTMW))Z7|n}|fnzTNvi6s3qwz~aj|kw7v?oNxD>1N+vwTN6VA6$KJJ z1W&*tP|{J*QNjz*Q-s;Qb2wj&0yN;py4l&?nfd=_cCFXhY0{R3*1mlG_zBsVU@?4z z2L{-&vB&2U8{J7b;_U~Br%bIOw{$W({7Dk={?+Z{C8u0Mo14hkoekyFDK8H|#;tIo zKL|4RwEf=g;UgYNWZX@d+{Y#?>?C8!Gq`_e97^8dkzo7*GOqDtv@f;C4W5paGeyRB zBJ&>4+F~*lDNiN#k1XUuqBhVeR>O{YK;(wN{RgJCBb1};z zo?|UxFB8!&msoMpM@A`Fv8EDMdg~HHl}k~301GmDVWtG3#lE&kC4A;sRTj?K+n-H_ zSQQ06ZgQ4{+hUFfWkpQ_inlW{tsCKz1%p(byqeVRPg3cEXPr!`q+1d4sL?n&I$EU| zU6f^DbW_IXoZ+9mLtgsme&s5&4Ct@Ww@*diK}H!rHBTj92fvJd^zi(JMx*heab{(< zOO3lg-mg^Z0NDlW%9G$ziKmMxq3cl~|If2jk?Rqr#?voQ*JQ0?ohpU@1a?||?4D0thRum#YytgVr;Zc*pIsG}4Oc+YV(o79-WG zBk1>{RjYfJhSp8NIxvy(dgro9s7*X#Q_pfOdWo193AwnTT9$`05$SLFi43n#Su7u8 zvqenY#D|B6Ep2E;VgjeZ=wY)6-h%Z+!ZXyIhO@C~Qpdsf3kx{6^0<|9*&K_*aFlSh z^Zv$0CGmO2V?;0w5IO!~*KsTd$GEgn+XkW352p*8{;K&AM+sW@TV?ZtlYS1+Q`>8L zpi0eVIV<);WVKkR>4ILhy>0+KSF`!{Nk1h3!ADG?b8CR+U&bbUTsX3sY6QH%VE4O#h4;Y+o A`v3p{ literal 0 HcmV?d00001 -- 2.39.5