From 6f55ff1ec8932616feccc00209543cba5f5d8b17 Mon Sep 17 00:00:00 2001 From: "http://kallesoderman.myopenid.com/" Date: Mon, 5 Aug 2013 04:19:22 -0400 Subject: [PATCH] fixed to make sense --- doc/plugins/contrib/album/discussion.mdwn | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/doc/plugins/contrib/album/discussion.mdwn b/doc/plugins/contrib/album/discussion.mdwn index 060b16dd4..dad781808 100644 --- a/doc/plugins/contrib/album/discussion.mdwn +++ b/doc/plugins/contrib/album/discussion.mdwn @@ -458,21 +458,19 @@ Thanks Lukas >> Thanks for all the work you did on the plugin! --Lukas ---- -Hi smcv, we spoke on irc the other day. Passed `show => "0"` on line 126 in album.pm to remove the limit on the thumbnails shown on the album page. As mentioned above by Jaime setting the thumbnailsize doesn't seem to catch. +Hi smcv, we spoke on irc the other day. Passed `show => "0"` on line 126 in album.pm to remove the limit on the thumbnails shown on the album page. Setting it on the album directive didn't work. As mentioned above by Jaime setting the thumbnailsize doesn't catch either. Or rather if I git push after changing the album directive the generated thumbnails (the image files) are the correct size as set in the directive. The html however uses the default thumbnailsize as hardcoded in album.pm and has broken thumbnails as it links to a file with the default size in the filename. - Or rather if I git push after changing the album directive the generated thumbnails (the image files) are the correct size as set in the directive. The html however uses the default size thumbnailsize as hardcoded in album.pm and has broken thumbnails as it links to a file with the default size in the filename. - -Issuing ikiwiki --rebuild knocks the system into another gear where the thumbnails show up correctly but this is only due to the html being the same as above (linking to hardcoded thumbnailsize) but the generated thumbnail images are now matching the hardcoded size ignoring the thumbnailsize attribute on the album directive. +Issuing `ikiwiki --rebuild` knocks the system into another gear where the thumbnails show up correctly but this is only due to the html being the same as above (linking to hardcoded thumbnailsize) but the generated thumbnail images are now matching the hardcoded size ignoring the thumbnailsize attribute on the album directive. For me this behaviour is way beyond my skills to sort out (I'm no coder). The albumplugin ikiwiki combo is very attractive to me and the plugin i soo close to working! -I've changed the behavior of the "slideshow" to show the next image when clicking the large image as downloading a full resolution image is a rare usecase in a gallery of this type imho. The large clicktarget means you are likely to unnecessarily download large files otherwise. I can't quite follow the template, album.pm flow so I can't figure out how to put a "download full resolution" link on the viewer page which would be my next step. ` link => ($nextpage or $album),` +I've changed the behavior of the "slideshow" to show the next image when clicking the large image as downloading a full resolution image is a rare use case in a gallery of this type imho. The large clicktarget means you are likely to unnecessarily download large files otherwise. I can't quite follow the template, album.pm flow so I can't figure out how to put a "download full resolution" link on the viewer page which would be my next step. To achieve the next link i added ` link => ($nextpage or $album),` around line 454 in `my $img` My wishlist for the plugin would include: - Reading exif info from the imagefile - Keeping the full resolution image files out of version control -- Being able to create new albums by tag or by specifying each image to be included. Could be a simple comma separated list in the album directive. +- Being able to create new albums by tag or bym anually picking images from other albums. Could be a simple comma separated list of viewer names, or even full urls, in the album directive. --kjs -- 2.39.5