From 65d7b028b87a32754af8f81383e679f5ca40f4b4 Mon Sep 17 00:00:00 2001 From: smcv Date: Wed, 17 Sep 2014 17:27:23 -0400 Subject: [PATCH 1/1] review --- doc/todo/sortbylastcomment_plugin.mdwn | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/doc/todo/sortbylastcomment_plugin.mdwn b/doc/todo/sortbylastcomment_plugin.mdwn index 84cf86e21..b4110c091 100644 --- a/doc/todo/sortbylastcomment_plugin.mdwn +++ b/doc/todo/sortbylastcomment_plugin.mdwn @@ -11,3 +11,24 @@ You'll find it in this repository, in the 'sortbylastcomment' branch: > Reviewed, tested: looks good to me. We need it for the [Tails forum](https://tails.boum.org/forum/). --[[intrigeri]] >> Hi, is there a chance of seeing this plugin getting included in a release at any point soon? --sajolida + +>>> (Reviewing, better late than never...) +>>> +>>> It seems really non-obvious to me that the mtime of a page is +>>> updated as a side-effect of sorting. I think it might also happen too +>>> late for it to have the desired effect: mtimes should be updated before +>>> the build phase starts, but sorting happens during the build phase. +>>> +>>> If we had a solution for [[!debbug 479371]] - copying +>>> the mtime from child pages to a parent page - then it would +>>> be enough to configure the forum threads to inherit the mtime +>>> of their comments, and then sorting by mtime would do what +>>> you wanted. The remaining problem would be to have a page pick up the +>>> most recent mtime from a somewhat configurable set of pages. If the page +>>> selection is done by pagespec, then by the time those can be matched +>>> deterministically, it's also too late to be getting the desired +>>> effect from changing mtimes... so perhaps this is a non-starter. +>>> +>>> Alternatively, perhaps just doing the sorting, and updating some +>>> displayable last-update counter that is not the mtime, would be OK? +>>> --[[smcv]] -- 2.39.5