From 6429c991f6a23a0fc31b9a5281d034964f15e452 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 8 Apr 2012 16:19:46 -0400 Subject: [PATCH 1/1] response --- .../break_up_page_template_into_subfiles.mdwn | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/doc/todo/break_up_page_template_into_subfiles.mdwn b/doc/todo/break_up_page_template_into_subfiles.mdwn index 1dd9e49cc..e9f2e310b 100644 --- a/doc/todo/break_up_page_template_into_subfiles.mdwn +++ b/doc/todo/break_up_page_template_into_subfiles.mdwn @@ -1,4 +1,9 @@ -Wishlist items such as [[Add space before slash in parent links]] would be easier to deal with if the page.tmpl template was broken up into sections and each section had a separate template file which was included in the master page.tmpl file. This would make it easier to customize parts of a page without having to fork the whole page.tmpl and then have things break when there's an update of the master page.tmpl file. +Wishlist items such as [[Add space before slash in parent links]] would be +easier to deal with if the page.tmpl template was broken up into sections +and each section had a separate template file which was included in the +master page.tmpl file. This would make it easier to customize parts of a +page without having to fork the whole page.tmpl and then have things break +when there's an update of the master page.tmpl file. Suggested sections: @@ -12,3 +17,20 @@ Suggested sections: Would this work, or would HTML::Template have problems with this? -- [[KathrynAndersen]] + +> Well, breaking it up into 6 sections would let a user modify one of them +> with only 1/6th the chance of it being broken by a new ikiwiki. +> Which seems like a win from the user's POV. However, I know that there +> are ikiwiki users who modify the `page.tmpl` but are very +> unsophisticated; needing to find the right file amoung 6 to modify +> would be a loss for these users. And some modifications would probably +> need to be coordinated amoung multiple files. +> +> For ikiwiki developers, reducing by 5/6th the number of users affected by a +> breaking change to page.tmpl is nice, but we still have to worry about +> the 1 in 6 that would be affected despite the splitting. Ikiwiki has +> enough users that any change to page.tmpl has to be carefully considered +> to avoid breaking something they may depend on, and it's been two years +> since that last needed to be done. +> +> So all in all, I don't think it's worth doing. --[[Joey]] -- 2.39.5