From 302221698c45d257856ec225302f3d13c66e18bb Mon Sep 17 00:00:00 2001 From: intrigeri Date: Fri, 6 Jul 2018 12:56:25 -0400 Subject: [PATCH] Reviewed patch. --- ...ed_content_instead_of_skipping_if_previously_translated.mdwn | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn b/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn index 591c0b231..037b5925d 100644 --- a/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn +++ b/doc/todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn @@ -85,3 +85,5 @@ 2.18.0 [[!tag patch]] + +> Thank you Chris! I've reviewed the patch (with my "original author of the po plugin" hat on) and it looks good to me. I'm not 100% sure about `alreadyfiltered` being the best name for something that's not a predicated anymore but it's good enough. Then I wore my end-user hat and confirmed that with Chris' patch applied, the reproducer we had for this bug at Tails works fine. So IMO we're good to go and I recommend to apply this patch. Thanks in advance! -- [[intrigeri]] -- 2.39.2