From 19b9328520487f8682567cc871289fb4ebee9f00 Mon Sep 17 00:00:00 2001 From: "http://smcv.pseudorandom.co.uk/" Date: Sun, 23 Feb 2014 13:38:38 -0400 Subject: [PATCH] new version of the branch; thanks to chrysn for early feedback --- doc/bugs/template_creation_error.mdwn | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/doc/bugs/template_creation_error.mdwn b/doc/bugs/template_creation_error.mdwn index 5d27c3472..2468e3c4f 100644 --- a/doc/bugs/template_creation_error.mdwn +++ b/doc/bugs/template_creation_error.mdwn @@ -110,8 +110,6 @@ Please, let me know what to do to avoid this kind of error. > > --[[smcv]] ->> [[!template id=gitbranch author="[[smcv]]" branch=smcv/definetemplate]] ->> [[!tag patch]] >> OK, here is a branch implementing what I said. It adds the `definetemplate` >> directive to [[plugins/goodstuff]] as its last commit. >> @@ -195,3 +193,14 @@ Please, let me know what to do to avoid this kind of error. >>>>> the right thing to do in this situation. >>>>> >>>>> --[[chrysn]] + +>>>>>> [[!template id=gitbranch author="[[smcv]]" branch=smcv/ready/templatebody + browse=http://git.pseudorandom.co.uk/smcv/ikiwiki.git/shortlog/refs/heads/ready/templatebody]] +>>>>>> [[!tag patch]] +>>>>>> Branch and directive renamed to `ready/templatebody` as chrysn suggested. +>>>>>> It's on-by-default now (or will be if that branch is merged). +>>>>>> Joey, any chance you could review this? +>>>>>> +>>>>>> There is one known buglet: `template_syntax.t` asserts that the entire +>>>>>> file is a valid HTML::Template, whereas it would ideally be doing the +>>>>>> same logic as IkiWiki itself. I don't think that's serious. --[[smcv]] -- 2.39.5