]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/log
git.ikiwiki.info.git
15 years agoreleasing version 2.72 2.72
Joey Hess [Sun, 28 Dec 2008 20:05:05 +0000 (15:05 -0500)]
releasing version 2.72

15 years agoinline: Run format hook first
Joey Hess [Fri, 26 Dec 2008 21:08:33 +0000 (16:08 -0500)]
inline: Run format hook first

inline has a format hook that is an optimisation hack. Until this hook
runs, the inlined content is not present on the page. This can prevent
other format hooks, that process that content, from acting on inlined
content. In bug ##509710, we discovered this happened commonly for the
embed plugin, but it could in theory happen for many other plugins (color,
cutpaste, etc) that use format to fill in special html after sanitization.

The ordering was essentially random (hash key order). That's kinda a good
thing, because hooks should be independent of other hooks and able to run
in any order. But for things like inline, that just doesn't work.

To fix the immediate problem, let's make hooks able to be registered as
running "first". There was already the ability to make them run "last".

Now, this simple first/middle/last ordering is obviously not going to work
if a lot of things need to run first, or last, since then we'll be back to
being unable to specify ordering inside those sets. But before worrying about
that too much, and considering dependency ordering, etc, observe how few
plugins use last ordering: Exactly one needs it. And, so far, exactly one
needs first ordering. So for now, KISS.

Another implementation note: I could have sorted the plugins with
first/last/middle as the primary key, and plugin name secondary, to get a
guaranteed stable order. Instead, I chose to preserve hash order. Two
opposing things pulled me toward that decision:

1. Since has order is randomish, it will ensure that no accidental
   ordering assumptions are made.
2. Assume for a minute that ordering matters a lot more than expected.
   Drastically changing the order a particular configuration uses could
   result in a lot of subtle bugs cropping up. (I hope this assumption is
   false, partly due to #1, but can't rule it out.)

15 years agocomments: Deal with users entering unqualified or partial urls.
Joey Hess [Fri, 26 Dec 2008 19:07:19 +0000 (14:07 -0500)]
comments: Deal with users entering unqualified or partial urls.

People seem to be able to expect to enter www.foo.com and get away with it.
The resulting my.wiki/www.foo.com link was not ideal.

To fix it, use URI::Heuristic to expand such things into a real url. It
even looks up hostnames in the DNS if necessary.

15 years agogooglecalendar: Add runtime deprecation warning.
Joey Hess [Thu, 25 Dec 2008 21:31:58 +0000 (16:31 -0500)]
googlecalendar: Add runtime deprecation warning.

15 years agoclose
Joey Hess [Wed, 24 Dec 2008 01:08:01 +0000 (20:08 -0500)]
close

15 years agocamelcase: Add camelcase_ignore setting.
Joey Hess [Wed, 24 Dec 2008 00:11:03 +0000 (19:11 -0500)]
camelcase: Add camelcase_ignore setting.

15 years ago(no commit message)
http://puck.openid.org/ [Tue, 23 Dec 2008 23:05:38 +0000 (18:05 -0500)]

15 years ago(no commit message)
http://puck.openid.org/ [Tue, 23 Dec 2008 22:48:05 +0000 (17:48 -0500)]

15 years agohack to avoid globlist deprecaton message false positive
Joey Hess [Tue, 23 Dec 2008 22:19:27 +0000 (17:19 -0500)]
hack to avoid globlist deprecaton message false positive

15 years agoAdd deprecation warning for GlobLists, which will stop working in 3.0.
Joey Hess [Tue, 23 Dec 2008 22:13:57 +0000 (17:13 -0500)]
Add deprecation warning for GlobLists, which will stop working in 3.0.

15 years agofix a few directives using the old syntax
Joey Hess [Tue, 23 Dec 2008 21:25:52 +0000 (16:25 -0500)]
fix a few directives using the old syntax

I'm turning on prefix_directives for the live wiki now.

15 years agoresponse
Joey Hess [Tue, 23 Dec 2008 18:27:16 +0000 (13:27 -0500)]
response

15 years agofix popcon graph link
Joey Hess [Tue, 23 Dec 2008 18:19:47 +0000 (13:19 -0500)]
fix popcon graph link

15 years agoAny other schools?
http://hendry.iki.fi/ [Tue, 23 Dec 2008 14:29:02 +0000 (09:29 -0500)]
Any other schools?

15 years agopo: make the dev timing clearer
intrigeri [Mon, 22 Dec 2008 23:24:48 +0000 (00:24 +0100)]
po: make the dev timing clearer

15 years agohttpauth_feature_parity_with_passwordauth: a bit more thinking
intrigeri [Mon, 22 Dec 2008 23:13:12 +0000 (00:13 +0100)]
httpauth_feature_parity_with_passwordauth: a bit more thinking

Signed-off-by: intrigeri <intrigeri@boum.org>
15 years ago(no commit message)
http://puck.openid.org/ [Tue, 23 Dec 2008 04:14:15 +0000 (23:14 -0500)]

15 years agomerge recentchanges comments fix
Joey Hess [Tue, 23 Dec 2008 00:04:02 +0000 (19:04 -0500)]
merge recentchanges comments fix

15 years agoMerge commit 'smcv/recentchanges'
Joey Hess [Tue, 23 Dec 2008 00:02:03 +0000 (19:02 -0500)]
Merge commit 'smcv/recentchanges'

15 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Tue, 23 Dec 2008 00:00:38 +0000 (19:00 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

15 years agoreference my recentchanges branch
http://smcv.pseudorandom.co.uk/ [Mon, 22 Dec 2008 23:09:15 +0000 (18:09 -0500)]
reference my recentchanges branch

15 years agorecentchanges_link CGI: If the linked page is internal, use its permalink
Simon McVittie [Mon, 22 Dec 2008 23:02:08 +0000 (23:02 +0000)]
recentchanges_link CGI: If the linked page is internal, use its permalink

This fixes a bug, that comments appear in recentchanges as broken links.

15 years agoupdate
Joey Hess [Mon, 22 Dec 2008 21:41:29 +0000 (16:41 -0500)]
update

15 years agoadd news item for ikiwiki 2.71
Joey Hess [Mon, 22 Dec 2008 05:03:15 +0000 (00:03 -0500)]
add news item for ikiwiki 2.71

15 years agounify pagespecs 2.71
Joey Hess [Sun, 21 Dec 2008 21:50:50 +0000 (16:50 -0500)]
unify pagespecs

15 years agofix links
Joey Hess [Sun, 21 Dec 2008 21:48:15 +0000 (16:48 -0500)]
fix links

15 years agoformatting
Joey Hess [Sun, 21 Dec 2008 21:45:59 +0000 (16:45 -0500)]
formatting

15 years agomention comments plugin
Joey Hess [Sun, 21 Dec 2008 21:44:02 +0000 (16:44 -0500)]
mention comments plugin

15 years agoavoid an uninitialized value warning
Joey Hess [Sun, 21 Dec 2008 18:46:00 +0000 (13:46 -0500)]
avoid an uninitialized value warning

15 years agoopenid branch merged
Joey Hess [Sun, 21 Dec 2008 18:14:31 +0000 (13:14 -0500)]
openid branch merged

15 years agoMerge commit 'smcv/openid'
Joey Hess [Sun, 21 Dec 2008 18:13:28 +0000 (13:13 -0500)]
Merge commit 'smcv/openid'

15 years agomore reorg
Joey Hess [Sun, 21 Dec 2008 18:08:26 +0000 (13:08 -0500)]
more reorg

15 years agoclose merged bugs
Joey Hess [Sun, 21 Dec 2008 18:00:03 +0000 (13:00 -0500)]
close merged bugs

15 years agoadd another test
Joey Hess [Sun, 21 Dec 2008 17:59:11 +0000 (12:59 -0500)]
add another test

15 years agoMerge commit 'smcv/comments'
Joey Hess [Sun, 21 Dec 2008 17:50:30 +0000 (12:50 -0500)]
Merge commit 'smcv/comments'

15 years agoMerge branch 'comments'
Joey Hess [Sun, 21 Dec 2008 17:48:14 +0000 (12:48 -0500)]
Merge branch 'comments'

15 years agoAnother fixed bug in beautify_urlpath
http://smcv.pseudorandom.co.uk/ [Sun, 21 Dec 2008 17:25:55 +0000 (12:25 -0500)]
Another fixed bug in beautify_urlpath

15 years agotrivial bug with patch
http://smcv.pseudorandom.co.uk/ [Sun, 21 Dec 2008 17:23:34 +0000 (12:23 -0500)]
trivial bug with patch

15 years agoAnother comments improvement
Simon McVittie [Sun, 21 Dec 2008 17:18:43 +0000 (17:18 +0000)]
Another comments improvement

15 years agorssitem.tmpl: include comments URL (HTML only)
Simon McVittie [Sun, 21 Dec 2008 17:16:24 +0000 (17:16 +0000)]
rssitem.tmpl: include comments URL (HTML only)

15 years agoatomitem.tmpl: include comments URLs (HTML and Atom versions)
Simon McVittie [Sun, 21 Dec 2008 17:16:12 +0000 (17:16 +0000)]
atomitem.tmpl: include comments URLs (HTML and Atom versions)

15 years agocomments: substitute commentsurl and atomcommentsurl for use in feeds
Simon McVittie [Sun, 21 Dec 2008 17:15:49 +0000 (17:15 +0000)]
comments: substitute commentsurl and atomcommentsurl for use in feeds

15 years agoMention a patch to improve OpenID display
http://smcv.pseudorandom.co.uk/ [Sun, 21 Dec 2008 16:43:43 +0000 (11:43 -0500)]
Mention a patch to improve OpenID display

15 years agoAdd a regression test for &openiduser
Simon McVittie [Sun, 21 Dec 2008 16:37:20 +0000 (16:37 +0000)]
Add a regression test for &openiduser

15 years agoopenid: in &openiduser, allow subdirectory-style providers to end with '/'
Simon McVittie [Sun, 21 Dec 2008 16:35:02 +0000 (16:35 +0000)]
openid: in &openiduser, allow subdirectory-style providers to end with '/'

This improves the display of OpenIDs like 'http://id.mayfirst.org/jamie/'
(taking an example from the IkiWiki commit log).

15 years agoopenid: in &openiduser, let domain-style providers have arbitrarily many subdomains
Simon McVittie [Sun, 21 Dec 2008 16:32:44 +0000 (16:32 +0000)]
openid: in &openiduser, let domain-style providers have arbitrarily many subdomains

This leads to better display for OpenIDs like smcv.pseudorandom.co.uk
and thm.id.fedoraproject.org (to take a couple of examples from the
IkiWiki commit history).

15 years agoRecord another couple of pending bugfixes
Simon McVittie [Sun, 21 Dec 2008 15:39:40 +0000 (15:39 +0000)]
Record another couple of pending bugfixes

15 years agobeautify_urlpath: add a regression test
Simon McVittie [Sun, 21 Dec 2008 15:24:53 +0000 (15:24 +0000)]
beautify_urlpath: add a regression test

15 years agobeautify_urlpath: if path already starts with ./, don't add another ./
Simon McVittie [Sun, 21 Dec 2008 15:24:42 +0000 (15:24 +0000)]
beautify_urlpath: if path already starts with ./, don't add another ./

15 years agobeautify_urlpath: add ./ before checking for /index.html
Simon McVittie [Sun, 21 Dec 2008 15:23:59 +0000 (15:23 +0000)]
beautify_urlpath: add ./ before checking for /index.html

This fixes a bug: when a page links to its own #comments anchor you would
get a link like "index.html#comments" rather than "./#comments".

15 years agocomments: run pagetemplate hooks
Simon McVittie [Sun, 21 Dec 2008 15:08:14 +0000 (15:08 +0000)]
comments: run pagetemplate hooks

This fixes the bug that comments are always said to be from an anonymous
user at an unknown IP address.

15 years agocomments: linkify and preprocess preview with correct 'page' param
Simon McVittie [Sun, 21 Dec 2008 15:07:36 +0000 (15:07 +0000)]
comments: linkify and preprocess preview with correct 'page' param

15 years agoMerge commit 'origin/comments' into comments-joey
Simon McVittie [Sun, 21 Dec 2008 10:17:45 +0000 (10:17 +0000)]
Merge commit 'origin/comments' into comments-joey

15 years agotodo/comments: Properly escape inline HTML
Simon McVittie [Sun, 21 Dec 2008 10:16:58 +0000 (10:16 +0000)]
todo/comments: Properly escape inline HTML

15 years agotodo/comments: reorganise by status
Simon McVittie [Sun, 21 Dec 2008 10:11:48 +0000 (10:11 +0000)]
todo/comments: reorganise by status

15 years agocomments: note fixed things and recommend merging origin/comments
Simon McVittie [Sun, 21 Dec 2008 10:08:53 +0000 (10:08 +0000)]
comments: note fixed things and recommend merging origin/comments

15 years agofix markdown
http://smcv.pseudorandom.co.uk/ [Sun, 21 Dec 2008 09:31:49 +0000 (04:31 -0500)]
fix markdown

15 years agometa: Process meta date during scan pass so that the date will always affect sorting...
Joey Hess [Sun, 21 Dec 2008 06:52:08 +0000 (01:52 -0500)]
meta: Process meta date during scan pass so that the date will always affect sorting in inlines.

15 years agoanalysis
Joey Hess [Sun, 21 Dec 2008 06:41:00 +0000 (01:41 -0500)]
analysis

15 years agocomment layout change
Joey Hess [Sun, 21 Dec 2008 06:04:19 +0000 (01:04 -0500)]
comment layout change

I saw a layout similar to this on blogger, and I sorta like it

The dash avoids parens sitting next to each other in some cases.

15 years agoMerge branch 'master' into comments
Joey Hess [Sun, 21 Dec 2008 06:04:03 +0000 (01:04 -0500)]
Merge branch 'master' into comments

15 years agoResponse; added shell code and html formating to reproduction steps
http://dtrt.org/ [Sun, 21 Dec 2008 03:28:20 +0000 (22:28 -0500)]
Response; added shell code and html formating to reproduction steps

15 years agoavoid storing transient state in pagestate
Joey Hess [Sun, 21 Dec 2008 01:55:38 +0000 (20:55 -0500)]
avoid storing transient state in pagestate

None of the comment state needs to be stored through the a later run of
ikiwiki, so move it all from pagestate to a more transient storage.

This is assuming that we'll never want to add pagespecs to search against
the comment state. Pagespecs like author() are why the meta plugin does
store its meta data in pagestate -- the data can be needed later to match
against.

15 years agoresponse
Joey Hess [Sun, 21 Dec 2008 01:27:42 +0000 (20:27 -0500)]
response

15 years agoSort paramater not a problem; Revised steps to reprodce
http://dtrt.org/ [Sun, 21 Dec 2008 00:36:15 +0000 (19:36 -0500)]
Sort paramater not a problem; Revised steps to reprodce

15 years agoalternate idea
Joey Hess [Sat, 20 Dec 2008 23:51:09 +0000 (18:51 -0500)]
alternate idea

15 years agoremove signin icons, use title
Joey Hess [Sat, 20 Dec 2008 23:46:56 +0000 (18:46 -0500)]
remove signin icons, use title

15 years agotweak author display
Joey Hess [Sat, 20 Dec 2008 23:36:16 +0000 (18:36 -0500)]
tweak author display

Put the icon after the name, mostly because it scans better on
non-graphical browsers where the alt text is displayed. And because the
name is really the more important part.

15 years agomy try at improving comment styling
Joey Hess [Sat, 20 Dec 2008 23:30:14 +0000 (18:30 -0500)]
my try at improving comment styling

Makes it look more like a blog, but not enough to be confusing, and with
nothing as large as in a blog. Removal of the vertical line under the
subject imho makes it easier to scan through comments as each box is a new
one. Bolding the subject seems to make it stand out enough, especially as
its a link now. (Also considered increasing its font size to 110%.)

15 years agonote new bug
Joey Hess [Sat, 20 Dec 2008 23:18:19 +0000 (18:18 -0500)]
note new bug

15 years agoresponse
Joey Hess [Sat, 20 Dec 2008 23:14:49 +0000 (18:14 -0500)]
response

15 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Sat, 20 Dec 2008 23:07:45 +0000 (18:07 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

15 years agoWorkaround and possible cause
http://dtrt.org/ [Sat, 20 Dec 2008 23:06:21 +0000 (18:06 -0500)]
Workaround and possible cause

15 years agoMerge commit 'smcv/comments'
Joey Hess [Sat, 20 Dec 2008 22:58:56 +0000 (17:58 -0500)]
Merge commit 'smcv/comments'

15 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Sat, 20 Dec 2008 22:58:01 +0000 (17:58 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

15 years ago(no commit message)
http://smcv.pseudorandom.co.uk/ [Sat, 20 Dec 2008 18:03:44 +0000 (13:03 -0500)]

15 years agocomment.tmpl: make anon/OpenID/signed-in icons independent of smileys
Simon McVittie [Sat, 20 Dec 2008 17:39:55 +0000 (17:39 +0000)]
comment.tmpl: make anon/OpenID/signed-in icons independent of smileys

15 years agocomments_display: display (?) for anon users, {x} for OpenIDs and {*} for local logins
Simon McVittie [Thu, 18 Dec 2008 20:28:41 +0000 (20:28 +0000)]
comments_display: display (?) for anon users, {x} for OpenIDs and {*} for local logins

This is a mockup of Joey's idea; to do it properly, the icons should
move to the basewiki or to a comments underlay, and {x} should be
replaced with an OpenID logo (if one with clear licensing even exists).

15 years agocomments: Rename COMMENTURL to ADDCOMMENTURL to avoid confusion with COMMENTAUTHORURL
Simon McVittie [Thu, 18 Dec 2008 20:01:08 +0000 (20:01 +0000)]
comments: Rename COMMENTURL to ADDCOMMENTURL to avoid confusion with COMMENTAUTHORURL

Also refactor page.tmpl to use if/else rather than unless/if.

15 years agocomments: pass COMMENTOPENID to templates
Simon McVittie [Thu, 18 Dec 2008 19:57:25 +0000 (19:57 +0000)]
comments: pass COMMENTOPENID to templates

15 years agocomments: remove linkuser(), it's been integrated into preprocess() now
Simon McVittie [Thu, 18 Dec 2008 19:57:03 +0000 (19:57 +0000)]
comments: remove linkuser(), it's been integrated into preprocess() now

15 years ago_comment directive: if the user looks like an OpenID, store that
Simon McVittie [Thu, 18 Dec 2008 19:56:36 +0000 (19:56 +0000)]
_comment directive: if the user looks like an OpenID, store that

15 years agohaskell
Joey Hess [Sat, 20 Dec 2008 16:30:48 +0000 (11:30 -0500)]
haskell

15 years agonote
Joey Hess [Sat, 20 Dec 2008 16:04:45 +0000 (11:04 -0500)]
note

15 years agominor edits
brush [Sat, 20 Dec 2008 10:58:00 +0000 (05:58 -0500)]
minor edits

15 years agoadded details on cgi wrapper creation
brush [Sat, 20 Dec 2008 10:56:04 +0000 (05:56 -0500)]
added details on cgi wrapper creation

15 years agoinitial page
http://weakish.int.eu.org/ [Sat, 20 Dec 2008 09:20:58 +0000 (04:20 -0500)]
initial page

15 years agovimperator can do this, too.
http://weakish.int.eu.org/ [Sat, 20 Dec 2008 09:18:56 +0000 (04:18 -0500)]
vimperator can do this, too.

15 years agoavoid uninitialized value
Joey Hess [Fri, 19 Dec 2008 22:57:09 +0000 (17:57 -0500)]
avoid uninitialized value

This can happen when a new field,
such as the new lasttry, is added.

15 years agofix comment permalink to always point to comment parent page
Joey Hess [Fri, 19 Dec 2008 22:33:40 +0000 (17:33 -0500)]
fix comment permalink to always point to comment parent page

15 years agoupdate
Joey Hess [Fri, 19 Dec 2008 22:26:41 +0000 (17:26 -0500)]
update

15 years agotypos
Joey Hess [Fri, 19 Dec 2008 22:07:54 +0000 (17:07 -0500)]
typos

15 years agosimplify and compact the comment edit form
Joey Hess [Fri, 19 Dec 2008 19:29:54 +0000 (14:29 -0500)]
simplify and compact the comment edit form

Mostly to make it more visually similar to the page edit form.

I'm a bit uncertian about the placement of the page type selector,
and about removing the "Page type". May rethink that.

15 years agoremove 'signed in as foo'
Joey Hess [Fri, 19 Dec 2008 19:21:48 +0000 (14:21 -0500)]
remove 'signed in as foo'

I think users should know who they're signed in as; the edit pages don't
say so there's no reason to here. Also, the user id was not displayed
pretty.

15 years agoadd link from comment subject to its permalink
Joey Hess [Fri, 19 Dec 2008 19:20:07 +0000 (14:20 -0500)]
add link from comment subject to its permalink

15 years agofiddle with comment css classes
Joey Hess [Fri, 19 Dec 2008 19:14:20 +0000 (14:14 -0500)]
fiddle with comment css classes

15 years agoremove cruft
Joey Hess [Fri, 19 Dec 2008 19:09:39 +0000 (14:09 -0500)]
remove cruft

wtf does it do? absolutely nothing

15 years agorename comments_form to editcomment
Joey Hess [Fri, 19 Dec 2008 19:07:22 +0000 (14:07 -0500)]
rename comments_form to editcomment

15 years agorename comments_display to comment
Joey Hess [Fri, 19 Dec 2008 19:03:26 +0000 (14:03 -0500)]
rename comments_display to comment

15 years agoreplace discussion links on pages with comments link
Joey Hess [Fri, 19 Dec 2008 18:55:41 +0000 (13:55 -0500)]
replace discussion links on pages with comments link

The thinking here is that having both a Discussion page and comments for
the same page is redundant, and certianly not what you want if you enable
comments for a page. At first I considered making configurable via pagespec
what pages got discussion links. But that would mean testing a new pagespec
for every page, and a redundant config setting to keep in sync. So intead,
take a lead from my previous change to make inlined pages have a comments
link, and change the discussion link at the top of regular pages to link to
their comments.

(Implementation is a bit optimised to avoid redundant pagespec checking.)