]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/log
git.ikiwiki.info.git
15 years agoremove 'signed in as foo'
Joey Hess [Fri, 19 Dec 2008 19:21:48 +0000 (14:21 -0500)]
remove 'signed in as foo'

I think users should know who they're signed in as; the edit pages don't
say so there's no reason to here. Also, the user id was not displayed
pretty.

15 years agoadd link from comment subject to its permalink
Joey Hess [Fri, 19 Dec 2008 19:20:07 +0000 (14:20 -0500)]
add link from comment subject to its permalink

15 years agofiddle with comment css classes
Joey Hess [Fri, 19 Dec 2008 19:14:20 +0000 (14:14 -0500)]
fiddle with comment css classes

15 years agoremove cruft
Joey Hess [Fri, 19 Dec 2008 19:09:39 +0000 (14:09 -0500)]
remove cruft

wtf does it do? absolutely nothing

15 years agorename comments_form to editcomment
Joey Hess [Fri, 19 Dec 2008 19:07:22 +0000 (14:07 -0500)]
rename comments_form to editcomment

15 years agorename comments_display to comment
Joey Hess [Fri, 19 Dec 2008 19:03:26 +0000 (14:03 -0500)]
rename comments_display to comment

15 years agoreplace discussion links on pages with comments link
Joey Hess [Fri, 19 Dec 2008 18:55:41 +0000 (13:55 -0500)]
replace discussion links on pages with comments link

The thinking here is that having both a Discussion page and comments for
the same page is redundant, and certianly not what you want if you enable
comments for a page. At first I considered making configurable via pagespec
what pages got discussion links. But that would mean testing a new pagespec
for every page, and a redundant config setting to keep in sync. So intead,
take a lead from my previous change to make inlined pages have a comments
link, and change the discussion link at the top of regular pages to link to
their comments.

(Implementation is a bit optimised to avoid redundant pagespec checking.)

15 years agoupdated spanish translation
Víctor Moral [Fri, 19 Dec 2008 07:32:01 +0000 (08:32 +0100)]
updated spanish translation

15 years agojump to comment after posting
Joey Hess [Fri, 19 Dec 2008 01:58:16 +0000 (20:58 -0500)]
jump to comment after posting

Jumping to the just posted comment was the imputus, but I killed a number
of birds here.

Added a INLINEPAGE template variable, which can be used to add anchors to
any inline template.

To keep that sufficiently general, it is the full page name, so the
comment anchors and links changed form.

Got rid of the FIXMEd hardcoded html anchor div.

More importantly, the anchor is now to the very top of the comment, not the
text below. So you can see the title, and how it attributes you.

Avoid changing the permalink of pages that are not really comments, but
happen to contain the _comment directive. I think that behavior was a bug,
though not a likely one to occur since _comment should only really be used
on comment pages.

15 years agodocument how to make a global comments feed
Joey Hess [Fri, 19 Dec 2008 01:20:42 +0000 (20:20 -0500)]
document how to make a global comments feed

15 years agoresponses
Joey Hess [Fri, 19 Dec 2008 01:10:42 +0000 (20:10 -0500)]
responses

15 years agoMerge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Thu, 18 Dec 2008 23:00:03 +0000 (18:00 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info

15 years agoUpdate todo/comments with today's fixes, and thoughts about the remaining items
smcv@ [Thu, 18 Dec 2008 21:08:33 +0000 (21:08 +0000)]
Update todo/comments with today's fixes, and thoughts about the remaining items

15 years agoclarify
Joey Hess [Thu, 18 Dec 2008 19:49:24 +0000 (14:49 -0500)]
clarify

15 years ago(no commit message)
justin [Thu, 18 Dec 2008 19:20:59 +0000 (14:20 -0500)]

15 years agopagespec thoughts
Joey Hess [Thu, 18 Dec 2008 17:53:47 +0000 (12:53 -0500)]
pagespec thoughts

15 years agonote about comments feed
Joey Hess [Thu, 18 Dec 2008 17:32:23 +0000 (12:32 -0500)]
note about comments feed

15 years agoaggregate: If a feed fails to be downloaded, try again immediatly next time aggregati...
Joey Hess [Thu, 18 Dec 2008 02:27:28 +0000 (21:27 -0500)]
aggregate: If a feed fails to be downloaded, try again immediatly next time aggregation is run, even if the usual time has not passed. Closes: #508622 (Michael Gold)

15 years agoclose
Joey Hess [Thu, 18 Dec 2008 02:17:42 +0000 (21:17 -0500)]
close

15 years agodeletion
Joey Hess [Thu, 18 Dec 2008 01:40:46 +0000 (20:40 -0500)]
deletion

15 years agojump to comments anchor after post
Joey Hess [Thu, 18 Dec 2008 01:29:55 +0000 (20:29 -0500)]
jump to comments anchor after post

Not ideal, it would be nicer to jump to the actual comment posted, but no
anchor is available.

15 years agotypo
Joey Hess [Thu, 18 Dec 2008 01:22:42 +0000 (20:22 -0500)]
typo

15 years agofix
Joey Hess [Thu, 18 Dec 2008 01:19:12 +0000 (20:19 -0500)]
fix

15 years agosimplify pagespec
Joey Hess [Thu, 18 Dec 2008 01:10:22 +0000 (20:10 -0500)]
simplify pagespec

15 years agotwo comments ui suggestions
Joey Hess [Thu, 18 Dec 2008 00:47:54 +0000 (19:47 -0500)]
two comments ui suggestions

15 years agoadd Comments link when displaying a page inline
Joey Hess [Thu, 18 Dec 2008 00:38:02 +0000 (19:38 -0500)]
add Comments link when displaying a page inline

This link will supplant the usual Discussion link for pages
that have comments enabled.

15 years agofix test when comments_closed_pagespec is empty
Joey Hess [Thu, 18 Dec 2008 00:06:29 +0000 (19:06 -0500)]
fix test when comments_closed_pagespec is empty

15 years agodon't rely on $@
Joey Hess [Wed, 17 Dec 2008 23:56:32 +0000 (18:56 -0500)]
don't rely on $@

A malformed pagespec will cause $@ to be set when translated, but if
it is used a second time, the memoization will defeat that check. Better to
check for the result not being defined.

15 years agochange around comments pagespecs
Joey Hess [Wed, 17 Dec 2008 23:50:04 +0000 (18:50 -0500)]
change around comments pagespecs

I think it is clearer to have one pagespec that controls all pages with
comments, and a separate pagespec that can be used to close new comments on
a subset of those pages.

15 years agofix default values for config settings
Joey Hess [Wed, 17 Dec 2008 22:05:49 +0000 (17:05 -0500)]
fix default values for config settings

defaults cannot be set in getsetup, do it in checkconfig to avoid
uninitialized value warnings.

15 years agoclarification
Joey Hess [Wed, 17 Dec 2008 20:29:22 +0000 (15:29 -0500)]
clarification

15 years agoCoding style change: Remove explcit vim folding markers.
Joey Hess [Wed, 17 Dec 2008 20:22:16 +0000 (15:22 -0500)]
Coding style change: Remove explcit vim folding markers.

15 years agochecksessionexpiry: rework
Joey Hess [Wed, 17 Dec 2008 19:26:08 +0000 (14:26 -0500)]
checksessionexpiry: rework

This function as factored out was a bit confusing, I think this makes more
sense.

15 years agomore comments doc updates
Joey Hess [Wed, 17 Dec 2008 19:15:52 +0000 (14:15 -0500)]
more comments doc updates

Moved todo items to a todo page, mark the old todo item about comments as
done, etc.

15 years agoMerge branch 'master' into comments
Joey Hess [Wed, 17 Dec 2008 19:06:57 +0000 (14:06 -0500)]
Merge branch 'master' into comments

15 years agomonotone: When getting the log, tell monotone how many entries we want, rather than...
Joey Hess [Wed, 17 Dec 2008 18:59:12 +0000 (13:59 -0500)]
monotone: When getting the log, tell monotone how many entries we want, rather than closing the pipe, which it dislikes. (thm)

15 years agorename: Fix double-escaping of page name in edit box.
Joey Hess [Wed, 17 Dec 2008 18:56:10 +0000 (13:56 -0500)]
rename: Fix double-escaping of page name in edit box.

titlepage normally escapes, but so does formbuilder.

15 years agorename bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38_...
http://thm.id.fedoraproject.org/ [Wed, 17 Dec 2008 10:54:16 +0000 (05:54 -0500)]
rename bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn to bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34_____40__patch__41__.mdwn

15 years agorename bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34__.mdwn to...
http://thm.id.fedoraproject.org/ [Wed, 17 Dec 2008 10:52:10 +0000 (05:52 -0500)]
rename bugs/bugfix_for:___34__mtn:_operation_canceled:_Broken_pipe__34__.mdwn to bugs/bugfix_for:___38____35__34__59__mtn:_operation_canceled:_Broken_pipe__38____35__34__59_____40__patch__41__.mdwn

15 years ago(no commit message)
http://thm.id.fedoraproject.org/ [Tue, 16 Dec 2008 11:56:19 +0000 (06:56 -0500)]

15 years ago(no commit message)
http://thm.id.fedoraproject.org/ [Tue, 16 Dec 2008 11:54:55 +0000 (06:54 -0500)]

15 years agoadd a meta title
Jon Dowland [Mon, 15 Dec 2008 16:09:26 +0000 (16:09 +0000)]
add a meta title

15 years agonot putting cgi in destdir
Jon Dowland [Mon, 15 Dec 2008 15:39:07 +0000 (15:39 +0000)]
not putting cgi in destdir

15 years agoelide unnecessary variables
Joey Hess [Fri, 12 Dec 2008 20:38:23 +0000 (15:38 -0500)]
elide unnecessary variables

15 years agoremove fixme
Joey Hess [Fri, 12 Dec 2008 20:25:12 +0000 (15:25 -0500)]
remove fixme

sessioncgi hooks are always called with the wiki locked

15 years agofix redefinition of $author
Joey Hess [Fri, 12 Dec 2008 20:22:43 +0000 (15:22 -0500)]
fix redefinition of $author

15 years agomove related code together
Joey Hess [Fri, 12 Dec 2008 20:19:01 +0000 (15:19 -0500)]
move related code together

15 years agowhitespace
Joey Hess [Fri, 12 Dec 2008 20:13:07 +0000 (15:13 -0500)]
whitespace

15 years agodon't explicitly use inline
Joey Hess [Fri, 12 Dec 2008 20:10:17 +0000 (15:10 -0500)]
don't explicitly use inline

loadplugin("inline") should take care of that

15 years agoavoid unnecessary variable
Joey Hess [Fri, 12 Dec 2008 20:08:06 +0000 (15:08 -0500)]
avoid unnecessary variable

15 years agoget rid of the [postcomment] hack
Joey Hess [Fri, 12 Dec 2008 20:05:26 +0000 (15:05 -0500)]
get rid of the [postcomment] hack

I think that using a flag variable is sorta cleaner.

(This is untested.)

15 years agoimprove documentation of postcomment
Joey Hess [Fri, 12 Dec 2008 20:02:40 +0000 (15:02 -0500)]
improve documentation of postcomment

15 years agomove getsetup to usual place
Joey Hess [Fri, 12 Dec 2008 19:59:23 +0000 (14:59 -0500)]
move getsetup to usual place

15 years agofirst pass through comments documentation
Joey Hess [Fri, 12 Dec 2008 19:52:05 +0000 (14:52 -0500)]
first pass through comments documentation

Moved documentation out of contrib.

Mostly tweaked some wording. Moved documentation of various bits to other
pages (pagespec, etc), and linked to those.

Documented the new templates in wikitemplates.

Small quantities of documentation were removed. Particularly the list of
template variables, which I think is fairly obvious when editing the
template.

15 years agoupdate changelog
Joey Hess [Fri, 12 Dec 2008 19:29:42 +0000 (14:29 -0500)]
update changelog

15 years agoupdate copyright
Joey Hess [Fri, 12 Dec 2008 19:27:56 +0000 (14:27 -0500)]
update copyright

15 years agoMerge branch 'master' into comments
Joey Hess [Fri, 12 Dec 2008 19:24:35 +0000 (14:24 -0500)]
Merge branch 'master' into comments

15 years agoadd log entry
Joey Hess [Fri, 12 Dec 2008 19:23:33 +0000 (14:23 -0500)]
add log entry

15 years agohtmlbalance: don't compact whitespace, and set misc other options
Simon McVittie [Tue, 18 Nov 2008 11:25:13 +0000 (11:25 +0000)]
htmlbalance: don't compact whitespace, and set misc other options

Not compacting whitespace is the most important one: now that we run
sanitize hooks on individual posted comments in the comments plugin,
whitespace that is significant to Markdown (but not HTML) is lost.
(cherry picked from commit cb5aaa3cee8b35d6fc6e88a7449a9477a6587c7a)

15 years agoMerge branch 'master' into comments
Joey Hess [Fri, 12 Dec 2008 19:21:08 +0000 (14:21 -0500)]
Merge branch 'master' into comments

15 years agometa: Pass info to htmlscrubber so htmlscrubber_skip can take effect.
Joey Hess [Fri, 12 Dec 2008 19:06:45 +0000 (14:06 -0500)]
meta: Pass info to htmlscrubber so htmlscrubber_skip can take effect.

15 years agoAnother TODO item
http://smcv.pseudorandom.co.uk/ [Fri, 12 Dec 2008 11:34:51 +0000 (06:34 -0500)]
Another TODO item

15 years agoupdate with some more code improvements
http://smcv.pseudorandom.co.uk/ [Fri, 12 Dec 2008 11:29:02 +0000 (06:29 -0500)]
update with some more code improvements

15 years agocomments: Store dates in GMT and in ISO-8601
Simon McVittie [Fri, 12 Dec 2008 11:02:41 +0000 (11:02 +0000)]
comments: Store dates in GMT and in ISO-8601

The [[!_comment]] directive is a serialization format, not something for
presentation to users, so we should use the least ambiguous possible
representation.

15 years ago(no commit message)
http://john.choffee.co.uk/ [Fri, 12 Dec 2008 10:22:53 +0000 (05:22 -0500)]

15 years agoadding setup note
justin [Fri, 12 Dec 2008 05:40:00 +0000 (00:40 -0500)]
adding setup note

15 years agoFix too much quoting.
tschwinge [Fri, 12 Dec 2008 00:38:53 +0000 (19:38 -0500)]
Fix too much quoting.

15 years agoFix cut'n'past-o.
tschwinge [Fri, 12 Dec 2008 00:36:36 +0000 (19:36 -0500)]
Fix cut'n'past-o.

15 years agosimplifiy logic
Joey Hess [Thu, 11 Dec 2008 22:31:57 +0000 (17:31 -0500)]
simplifiy logic

15 years agocomments: Change internal-use-only directive from [[!comment]] to [[!_comment]]
Simon McVittie [Thu, 11 Dec 2008 21:23:55 +0000 (21:23 +0000)]
comments: Change internal-use-only directive from [[!comment]] to [[!_comment]]

15 years agocomments: Use new feedfile, emptyfeeds options to inline
Simon McVittie [Thu, 11 Dec 2008 21:19:50 +0000 (21:19 +0000)]
comments: Use new feedfile, emptyfeeds options to inline

15 years agocomments: don't interpolate IP into anonymous user's "name"
Simon McVittie [Thu, 11 Dec 2008 02:29:11 +0000 (02:29 +0000)]
comments: don't interpolate IP into anonymous user's "name"

If an admin wants the IP in the comment display template they can still
get it (the default template shows it).

15 years agocomments_display.tmpl: use less nice formatting to avoid whitespace in output
Simon McVittie [Thu, 11 Dec 2008 02:28:05 +0000 (02:28 +0000)]
comments_display.tmpl: use less nice formatting to avoid whitespace in output

15 years agocomments_display.tmpl: preferentially use confirmed username, but fall back to claime...
Simon McVittie [Thu, 11 Dec 2008 02:24:27 +0000 (02:24 +0000)]
comments_display.tmpl: preferentially use confirmed username, but fall back to claimed author if unauthenticated

This still isn't quite right (it displays the IP address twice if the user
doesn't specify a name).

15 years agocomments: fix invocation of possibly_foolish_untaint
Simon McVittie [Thu, 11 Dec 2008 02:22:20 +0000 (02:22 +0000)]
comments: fix invocation of possibly_foolish_untaint

15 years agocomments_form.tmpl: show labels for name, website
Simon McVittie [Thu, 11 Dec 2008 02:22:04 +0000 (02:22 +0000)]
comments_form.tmpl: show labels for name, website

15 years agocomments: avoid warning if there's no subject
Simon McVittie [Thu, 11 Dec 2008 02:03:07 +0000 (02:03 +0000)]
comments: avoid warning if there's no subject

15 years agocomments: Optionally allow anonymous commenters to set their name/URL.
Simon McVittie [Thu, 11 Dec 2008 01:33:43 +0000 (01:33 +0000)]
comments: Optionally allow anonymous commenters to set their name/URL.

Also provide a way for the comment template to pick up the verified
username/IP.

15 years agocomments: Remove some dead code
Simon McVittie [Thu, 11 Dec 2008 01:24:01 +0000 (01:24 +0000)]
comments: Remove some dead code

15 years agocomments: rename main field to "editcontent" consistent with editpage
Simon McVittie [Thu, 11 Dec 2008 00:22:34 +0000 (00:22 +0000)]
comments: rename main field to "editcontent" consistent with editpage

This has the side-effect that Ikiwiki's default style.css gives the text
box 100% width.

15 years agocomments: instead of hard-coding mdwn, allow any supported page format
Simon McVittie [Thu, 11 Dec 2008 00:19:39 +0000 (00:19 +0000)]
comments: instead of hard-coding mdwn, allow any supported page format

15 years agocomments: Save comments as a file with one big [[!comment]] directive.
Simon McVittie [Wed, 10 Dec 2008 23:53:04 +0000 (23:53 +0000)]
comments: Save comments as a file with one big [[!comment]] directive.

This delays all comment formatting until the last possible time, allows
us to set metadata without worrying that commenters may be able to evade
it, and means that changes to how a comment is saved can be handled
gracefully. It also gives us somewhere to put the commenter's username
or IP address for later reference.

15 years agoRemove dead code for preprocessing [[!comments]]
Simon McVittie [Wed, 10 Dec 2008 22:18:26 +0000 (22:18 +0000)]
Remove dead code for preprocessing [[!comments]]

15 years agocomments: Duplicate logic and CGI hook from recentchanges to link user pages correctly
Simon McVittie [Sun, 23 Nov 2008 18:31:11 +0000 (18:31 +0000)]
comments: Duplicate logic and CGI hook from recentchanges to link user pages correctly

15 years agoQualify name of formattime() correctly
Simon McVittie [Sun, 23 Nov 2008 17:53:33 +0000 (17:53 +0000)]
Qualify name of formattime() correctly

15 years agoDelay checking for session expiry til we actually post a comment
Simon McVittie [Sun, 23 Nov 2008 17:52:30 +0000 (17:52 +0000)]
Delay checking for session expiry til we actually post a comment

15 years agocomments: record the time at which each comment was posted
Simon McVittie [Sun, 23 Nov 2008 17:43:06 +0000 (17:43 +0000)]
comments: record the time at which each comment was posted

15 years agocomments: Use a checkconfig hook to get the default value of comments_pagename
Simon McVittie [Sun, 23 Nov 2008 17:42:50 +0000 (17:42 +0000)]
comments: Use a checkconfig hook to get the default value of comments_pagename

15 years agoRemove comments_embed.tmpl (no longer needed)
Simon McVittie [Sun, 23 Nov 2008 17:11:30 +0000 (17:11 +0000)]
Remove comments_embed.tmpl (no longer needed)

15 years agocomments: render comments/commenturl in page.tmpl
Simon McVittie [Sun, 23 Nov 2008 17:11:14 +0000 (17:11 +0000)]
comments: render comments/commenturl in page.tmpl

15 years agocomments: use global config to decide whether commenting is allowed, and for name...
Simon McVittie [Sun, 23 Nov 2008 17:10:44 +0000 (17:10 +0000)]
comments: use global config to decide whether commenting is allowed, and for name of page

Also:
* decide comment page name sooner
* set permalink on it

15 years agocomments: use global configuration for allow_directives, commit, and pagename
Simon McVittie [Sun, 23 Nov 2008 17:07:58 +0000 (17:07 +0000)]
comments: use global configuration for allow_directives, commit, and pagename

15 years agocomments: Add some global configuration
Simon McVittie [Sun, 23 Nov 2008 12:11:18 +0000 (12:11 +0000)]
comments: Add some global configuration

15 years agocomments: make preprocess a no-op
Simon McVittie [Sun, 23 Nov 2008 17:07:28 +0000 (17:07 +0000)]
comments: make preprocess a no-op

15 years agopage.tmpl: optionally include "add comment" link
Simon McVittie [Sun, 23 Nov 2008 17:07:07 +0000 (17:07 +0000)]
page.tmpl: optionally include "add comment" link

15 years agocomments_comment.tmpl: allow permalink, anchor to be passed in
Simon McVittie [Sun, 23 Nov 2008 17:06:40 +0000 (17:06 +0000)]
comments_comment.tmpl: allow permalink, anchor to be passed in

15 years agocomments: document what linkuser does
Simon McVittie [Sun, 23 Nov 2008 12:05:24 +0000 (12:05 +0000)]
comments: document what linkuser does

15 years agocomments: add a stub pagetemplate hook to show the comments
Simon McVittie [Sun, 23 Nov 2008 12:04:00 +0000 (12:04 +0000)]
comments: add a stub pagetemplate hook to show the comments

15 years agocomments: Use HTML entities to escape directives
Simon McVittie [Sun, 23 Nov 2008 12:03:05 +0000 (12:03 +0000)]
comments: Use HTML entities to escape directives

15 years agoEmbed comments into comments_embed.tmpl rather than concatenating in perl
Simon McVittie [Sun, 23 Nov 2008 12:02:39 +0000 (12:02 +0000)]
Embed comments into comments_embed.tmpl rather than concatenating in perl