Joey Hess [Fri, 26 Sep 2014 22:55:09 +0000 (18:55 -0400)]
Fix crash that can occur when only_committed_changes is set and a file is deleted from the underlay.
srcfile_stat got called on a file from the underlay that no longer existed.
I am not 100% sure of the circumstances of that; I was able to reproduce
the bug but neglected to snapshot the tree, and then accidentially
got it to stop crashing. I know that a transient tag page got deleted using
the web interface to trigger the crash.
It seems that process_changed_files must have returned the file, despite it
being deleted. And since the file was not checked into git, it seems it
must have not been included in @IkiWiki::underlayfiles, which would have
caused process_changed_files to not return it.
I do not know why a transient tag page would not be in
@IkiWiki::underlayfiles. There is a bug here that I don't understand.
This is just a workaround -- run srcfile_stat such that it won't crash,
and if it is unable to stat a file, find_changed knows it's not changed,
so it's ok to skip it.
Also made find_new_files run srcfile_stat such that it won't crash, just
because I was there.
http://abhidg.pip.verisignlabs.com/ [Wed, 24 Sep 2014 16:58:48 +0000 (12:58 -0400)]
smcv [Wed, 24 Sep 2014 13:52:37 +0000 (09:52 -0400)]
https://id.koumbit.net/anarcat [Wed, 24 Sep 2014 13:45:10 +0000 (09:45 -0400)]
openmedi [Wed, 24 Sep 2014 13:19:58 +0000 (09:19 -0400)]
Added a comment
smcv [Wed, 24 Sep 2014 07:27:39 +0000 (03:27 -0400)]
Added a comment
openmedi [Wed, 24 Sep 2014 01:47:25 +0000 (21:47 -0400)]
smcv [Tue, 23 Sep 2014 08:13:16 +0000 (04:13 -0400)]
%W is not as weird as it looks at first glance
smcv [Tue, 23 Sep 2014 07:55:26 +0000 (03:55 -0400)]
Added a comment
smcv [Tue, 23 Sep 2014 07:54:53 +0000 (03:54 -0400)]
fix destsources documentation, and mention how attachments appear
http://anastigmatix.net/ [Tue, 23 Sep 2014 05:25:14 +0000 (01:25 -0400)]
possible documentation error for %destsources in plugins/write
smcv [Mon, 22 Sep 2014 20:15:10 +0000 (16:15 -0400)]
indeed
what I think was meant by "deprecated"
smcv [Mon, 22 Sep 2014 07:29:40 +0000 (03:29 -0400)]
respond
http://anastigmatix.net/ [Sun, 21 Sep 2014 22:44:36 +0000 (18:44 -0400)]
q about deprecation of CGI.pm
http://anastigmatix.net/ [Sun, 21 Sep 2014 22:31:17 +0000 (18:31 -0400)]
"PERL5LIB in ENV doesn't help anymore" isn't so anymore (or, if you prefer, it helps again)
http://anastigmatix.net/ [Sun, 21 Sep 2014 21:37:11 +0000 (17:37 -0400)]
create question about setup updates following ikiwiki updates
smcv [Sun, 21 Sep 2014 13:06:32 +0000 (09:06 -0400)]
Added a comment
smcv [Sun, 21 Sep 2014 12:50:24 +0000 (08:50 -0400)]
removed
smcv [Sun, 21 Sep 2014 12:50:12 +0000 (08:50 -0400)]
Added a comment
smcv [Sun, 21 Sep 2014 12:49:57 +0000 (08:49 -0400)]
Added a comment
smcv [Sun, 21 Sep 2014 12:41:57 +0000 (08:41 -0400)]
Added a comment
fr33domlover [Sat, 20 Sep 2014 12:50:13 +0000 (08:50 -0400)]
Added a comment
anarcat [Fri, 19 Sep 2014 20:51:10 +0000 (16:51 -0400)]
thanks
smcv [Fri, 19 Sep 2014 20:44:17 +0000 (16:44 -0400)]
not sure that this is needed
anarcat [Fri, 19 Sep 2014 18:17:38 +0000 (14:17 -0400)]
getting notifyemail installed on ikiwiki.info
anarcat [Fri, 19 Sep 2014 17:52:50 +0000 (13:52 -0400)]
fix formatting, ironically
anarcat [Fri, 19 Sep 2014 17:51:46 +0000 (13:51 -0400)]
Does this support ikiwiki-specific idioms
Amitai Schlair [Fri, 19 Sep 2014 12:40:30 +0000 (08:40 -0400)]
document proxy.py warnings seen on auto.setup
Amitai Schlair [Fri, 19 Sep 2014 04:53:16 +0000 (00:53 -0400)]
Anchor subst to opening ", avoiding side effects.
SYSCONFDIR might be overridden to a value containing "etc/ikiwiki",
in which case we might overzealously substitute more than once,
especially if SYSCONFDIR is overridden to different values at build
and install time. Avoid this by matching only the instances we meant
to match.
smcv [Thu, 18 Sep 2014 18:27:44 +0000 (14:27 -0400)]
justification for base tag; relative base might be OK in practice
smcv [Thu, 18 Sep 2014 08:39:19 +0000 (04:39 -0400)]
remove suggestion to wrap inline in <table>, that won't work well
http://anastigmatix.net/ [Thu, 18 Sep 2014 01:34:37 +0000 (21:34 -0400)]
add links to upstream reports
http://anastigmatix.net/ [Thu, 18 Sep 2014 01:18:51 +0000 (21:18 -0400)]
bit of unapologetic fingerpointing
Amitai Schlair [Wed, 17 Sep 2014 22:58:59 +0000 (18:58 -0400)]
add and use a "pkgsrc" shortcut (to pkgsrc.se)
Amitai Schlair [Wed, 17 Sep 2014 22:53:45 +0000 (18:53 -0400)]
I hope pkgsrc also no longer has these problems
smcv [Wed, 17 Sep 2014 21:27:23 +0000 (17:27 -0400)]
review
smcv [Wed, 17 Sep 2014 15:52:37 +0000 (11:52 -0400)]
Added a comment
https://id.koumbit.net/anarcat [Wed, 17 Sep 2014 14:38:08 +0000 (10:38 -0400)]
https://id.koumbit.net/anarcat [Wed, 17 Sep 2014 14:37:28 +0000 (10:37 -0400)]
correct
Added a comment
smcv [Wed, 17 Sep 2014 11:35:07 +0000 (07:35 -0400)]
Added a comment
fr33domlover [Wed, 17 Sep 2014 11:22:58 +0000 (07:22 -0400)]
Added a comment
smcv [Wed, 17 Sep 2014 10:05:12 +0000 (06:05 -0400)]
start designing by listing constraints/requirements
smcv [Wed, 17 Sep 2014 09:14:10 +0000 (05:14 -0400)]
probably fixed
smcv [Wed, 17 Sep 2014 08:56:46 +0000 (04:56 -0400)]
review
smcv [Wed, 17 Sep 2014 08:29:48 +0000 (04:29 -0400)]
Added a comment
smcv [Wed, 17 Sep 2014 08:19:39 +0000 (04:19 -0400)]
Added a comment
smcv [Wed, 17 Sep 2014 08:10:01 +0000 (04:10 -0400)]
Added a comment: next steps
Christopher Baines [Wed, 17 Sep 2014 07:45:51 +0000 (08:45 +0100)]
Add comment regarding GeoJSON output
smcv [Wed, 17 Sep 2014 07:21:53 +0000 (03:21 -0400)]
respond
fr33domlover [Wed, 17 Sep 2014 06:57:42 +0000 (02:57 -0400)]
Added a comment
fr33domlover [Wed, 17 Sep 2014 06:40:59 +0000 (09:40 +0300)]
Write forum page about RTL support of PO plugin
anarcat [Tue, 16 Sep 2014 23:08:25 +0000 (19:08 -0400)]
move the comments in the right place, add my comments
anarcat [Tue, 16 Sep 2014 23:08:04 +0000 (19:08 -0400)]
another review
anarcat [Tue, 16 Sep 2014 22:49:40 +0000 (18:49 -0400)]
fix path to my repo
smcv [Tue, 16 Sep 2014 22:40:08 +0000 (18:40 -0400)]
reviewed elsewhere
smcv [Tue, 16 Sep 2014 22:38:08 +0000 (18:38 -0400)]
review
smcv [Tue, 16 Sep 2014 21:31:29 +0000 (17:31 -0400)]
fixed
https://id.koumbit.net/anarcat [Tue, 16 Sep 2014 18:36:03 +0000 (14:36 -0400)]
fix link to the mtl mesh wiki
http://anastigmatix.net/ [Tue, 16 Sep 2014 18:05:17 +0000 (14:05 -0400)]
followup after asking my provider to fix useragent blocking
Simon McVittie [Tue, 16 Sep 2014 10:28:38 +0000 (11:28 +0100)]
remove webconverger from list of git remotes
This appears to be a website run with ikiwiki, not a set of branches
to fix bugs / add features in the ikiwiki code, so having it appear
in `gitk --all` is just noise.
Simon McVittie [Tue, 16 Sep 2014 10:22:05 +0000 (11:22 +0100)]
Build-depend on libmagickcore-6.q16-2-extra | libmagickcore-extra so we can thumbnail SVGs in the docwiki
Simon McVittie [Tue, 16 Sep 2014 10:18:11 +0000 (11:18 +0100)]
close bug
Simon McVittie [Tue, 16 Sep 2014 10:16:52 +0000 (11:16 +0100)]
news entry for 3.
20140916
Simon McVittie [Mon, 15 Sep 2014 21:24:33 +0000 (22:24 +0100)]
Add myself to Uploaders and release to Debian
Simon McVittie [Tue, 16 Sep 2014 08:43:23 +0000 (09:43 +0100)]
Add package dependencies for scalable img support
- suggest ghostscript (required for PDF-to-PNG thumbnailing)
and libmagickcore-extra (required for SVG-to-PNG thumbnailing)
- build-depend on ghostscript so the test for scalable images can be run
Simon McVittie [Tue, 16 Sep 2014 08:37:41 +0000 (09:37 +0100)]
img: raise an error if we cannot find the image's size
This happens for PDFs without ghostscript installed, for instance.
Simon McVittie [Mon, 15 Sep 2014 22:02:47 +0000 (23:02 +0100)]
img test: skip SVG tests if unsupported by Image::Magick
Amitai Schlair [Tue, 16 Sep 2014 02:16:39 +0000 (22:16 -0400)]
Pass -templatedir to get this test passing again.
smcv [Mon, 15 Sep 2014 22:52:52 +0000 (18:52 -0400)]
bug report
https://id.koumbit.net/anarcat [Mon, 15 Sep 2014 22:28:43 +0000 (18:28 -0400)]
email verification is a separate issue, can we please fix the bug here?
jcflack [Mon, 15 Sep 2014 22:21:13 +0000 (18:21 -0400)]
add gables and turrets to bikeshed
Simon McVittie [Mon, 15 Sep 2014 22:12:53 +0000 (23:12 +0100)]
Revert "Use templatebody for the templates in the basewiki and docwiki"
This reverts commit
236c46a3f7e5e62296484dc47b4882f7f4327a06.
We can't apply this bit until the ikiwiki on ikiwiki.info
(i.e. Branchable) supports [[!templatebody]].
Simon McVittie [Mon, 15 Sep 2014 21:12:45 +0000 (22:12 +0100)]
changelog, close bugs
Simon McVittie [Mon, 15 Sep 2014 20:52:03 +0000 (21:52 +0100)]
Merge branch 'ready/templatebody'
Simon McVittie [Mon, 15 Sep 2014 20:49:48 +0000 (21:49 +0100)]
changelog, close bug
Simon McVittie [Mon, 15 Sep 2014 20:39:18 +0000 (21:39 +0100)]
Merge branch 'master' of ssh://ikiwiki.branchable.com
https://id.koumbit.net/anarcat [Mon, 15 Sep 2014 20:32:19 +0000 (16:32 -0400)]
poll vote (Accept both)
https://id.koumbit.net/anarcat [Mon, 15 Sep 2014 20:30:44 +0000 (16:30 -0400)]
this patch doesn't make the situation worse, actually
https://id.koumbit.net/anarcat [Mon, 15 Sep 2014 20:27:44 +0000 (16:27 -0400)]
first answer
Simon McVittie [Mon, 15 Sep 2014 20:23:18 +0000 (21:23 +0100)]
Merge branch 'ready/autoindex-more-often'
Simon McVittie [Mon, 15 Sep 2014 20:22:42 +0000 (21:22 +0100)]
add more wording based on what chrysn suggested
Simon McVittie [Mon, 15 Sep 2014 20:15:31 +0000 (21:15 +0100)]
Merge branch 'ready/document-success-reason'
Simon McVittie [Mon, 15 Sep 2014 20:12:43 +0000 (21:12 +0100)]
Merge remote-tracking branch 'origin/master'
Simon McVittie [Mon, 15 Sep 2014 20:11:17 +0000 (21:11 +0100)]
changelog, close bug
Simon McVittie [Mon, 15 Sep 2014 20:08:40 +0000 (21:08 +0100)]
Merge branch 'ready/more-magic'
jcflack [Mon, 15 Sep 2014 12:31:20 +0000 (08:31 -0400)]
fine-tuning of halfheartedness
jcflack [Mon, 15 Sep 2014 12:29:36 +0000 (08:29 -0400)]
responses in halfhearted defense of provider in questions
smcv [Mon, 15 Sep 2014 09:30:08 +0000 (05:30 -0400)]
respond
Simon McVittie [Mon, 15 Sep 2014 08:53:52 +0000 (09:53 +0100)]
write changelog, close bug
Simon McVittie [Mon, 15 Sep 2014 08:44:51 +0000 (09:44 +0100)]
Merge remote-tracking branch 'jcflack/early-env'
jcflack [Mon, 15 Sep 2014 00:21:09 +0000 (20:21 -0400)]
made 'this change' link a comparison of the branch rather than a specific commit.
Lafayette Chamber Singers Webmaster [Mon, 15 Sep 2014 00:07:43 +0000 (20:07 -0400)]
More cautious escaping of environment values.
Tightened the escaping per this review comment:
http://source.ikiwiki.branchable.com/?p=source.git;a=commitdiff;h=
f35fc6a603b5473ce2c07bb0236e28e57f718315
(I didn't introduce a $tmp, as $val was local to that block already, and each
hex encoding is in its own C string literal to avoid consuming subsequent
chars that are valid hex digits.)
smcv [Sun, 14 Sep 2014 22:53:37 +0000 (18:53 -0400)]
point taken
jcflack [Sun, 14 Sep 2014 22:34:13 +0000 (18:34 -0400)]
jcflack [Sun, 14 Sep 2014 22:18:08 +0000 (18:18 -0400)]
jcflack [Sun, 14 Sep 2014 22:16:56 +0000 (18:16 -0400)]
rename plugins/plugins/openid/troubleshooting.mdwn to plugins/openid/troubleshooting.mdwn
jcflack [Sun, 14 Sep 2014 22:04:06 +0000 (18:04 -0400)]
jcflack [Sun, 14 Sep 2014 22:03:46 +0000 (18:03 -0400)]