Joey Hess [Tue, 27 Jan 2009 01:02:50 +0000 (20:02 -0500)]
followup
Joey Hess [Tue, 27 Jan 2009 00:46:24 +0000 (19:46 -0500)]
comments
Joey Hess [Tue, 27 Jan 2009 00:41:35 +0000 (19:41 -0500)]
rename hook issues
Joey Hess [Tue, 27 Jan 2009 00:23:21 +0000 (19:23 -0500)]
close bug on this branch
Joey Hess [Tue, 27 Jan 2009 00:13:15 +0000 (19:13 -0500)]
hook function names should be the same as the hook name
intrigeri [Mon, 26 Jan 2009 23:27:41 +0000 (00:27 +0100)]
contrib/po: backlinks=>dependencies is now an option
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 23:19:41 +0000 (00:19 +0100)]
po: make the "backlinks involve dependencies" feature optional
It can now be configured with the po_strictly_refresh_backlinks setting.
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 23:02:15 +0000 (00:02 +0100)]
the rename hooks names waltz seems over
Another set of hooks would not endure such heavy renaming, but the rename* hooks
actually do ;)
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 23:00:00 +0000 (00:00 +0100)]
revert renamepage's hook original name
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 22:47:34 +0000 (23:47 +0100)]
need_global_renamepage_hook: s/suggest/will
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 22:47:02 +0000 (23:47 +0100)]
contrib/po: update after implementing suggested changes
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 22:21:14 +0000 (23:21 +0100)]
po: bring back a useful use of scalar
... that was removed in
68869d664b978b063c9181d024edb34a63306c33
Without this scalar, a two-cells array is passed to $template->param, which
builds a hash with an odd number of elements.
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 22:12:16 +0000 (23:12 +0100)]
plugins/po: talk about the po4a version in the first lines
... as it seems it can be missed if I keep it only in the security section.
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 22:08:53 +0000 (23:08 +0100)]
suggest a po4a version not subject to DoS
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 22:07:19 +0000 (23:07 +0100)]
only pass named parameters to the canremove hook
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 22:02:31 +0000 (23:02 +0100)]
only pass named parameters to the canrename hook
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 21:54:40 +0000 (22:54 +0100)]
po(formbuilder): stop hunting down non-existent cases
After some thinking about it, I can't find why the type of a page being created
in the CGI could be restricted to po. So the previous case seems enough.
Signed-off-by: intrigeri <intrigeri@boum.org>
intrigeri [Mon, 26 Jan 2009 21:51:50 +0000 (22:51 +0100)]
Merge commit 'upstream/master' into prv/po
intrigeri [Mon, 26 Jan 2009 21:32:31 +0000 (22:32 +0100)]
po and doc/todo/need_global_renamepage_hook: response
Signed-off-by: intrigeri <intrigeri@boum.org>
Joey Hess [Mon, 26 Jan 2009 19:21:49 +0000 (14:21 -0500)]
new bug report
Joey Hess [Mon, 26 Jan 2009 19:13:52 +0000 (14:13 -0500)]
review
Joey Hess [Mon, 26 Jan 2009 19:00:28 +0000 (14:00 -0500)]
add mising hooks and fix syntax error
Joey Hess [Mon, 26 Jan 2009 18:51:31 +0000 (13:51 -0500)]
remove unnecessary returns
check_canremove/canrename is called only for its side effect (of failing if
removal is not allowed), its return value is never used and returning
something makes that unclear
Joey Hess [Mon, 26 Jan 2009 18:37:57 +0000 (13:37 -0500)]
don't add new exported warning function
Nothing in the po plugin actually uses this function.
The benefit of adding the function in general is debatable, but I'd
prefer to keep the changes involved in merging po at a minimum.
Joey Hess [Mon, 26 Jan 2009 18:35:50 +0000 (13:35 -0500)]
remove redundant use
use is file-scoped so warnings and strict are already enabled
inside the second package, and IkiWiki is already loaded
(though not imported into this context)
Joey Hess [Mon, 26 Jan 2009 18:33:02 +0000 (13:33 -0500)]
non-code changes
Joey Hess [Mon, 26 Jan 2009 18:28:57 +0000 (13:28 -0500)]
more unnecessary parens
Joey Hess [Mon, 26 Jan 2009 18:25:05 +0000 (13:25 -0500)]
avoid keeping running if a DOS attack is possible
Joey Hess [Mon, 26 Jan 2009 18:24:33 +0000 (13:24 -0500)]
remove unnecessary parens
Joey Hess [Mon, 26 Jan 2009 18:21:33 +0000 (13:21 -0500)]
another useless use of scalar
scalar(undef) is undef, so using scalar here had no effect.
Instead make the function return "", probably avoiding an uninitialized
value warning.
Joey Hess [Mon, 26 Jan 2009 18:17:14 +0000 (13:17 -0500)]
remove useless uses of scalar
if (scalar @array) is written idiomatically in perl as
if (@array).
Joey Hess [Mon, 26 Jan 2009 18:15:29 +0000 (13:15 -0500)]
improve some english
I'm still not happy with the clarity of this warning message.
I don't understand when it could happen or why a warning is needed.
Joey Hess [Mon, 26 Jan 2009 18:10:37 +0000 (13:10 -0500)]
avoid standalone -e or foo syntax
I prefer to use either of the other two syntaxes perl offers, and not this
one.
Joey Hess [Mon, 26 Jan 2009 18:08:25 +0000 (13:08 -0500)]
avoid mixing english with translation
"google search" is english which would get mixed in with translated text.
Instead, usr just the plugin name.
Joey Hess [Mon, 26 Jan 2009 18:05:38 +0000 (13:05 -0500)]
Merge branch 'master' into po
qiang [Mon, 26 Jan 2009 10:35:55 +0000 (05:35 -0500)]
Joey Hess [Mon, 26 Jan 2009 04:13:14 +0000 (23:13 -0500)]
git: Fix malformed utf8 recieved from git.
If git log outputs malformed utf8 in, eg, usernames, detect it and fix it
up. This avoids commits such as
f71abc92aa279fbe0b7578b8c4752d775dd4a259
breaking things.
Joey Hess [Mon, 26 Jan 2009 04:02:11 +0000 (23:02 -0500)]
update
Joey Hess [Mon, 26 Jan 2009 03:59:20 +0000 (22:59 -0500)]
update
Joey Hess [Mon, 26 Jan 2009 03:44:38 +0000 (22:44 -0500)]
typo
Joey Hess [Mon, 26 Jan 2009 03:30:28 +0000 (22:30 -0500)]
format moderation queue only at end, avoid O(N^3) bug
It was calling format hooks for each comment on the page.
When relativedate is enabled, that made it insert <script> tags
for each comment. And the browser loaded the same script over and over,
which was slow on its own. But that was nothing compared to running
the onload even over and over.. especially since the hook system
added a new call to the hook each time it loaded.
For a page with 10 comments, that caused the relativedate DOM parsing
code to run 1000 times, I think. Anyway, it was sloow. Now it runs once.
Joey Hess [Mon, 26 Jan 2009 03:25:45 +0000 (22:25 -0500)]
add reject all marked defer checkbox
Joey Hess [Mon, 26 Jan 2009 00:45:56 +0000 (19:45 -0500)]
sort comment queue by time, newest first
Joey Hess [Mon, 26 Jan 2009 00:04:45 +0000 (19:04 -0500)]
add a button to prefs page for comment moderation
Joey Hess [Sun, 25 Jan 2009 23:56:47 +0000 (18:56 -0500)]
clean up comment preview
Remove actions from it, and avoid a broken title link.
Joey Hess [Sun, 25 Jan 2009 23:50:35 +0000 (18:50 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Sun, 25 Jan 2009 23:49:57 +0000 (18:49 -0500)]
comments: Add a moderation web interface.
Joey Hess [Sun, 25 Jan 2009 23:35:18 +0000 (18:35 -0500)]
remove hr under comment actions
The horizontal line was only meant to be displayed under
the actions at the top of a page.
Joey Hess [Sun, 25 Jan 2009 22:51:00 +0000 (17:51 -0500)]
add alt tag
GuenterLadwig [Sun, 25 Jan 2009 21:41:24 +0000 (16:41 -0500)]
GuenterLadwig [Sun, 25 Jan 2009 21:40:29 +0000 (16:40 -0500)]
GünterLadwig [Sun, 25 Jan 2009 21:37:32 +0000 (16:37 -0500)]
GünterLadwig [Sun, 25 Jan 2009 21:34:27 +0000 (16:34 -0500)]
Joey Hess [Sun, 25 Jan 2009 20:42:13 +0000 (15:42 -0500)]
comments: If comment content checks fail, store the comment (in .ikiwiki/comments_pending) for moderator review.
Joey Hess [Sun, 25 Jan 2009 19:40:32 +0000 (14:40 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Sun, 25 Jan 2009 19:37:04 +0000 (14:37 -0500)]
blogspam: Fix use of blogspam_options and blogspam_server config settings.
Rocco [Sun, 25 Jan 2009 08:39:52 +0000 (03:39 -0500)]
vote for Template::Toolkit
Joey Hess [Sat, 24 Jan 2009 18:04:59 +0000 (13:04 -0500)]
clarify description of verbose
It enables debug prints, so not just during building, but at runtime.
http://joey.kitenet.net/ [Sat, 24 Jan 2009 17:43:32 +0000 (12:43 -0500)]
qiang [Sat, 24 Jan 2009 17:37:53 +0000 (12:37 -0500)]
Joey Hess [Sat, 24 Jan 2009 01:08:52 +0000 (20:08 -0500)]
typo
Joey Hess [Fri, 23 Jan 2009 21:54:13 +0000 (16:54 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
Joey Hess [Fri, 23 Jan 2009 21:46:49 +0000 (16:46 -0500)]
mention identica group
qiang [Fri, 23 Jan 2009 09:50:07 +0000 (04:50 -0500)]
qiang [Fri, 23 Jan 2009 09:44:24 +0000 (04:44 -0500)]
justin [Fri, 23 Jan 2009 02:29:53 +0000 (21:29 -0500)]
followup on pagespec negation
Joey Hess [Fri, 23 Jan 2009 02:10:05 +0000 (21:10 -0500)]
typo
Joey Hess [Fri, 23 Jan 2009 01:58:49 +0000 (20:58 -0500)]
fix uninitialized value warnings
I suspect these are only triggered by spammers.
Joey Hess [Fri, 23 Jan 2009 01:53:47 +0000 (20:53 -0500)]
fix typo
Joey Hess [Thu, 22 Jan 2009 20:30:14 +0000 (15:30 -0500)]
response
justin [Thu, 22 Jan 2009 04:37:55 +0000 (23:37 -0500)]
question on locked_pages and users() in pagespec
Joey Hess [Thu, 22 Jan 2009 04:12:44 +0000 (23:12 -0500)]
one fleeting second thought
Joey Hess [Thu, 22 Jan 2009 04:09:16 +0000 (23:09 -0500)]
response
Joey Hess [Thu, 22 Jan 2009 04:04:48 +0000 (23:04 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
justin [Thu, 22 Jan 2009 04:03:08 +0000 (23:03 -0500)]
Question about user tests
Joey Hess [Thu, 22 Jan 2009 04:01:37 +0000 (23:01 -0500)]
add
Gabriel McManus [Mon, 7 Jul 2008 11:33:01 +0000 (21:33 +1000)]
img: only provide alt text if it was specified
if suitable alternate text is unknown, then it should not be given.
empty alt text is suitable mainly for purely decorative images.
(cherry picked from commit
3cd7f67f0cf894f4fd5ba16f68e82e4f7bdbfdc5)
kgjenkins [Wed, 21 Jan 2009 22:52:10 +0000 (17:52 -0500)]
added version
kent [Wed, 21 Jan 2009 02:04:25 +0000 (21:04 -0500)]
Joey Hess [Tue, 20 Jan 2009 21:30:59 +0000 (16:30 -0500)]
add human-readable error when unknown pagespec function is called
It used to replace unknown functions with "0" when translating a pagespec.
Instead, replace it with a FailReason object. This way, the pagespec will
still evaluate as before (possibly successfully if other terminals exist),
but a human-readable error will be shown if the result is displayed.
Also, an empty pagespec used to be replaced with "0", to avoid a eval
error. Also use a FailReason here.
Joey Hess [Tue, 20 Jan 2009 16:33:47 +0000 (11:33 -0500)]
cleanup
Joey Hess [Tue, 20 Jan 2009 16:32:48 +0000 (11:32 -0500)]
response
Joey Hess [Tue, 20 Jan 2009 16:20:13 +0000 (11:20 -0500)]
Remove nonstandard css. Closes: #512378
Joey Hess [Tue, 20 Jan 2009 16:12:49 +0000 (11:12 -0500)]
fix removal form display
The form was misdisplayed when displayed via comment removal.
Joey Hess [Tue, 20 Jan 2009 16:12:17 +0000 (11:12 -0500)]
Merge branch 'master' of ssh://git.ikiwiki.info/srv/git/ikiwiki.info
http://taozhyn.myopenid.com/ [Tue, 20 Jan 2009 04:33:34 +0000 (23:33 -0500)]
intrigeri [Mon, 19 Jan 2009 23:53:46 +0000 (00:53 +0100)]
po: let's walk the last steps needed before merge!
Signed-off-by: intrigeri <intrigeri@boum.org>
Joey Hess [Mon, 19 Jan 2009 19:11:15 +0000 (14:11 -0500)]
blogspam: Log spam info on failure.
Víctor Moral [Mon, 19 Jan 2009 08:02:21 +0000 (09:02 +0100)]
Updated spanish translation
intrigeri [Mon, 19 Jan 2009 18:53:32 +0000 (19:53 +0100)]
remove cansave plugin, now replaced by Joey's checkcontent one
Signed-off-by: intrigeri <intrigeri@boum.org>
http://zms.myopenid.com/ [Mon, 19 Jan 2009 18:45:29 +0000 (13:45 -0500)]
intrigeri [Mon, 19 Jan 2009 18:44:39 +0000 (19:44 +0100)]
make checkcontent compatible with hooks that need the full content
Always pass the full (modified) content in `content` named parameter. When the
user edits an existing wiki page, also pass a `diff` named parameter, which
includes only the lines that they added to the page, or modified.
Signed-off-by: intrigeri <intrigeri@boum.org>
http://zms.myopenid.com/ [Mon, 19 Jan 2009 18:43:00 +0000 (13:43 -0500)]
kent [Mon, 19 Jan 2009 08:06:36 +0000 (03:06 -0500)]
Simon McVittie [Sun, 18 Jan 2009 16:27:43 +0000 (16:27 +0000)]
Add meta field "updated", which can alter the <updated> Atom element
Some aggregators, like Planet, sort by mtime rather than ctime. This
means that posts with modified content come to the top (which seems odd
to me, but is presumably what the aggregator's author or operator
wants), but it also means that posts with insignificant edits (like
adding tags) come to the top too. Atom defines <updated> to be the date
of the last *significant* change, so it's fine that ikiwiki defaults to
using the mtime, but it would be good to have a way for the author to
say "that edit was insignificant, don't use that mtime".
Joey Hess [Sun, 18 Jan 2009 19:52:49 +0000 (14:52 -0500)]
Avoid feeding decoded unicode to Term::ReadLine
That resulted in double encoded display when using perl's stub
readline module. Apparently that module unconditionally upgrades
text to utf8, in a quite braindead way.
(Term::ReadLine::Gnu::Perl worked ok.)
http://smcv.pseudorandom.co.uk/ [Sun, 18 Jan 2009 18:36:22 +0000 (13:36 -0500)]
overriding visible modification time (to avoid insignificant edits flooding planets)
Simon McVittie [Sun, 18 Jan 2009 17:30:52 +0000 (17:30 +0000)]
Some more thoughts about a gallery plugin
Simon McVittie [Sun, 18 Jan 2009 16:49:53 +0000 (16:49 +0000)]
Add myself to ikiwikiusers
Simon McVittie [Sun, 18 Jan 2009 16:43:07 +0000 (16:43 +0000)]
Document underlay plugin as included