]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/log
git.ikiwiki.info.git
5 years agopo: Always filter .po files
Simon McVittie [Sat, 1 Dec 2018 21:18:23 +0000 (21:18 +0000)]
po: Always filter .po files

The input to filter hooks is meant to be the content of a source file
on disk. If we only filter once per (page, destpage) pair, and a page
is inlined into the same destpage more than once, then the second
occurrence will render as the result of htmlizing .po source as if
it was Markdown (or whatever the type of the corresponding master page
is), which is never going to end well.

The alreadyfiltered mechanism was added in commit 1e874b3f to avoid
preprocessing loops, but I'm not sure where it could lead to a loop:
filter hooks are only called from IkiWiki::filter, which is only called
on page content from disk or on proposed content being previewed.
According to <https://bugs.debian.org/911356#41>, deleting the
alreadyfiltered mechanism resolves the problem, as well as simplifying
the code.

Closes: #911356
Tested-by: intrigeri
5 years agoRecommend against cvsps3 (haven't tried it).
Amitai Schleier [Thu, 14 Feb 2019 04:59:32 +0000 (23:59 -0500)]
Recommend against cvsps3 (haven't tried it).

5 years agoAnnounce v3.20190207
Simon McVittie [Thu, 7 Feb 2019 11:32:21 +0000 (11:32 +0000)]
Announce v3.20190207

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoPrepare new release 3.20190207
Simon McVittie [Thu, 7 Feb 2019 11:08:02 +0000 (11:08 +0000)]
Prepare new release

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoreview
Simon McVittie [Sun, 3 Feb 2019 19:22:07 +0000 (19:22 +0000)]
review

5 years agocomment
Simon McVittie [Sun, 3 Feb 2019 18:53:23 +0000 (18:53 +0000)]
comment

5 years agotag as reviewed
smcv [Sun, 3 Feb 2019 18:40:29 +0000 (14:40 -0400)]
tag as reviewed

5 years agorespond
smcv [Sun, 3 Feb 2019 18:39:51 +0000 (14:39 -0400)]
respond

5 years agoExclude reviewed patches from this list
smcv [Sun, 3 Feb 2019 18:28:21 +0000 (14:28 -0400)]
Exclude reviewed patches from this list

5 years agoclose
Simon McVittie [Sun, 3 Feb 2019 17:10:45 +0000 (17:10 +0000)]
close

5 years agoappend javascript after CSS
Antoine Beaupré [Mon, 6 Nov 2017 19:15:22 +0000 (14:15 -0500)]
append javascript after CSS

Javascript resources should be presented to browsers after CSS, and
"after the fold" (ATF) according to the best practices:

https://developers.google.com/speed/docs/insights/mobile#PutStylesBeforeScripts

This change allows the browser to download Javascript files in
parallel, by including Javascript on the *closing* </body> tag instead
of the opening tag.

We also improve the regex to tolerate spaces before the body tag, as
some templates have (proper) indentation for the tag.

5 years agoRemove unreachable git repositories
Simon McVittie [Sun, 2 Sep 2018 11:49:16 +0000 (12:49 +0100)]
Remove unreachable git repositories

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoMark as applied
Simon McVittie [Sun, 3 Feb 2019 16:54:20 +0000 (16:54 +0000)]
Mark as applied

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoremove the "add comment" button from printed media
Antoine Beaupré [Thu, 11 Oct 2018 18:32:41 +0000 (14:32 -0400)]
remove the "add comment" button from printed media

5 years agoAdd a missing changelog entry.
Amitai Schleier [Sun, 3 Feb 2019 16:34:43 +0000 (10:34 -0600)]
Add a missing changelog entry.

5 years agoUpdate changelog
Simon McVittie [Sun, 3 Feb 2019 16:27:38 +0000 (16:27 +0000)]
Update changelog

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoAllow Breezy as alternative to Bazaar.
Jelmer Vernooij [Mon, 8 Oct 2018 06:52:28 +0000 (07:52 +0100)]
Allow Breezy as alternative to Bazaar.

(cherry picked from commit a07f048d9fc99928ebbb74b34f5d1932ff3d7884)

5 years agocomments.t: Assert that comments get permalink metadata
Simon McVittie [Sun, 3 Feb 2019 16:06:36 +0000 (16:06 +0000)]
comments.t: Assert that comments get permalink metadata

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agocomments.t: Exercise post-2009 comment naming
Simon McVittie [Sun, 3 Feb 2019 16:05:13 +0000 (16:05 +0000)]
comments.t: Exercise post-2009 comment naming

Since commit 6af6c89d, comments are in files whose names contain a hash.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoold regexp would have failed for old comment page names
smcv [Sun, 3 Feb 2019 15:55:34 +0000 (11:55 -0400)]
old regexp would have failed for old comment page names

5 years agogit-cgi.t: Exercise an alphanumeric, but non-ASCII, root page
Simon McVittie [Sun, 3 Feb 2019 13:19:57 +0000 (13:19 +0000)]
git-cgi.t: Exercise an alphanumeric, but non-ASCII, root page

My previous attempt to reproduce this bug used a non-alphanumeric
ASCII character. This is not currently considered to be a valid
value for rootpage, although for a "do what I mean" approach, perhaps
we should accept it and pass it through titlepage() or linkpage().

Using Chinese characters (which are considered to match [[:alnum:]]
even though the Chinese script is not, strictly speaking, an alphabet),
as in the original bug report, reproduces the bug.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoFix inline plugin for non-ASCII rootpage
Feng Shu [Sun, 2 Dec 2018 00:38:34 +0000 (08:38 +0800)]
Fix inline plugin for non-ASCII rootpage

5 years agot: Exercise Chinese and Cyrillic page titles
Simon McVittie [Sun, 3 Feb 2019 13:07:01 +0000 (13:07 +0000)]
t: Exercise Chinese and Cyrillic page titles

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agotrail: Allow unescaped punctuation in pagenames
Simon McVittie [Sun, 3 Feb 2019 12:52:42 +0000 (12:52 +0000)]
trail: Allow unescaped punctuation in pagenames

By processing the pagenames through linkpage, we let users specify
page names that contain non-alphanumerics in a more natural way.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agotrail.t: Exercise numeric escapes in pagenames parameter
Simon McVittie [Sun, 3 Feb 2019 11:58:25 +0000 (11:58 +0000)]
trail.t: Exercise numeric escapes in pagenames parameter

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agolinkpage.t: Assert we can link to pages with literal underscore
Simon McVittie [Sun, 3 Feb 2019 12:48:40 +0000 (12:48 +0000)]
linkpage.t: Assert we can link to pages with literal underscore

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agot: Consistently remove temp directory before testing, not after
Simon McVittie [Sun, 3 Feb 2019 12:25:20 +0000 (12:25 +0000)]
t: Consistently remove temp directory before testing, not after

When a test fails, it's useful to be able to inspect the output.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agobuild: Add `make reset-generated`
Simon McVittie [Sun, 3 Feb 2019 12:34:34 +0000 (12:34 +0000)]
build: Add `make reset-generated`

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agopagetitle.t, linkpage.t, titlepage.t: Exercise Unicode more
Simon McVittie [Sun, 3 Feb 2019 11:48:43 +0000 (11:48 +0000)]
pagetitle.t, linkpage.t, titlepage.t: Exercise Unicode more

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agolink to recently-added tests
smcv [Thu, 31 Jan 2019 20:41:17 +0000 (16:41 -0400)]
link to recently-added tests

5 years agoI'm confused about what the bug is, and what's being fixed. Can you give a complete...
smcv [Thu, 31 Jan 2019 20:38:04 +0000 (16:38 -0400)]
I'm confused about what the bug is, and what's being fixed. Can you give a complete test or example?

5 years agoclose bug
Simon McVittie [Thu, 31 Jan 2019 20:30:41 +0000 (20:30 +0000)]
close bug

5 years agoUpdate changelog
Simon McVittie [Thu, 31 Jan 2019 20:29:48 +0000 (20:29 +0000)]
Update changelog

5 years agoAdd a simple test for non-ASCII in tables
Simon McVittie [Thu, 31 Jan 2019 20:14:51 +0000 (20:14 +0000)]
Add a simple test for non-ASCII in tables

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoFix table plugin can handle UTF-8 csv format
Feng Shu [Sun, 2 Dec 2018 00:41:39 +0000 (08:41 +0800)]
Fix table plugin can handle UTF-8 csv format

5 years agorespond
Simon McVittie [Thu, 31 Jan 2019 19:58:30 +0000 (19:58 +0000)]
respond

5 years agoFix syntax and escaping
Simon McVittie [Thu, 31 Jan 2019 19:52:17 +0000 (19:52 +0000)]
Fix syntax and escaping

5 years agogit-cgi.t: Add a failing test for a blog with a non-ASCII rootpage
Simon McVittie [Thu, 31 Jan 2019 19:50:14 +0000 (19:50 +0000)]
git-cgi.t: Add a failing test for a blog with a non-ASCII rootpage

This is one of several possible bug reports on
"doc/bugs/About %2F problem" (I'm not sure what the actual bug being
reported is).

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agogit-cgi.t: Add a simple test for blog posts from a root page
Simon McVittie [Thu, 31 Jan 2019 19:49:10 +0000 (19:49 +0000)]
git-cgi.t: Add a simple test for blog posts from a root page

This is the working base case for "doc/bugs/About %2F problem".

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agogit-cgi.t: Print query string as a TAP diagnostic
Simon McVittie [Thu, 31 Jan 2019 19:48:08 +0000 (19:48 +0000)]
git-cgi.t: Print query string as a TAP diagnostic

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoReset example
smcv [Thu, 31 Jan 2019 19:32:03 +0000 (15:32 -0400)]
Reset example

This reverts commit 0b53772b99248d2868fac688cdaa227ad61ac08e

5 years agoinline is another option of course
anarcat [Wed, 30 Jan 2019 16:33:15 +0000 (12:33 -0400)]
inline is another option of course

5 years agoshow tagging example
anarcat [Wed, 30 Jan 2019 16:32:47 +0000 (12:32 -0400)]
show tagging example

5 years agolink to the map plugin, which i find more useful to show tagged pages
anarcat [Wed, 30 Jan 2019 16:29:49 +0000 (12:29 -0400)]
link to the map plugin, which i find more useful to show tagged pages

5 years ago(no commit message)
dorondd@5f188d26a5727578cbe5901372cc69f1664a852b [Wed, 23 Jan 2019 04:53:59 +0000 (00:53 -0400)]

5 years agofollowup
Joey Hess [Mon, 21 Jan 2019 15:59:08 +0000 (11:59 -0400)]
followup

5 years agofix permalink to comments
Joey Hess [Mon, 21 Jan 2019 15:57:23 +0000 (11:57 -0400)]
fix permalink to comments

This commit was sponsored by Thomas May.

5 years agoMerge branch 'master' of ssh://git.ikiwiki.info
Joey Hess [Mon, 21 Jan 2019 15:44:58 +0000 (11:44 -0400)]
Merge branch 'master' of ssh://git.ikiwiki.info

5 years agobug report
Joey Hess [Mon, 21 Jan 2019 15:44:29 +0000 (11:44 -0400)]
bug report

5 years ago(no commit message)
ntntnt [Mon, 21 Jan 2019 04:34:51 +0000 (00:34 -0400)]

5 years agoUser link and description changed
Jens [Thu, 17 Jan 2019 18:02:56 +0000 (14:02 -0400)]
User link and description changed

6 years agomarkdown backquotes
https://sonata-green.dreamwidth.org/ [Mon, 24 Dec 2018 16:15:32 +0000 (12:15 -0400)]
markdown backquotes

6 years ago(no commit message)
ALEXEIDZ [Sun, 16 Dec 2018 20:21:52 +0000 (16:21 -0400)]

6 years ago(no commit message)
ALEXEIDZ [Sun, 16 Dec 2018 20:20:16 +0000 (16:20 -0400)]

6 years agofollowup
Joey Hess [Wed, 12 Dec 2018 14:43:52 +0000 (10:43 -0400)]
followup

6 years ago(no commit message)
xuqi [Mon, 10 Dec 2018 09:44:33 +0000 (05:44 -0400)]

6 years ago(no commit message)
xuqi [Mon, 10 Dec 2018 09:43:58 +0000 (05:43 -0400)]

6 years agode-indenting
xuqi [Mon, 10 Dec 2018 09:27:58 +0000 (05:27 -0400)]
de-indenting

6 years agoexample for inlining only one level of subpages
xuqi [Mon, 10 Dec 2018 09:27:16 +0000 (05:27 -0400)]
example for inlining only one level of subpages

6 years agofail to inject IkiWiki::showform
tumashu1 [Sat, 8 Dec 2018 08:08:38 +0000 (04:08 -0400)]
fail to inject IkiWiki::showform

6 years agopatch works for me
jmtd [Fri, 7 Dec 2018 10:11:12 +0000 (06:11 -0400)]
patch works for me

6 years agoack
jmtd [Fri, 7 Dec 2018 10:05:34 +0000 (06:05 -0400)]
ack

6 years agorename and remove plug can not work well with gettext
tumashu1 [Wed, 5 Dec 2018 06:47:55 +0000 (02:47 -0400)]
rename and remove plug can not work well with gettext

6 years ago(no commit message)
tumashu1 [Sun, 2 Dec 2018 01:42:06 +0000 (21:42 -0400)]

6 years agoSuggest let table plugin support a kind of longtable
tumashu1 [Sun, 2 Dec 2018 01:41:25 +0000 (21:41 -0400)]
Suggest let table plugin support a kind of longtable

6 years ago(no commit message)
tumashu1 [Sun, 2 Dec 2018 00:56:04 +0000 (20:56 -0400)]

6 years agoAdd a patch deal with UTF-8 csv table's problem
tumashu1 [Sun, 2 Dec 2018 00:55:16 +0000 (20:55 -0400)]
Add a patch deal with UTF-8 csv table's problem

6 years agoAdd a patch decode_utf8 inline's root page
tumashu1 [Sun, 2 Dec 2018 00:50:04 +0000 (20:50 -0400)]
Add a patch decode_utf8 inline's root page

6 years agoadd redirection
smcv [Sat, 1 Dec 2018 21:29:56 +0000 (17:29 -0400)]
add redirection

6 years agoupdate for rename of bugs/Re-use_translated_content_instead_of_skipping_if_previously...
smcv [Sat, 1 Dec 2018 21:28:11 +0000 (17:28 -0400)]
update for rename of bugs/Re-use_translated_content_instead_of_skipping_if_previously_translated/20180628-patch.txt to bugs/po:_second_or_subsequent_inline_of_translated_page_inlines_.po_file__44___not_translated_content/20180628-patch.txt

6 years agorename bugs/Re-use_translated_content_instead_of_skipping_if_previously_translated...
smcv [Sat, 1 Dec 2018 21:28:11 +0000 (17:28 -0400)]
rename bugs/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn to bugs/po:_second_or_subsequent_inline_of_translated_page_inlines_.po_file__44___not_translated_content.mdwn

6 years agoupdate for rename of todo/Re-use_translated_content_instead_of_skipping_if_previously...
smcv [Sat, 1 Dec 2018 21:26:49 +0000 (17:26 -0400)]
update for rename of todo/Re-use_translated_content_instead_of_skipping_if_previously_translated/20180628-patch.txt to bugs/Re-use_translated_content_instead_of_skipping_if_previously_translated/20180628-patch.txt

6 years agorename todo/Re-use_translated_content_instead_of_skipping_if_previously_translated...
smcv [Sat, 1 Dec 2018 21:26:48 +0000 (17:26 -0400)]
rename todo/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn to bugs/Re-use_translated_content_instead_of_skipping_if_previously_translated.mdwn

6 years agorefer to a branch
smcv [Sat, 1 Dec 2018 21:25:16 +0000 (17:25 -0400)]
refer to a branch

6 years agoikiwiki.info doesn't have fenced code blocks yet
Simon McVittie [Sat, 1 Dec 2018 21:07:38 +0000 (21:07 +0000)]
ikiwiki.info doesn't have fenced code blocks yet

6 years agoEscape directives in code
Simon McVittie [Sat, 1 Dec 2018 21:06:39 +0000 (21:06 +0000)]
Escape directives in code

6 years agoReview
Simon McVittie [Sat, 1 Dec 2018 21:05:18 +0000 (21:05 +0000)]
Review

6 years agopo: Improve test coverage
Simon McVittie [Sat, 1 Dec 2018 17:36:04 +0000 (17:36 +0000)]
po: Improve test coverage

Signed-off-by: Simon McVittie <smcv@debian.org>
6 years agopo: Add failing test for Debian bug #911356
Simon McVittie [Sat, 1 Dec 2018 13:37:38 +0000 (13:37 +0000)]
po: Add failing test for Debian bug #911356

Signed-off-by: Simon McVittie <smcv@debian.org>
6 years agoFix broken link in basewiki
Simon McVittie [Sat, 1 Dec 2018 13:48:07 +0000 (13:48 +0000)]
Fix broken link in basewiki

Links from pages in the basewiki (which is also a subset of ikiwiki's
own wiki) to pages on ikiwiki's own wiki have to use [[!iki]] so that
they will not become broken links when the page in question is copied
into other installations.

Detected by ./t/basewiki_brokenlinks.t.

Signed-off-by: Simon McVittie <smcv@debian.org>
6 years agoI don't think the Chinese text causes this
smcv [Sat, 1 Dec 2018 12:28:11 +0000 (08:28 -0400)]
I don't think the Chinese text causes this

6 years agocomments (no review yet)
smcv [Sat, 1 Dec 2018 12:13:39 +0000 (08:13 -0400)]
comments (no review yet)

6 years agoRevert spam
smcv [Sat, 1 Dec 2018 11:53:47 +0000 (07:53 -0400)]
Revert spam

This reverts commit c600ed0e710d82601acf5ae4005b940f5cba8c08

6 years ago(no commit message)
tumashu1 [Wed, 28 Nov 2018 07:55:15 +0000 (03:55 -0400)]

6 years ago(no commit message)
tumashu1 [Wed, 28 Nov 2018 07:36:09 +0000 (03:36 -0400)]

6 years ago(no commit message)
tumashu1 [Wed, 28 Nov 2018 05:16:33 +0000 (01:16 -0400)]

6 years agorelated issue
jmtd [Tue, 27 Nov 2018 10:06:58 +0000 (06:06 -0400)]
related issue

6 years agoerror output when trying
jmtd [Tue, 27 Nov 2018 10:05:01 +0000 (06:05 -0400)]
error output when trying

6 years agorename postvote to postlink
Joey Hess [Mon, 26 Nov 2018 17:23:50 +0000 (13:23 -0400)]
rename postvote to postlink

This better explains what it contains, which is a wikilink to the page
to go to after posting the vote. And postlink is more consistent a name
with posttrail.

6 years agopoll: Added postvote and posttrail options for better multi-page polls.
Joey Hess [Mon, 26 Nov 2018 17:14:21 +0000 (13:14 -0400)]
poll: Added postvote and posttrail options for better multi-page polls.

Modern web users probably expect the poll to move on automatically to the
next question, and this allows for that behavior.

Note that bestlink() runs at vote time, which avoids needing to make the
page containing the poll depend on the page that sets up a trail, as the
current trail at vote time will be used.

This commit was sponsored by Eric Drechsel on Patreon.

6 years ago(no commit message)
tumashu1 [Mon, 26 Nov 2018 08:53:53 +0000 (04:53 -0400)]

6 years ago(no commit message)
tumashu1 [Mon, 26 Nov 2018 08:53:13 +0000 (04:53 -0400)]

6 years ago(no commit message)
tumashu1 [Mon, 26 Nov 2018 08:44:35 +0000 (04:44 -0400)]

6 years agoavoiding ban?
anarcat [Mon, 12 Nov 2018 14:58:48 +0000 (10:58 -0400)]
avoiding ban?

6 years agoupdate my entry
hefee@4770422daf1f192bbf7aa984e90ec894f6e3b7e3 [Wed, 7 Nov 2018 08:59:14 +0000 (04:59 -0400)]
update my entry

6 years agoupdate description & remove tag patch
hefee@4770422daf1f192bbf7aa984e90ec894f6e3b7e3 [Wed, 7 Nov 2018 08:54:45 +0000 (04:54 -0400)]
update description & remove tag patch

6 years agomore spam issues. this is definitely not done.
anarcat [Tue, 6 Nov 2018 22:02:26 +0000 (18:02 -0400)]
more spam issues. this is definitely not done.

6 years agoaggregate: Fix aggregation of posts without a title
Joey Hess [Sun, 28 Oct 2018 22:57:45 +0000 (18:57 -0400)]
aggregate: Fix aggregation of posts without a title

When an aggregated post lacked a title, the code first prepended the
$feed->{dir} to it, and only then checked if it had zero length. So,
that check could never succeed and it was possible to end up with
$page="dir/", and writing to that would of course fail.

(Same problem could also occur when the whole title got sanitized away by the
wiki_file_regexp.)

Fixed by simply checking earlier if $page is empty.

Based on a patch by Alexandre Oliva which got lost in a maze of email
folders all alike for over two years despite him mentioning it to me at
least once in person.

6 years agoGive graph an optional "file" param, like table's.
Amitai Schleier [Mon, 22 Oct 2018 04:24:59 +0000 (00:24 -0400)]
Give graph an optional "file" param, like table's.

6 years ago(no commit message)
lamby@8534e4c2b408c76c30ab7bf8979fdb14963b7ed5 [Fri, 19 Oct 2018 00:19:15 +0000 (20:19 -0400)]