]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/log
git.ikiwiki.info.git
5 years agolink to the actual ikiwiki repo
giuseppe.bilotta@94e824d38b59eac6c61da2ef23fad955d65eb2a1 [Mon, 21 Oct 2019 17:03:58 +0000 (13:03 -0400)]
link to the actual ikiwiki repo

5 years agoWhitespace
giuseppe.bilotta@94e824d38b59eac6c61da2ef23fad955d65eb2a1 [Mon, 21 Oct 2019 17:03:05 +0000 (13:03 -0400)]
Whitespace

5 years agoProposed support for object tag
giuseppe.bilotta@94e824d38b59eac6c61da2ef23fad955d65eb2a1 [Mon, 21 Oct 2019 17:02:29 +0000 (13:02 -0400)]
Proposed support for object tag

5 years agoI had the same problem somebody on the discussion page had so I changed the instructi...
dave@2ab82f485adf7e2ce787066e35f5f9789bff430b [Thu, 10 Oct 2019 18:40:58 +0000 (14:40 -0400)]
I had the same problem somebody on the discussion page had so I changed the instructions so nobody else will.

5 years agolibtext-csv-xs-perl not relevant
jmtd [Thu, 10 Oct 2019 15:40:08 +0000 (11:40 -0400)]
libtext-csv-xs-perl not relevant

5 years agosigh, still broken, different error message.
jmtd [Thu, 10 Oct 2019 15:36:29 +0000 (11:36 -0400)]
sigh, still broken, different error message.

5 years agolibpel5
jmtd [Mon, 7 Oct 2019 18:15:10 +0000 (14:15 -0400)]
libpel5

5 years agomore info: libperl5, buster versus stretch
jmtd [Mon, 7 Oct 2019 15:39:05 +0000 (11:39 -0400)]
more info: libperl5, buster versus stretch

5 years agofollow-up: sorry, I appreciate that wasn't as useful as it could have been
jmtd [Mon, 7 Oct 2019 13:57:00 +0000 (09:57 -0400)]
follow-up: sorry, I appreciate that wasn't as useful as it could have been

5 years agosplit done and not done patch list, remove patches from the other lists
anarcat [Wed, 2 Oct 2019 14:27:16 +0000 (10:27 -0400)]
split done and not done patch list, remove patches from the other lists

5 years agoexplicitely tag this as a patch
anarcat [Wed, 2 Oct 2019 14:25:39 +0000 (10:25 -0400)]
explicitely tag this as a patch

5 years agoGentle ping on proposed branch
intrigeri [Mon, 30 Sep 2019 14:59:33 +0000 (10:59 -0400)]
Gentle ping on proposed branch

5 years agocannot reproduce new bug
Simon McVittie [Sun, 29 Sep 2019 17:42:40 +0000 (18:42 +0100)]
cannot reproduce new bug

5 years agoUpdate changelog with schmonz's changes
Simon McVittie [Sun, 29 Sep 2019 16:48:25 +0000 (17:48 +0100)]
Update changelog with schmonz's changes

5 years ago(no commit message)
poobah@5486f0334d386be645fa4deeed4bf2d8593152c5 [Sat, 28 Sep 2019 17:52:05 +0000 (13:52 -0400)]

5 years agobug remains for inline table case
jmtd [Mon, 23 Sep 2019 10:06:59 +0000 (06:06 -0400)]
bug remains for inline table case

5 years agobug report
Joey Hess [Fri, 20 Sep 2019 16:10:18 +0000 (12:10 -0400)]
bug report

5 years agoFix build with po4a 0.56 via consistent "\n" use.
Amitai Schleier [Tue, 10 Sep 2019 13:59:26 +0000 (09:59 -0400)]
Fix build with po4a 0.56 via consistent "\n" use.

Errors look like so:

PERL5LIB=.. ./po2wiki underlay.setup
Invalid po file
/var/folders/y5/k8bh4xsj75g4j1n631f2gqz80000gp/T/ikiwiki-po-filter-in.OPXJxZ0juW:
/var/folders/y5/k8bh4xsj75g4j1n631f2gqz80000gp/T/ikiwiki-po-filter-in.OPXJxZ0juW:293:
'msgid' and 'msgstr' entries do not both end with '\n'
/var/folders/y5/k8bh4xsj75g4j1n631f2gqz80000gp/T/ikiwiki-po-filter-in.OPXJxZ0juW:589:
'msgid' and 'msgstr' entries do not both end with '\n'
msgfmt: found 2 fatal errors

make[1]: *** [po2wiki_stamp] Error 255

5 years agonot sure this is necessary
anarcat [Fri, 6 Sep 2019 14:16:05 +0000 (10:16 -0400)]
not sure this is necessary

5 years agoadd link to auto-numbering on CSS
luke.leighton@1d9c2d1569043638b2028a9c61a0a205924749b5 [Fri, 6 Sep 2019 11:05:51 +0000 (07:05 -0400)]
add link to auto-numbering on CSS

5 years agoMultiMarkdown footnote un-inversion: done
Amitai Schleier [Wed, 4 Sep 2019 23:07:46 +0000 (19:07 -0400)]
MultiMarkdown footnote un-inversion: done

5 years agoFix inverted footnote config with MultiMarkdown.
Amitai Schleier [Wed, 4 Sep 2019 23:01:28 +0000 (19:01 -0400)]
Fix inverted footnote config with MultiMarkdown.

Bug spotted and fix from Giuseppe Bilotta <giuseppe.bilotta@gmail.com>.

Extend mdwn tests to cover MultiMarkdown, where applicable.

5 years agoPlease test sudo-mass-rebuild branch on Debian
Amitai Schleier [Wed, 4 Sep 2019 18:38:43 +0000 (14:38 -0400)]
Please test sudo-mass-rebuild branch on Debian

5 years ago(no commit message)
xloem [Tue, 3 Sep 2019 14:04:47 +0000 (10:04 -0400)]

5 years agoResponse: am trying sudo
Amitai Schleier [Sun, 1 Sep 2019 14:39:48 +0000 (10:39 -0400)]
Response: am trying sudo

5 years agorename bugs/MultiMarkdown_footnot_support_seems_to_be_broken.mdwn to bugs/MultiMarkdo...
giuseppe.bilotta@94e824d38b59eac6c61da2ef23fad955d65eb2a1 [Fri, 30 Aug 2019 05:32:55 +0000 (01:32 -0400)]
rename bugs/MultiMarkdown_footnot_support_seems_to_be_broken.mdwn to bugs/MultiMarkdown_footnote_support_seems_to_be_broken.mdwn

5 years agoDirective fix
giuseppe.bilotta@94e824d38b59eac6c61da2ef23fad955d65eb2a1 [Fri, 30 Aug 2019 05:32:33 +0000 (01:32 -0400)]
Directive fix

5 years ago(no commit message)
giuseppe.bilotta@94e824d38b59eac6c61da2ef23fad955d65eb2a1 [Fri, 30 Aug 2019 05:31:05 +0000 (01:31 -0400)]

5 years agoI've not looked at Shake yet, thanks, I'll give it a look! — [[Jon]]
jmtd [Sun, 25 Aug 2019 21:04:57 +0000 (17:04 -0400)]
I've not looked at Shake yet, thanks, I'll give it a look! — [[Jon]]

5 years ago(no commit message)
simon@4e26c0bdeb57cbb3cc79e234379178f37fa71d06 [Thu, 22 Aug 2019 11:39:54 +0000 (07:39 -0400)]

5 years agoSuggest shake
simon@4e26c0bdeb57cbb3cc79e234379178f37fa71d06 [Thu, 22 Aug 2019 11:36:03 +0000 (07:36 -0400)]
Suggest shake

5 years agosome beginning code to migrate an ikiwiki to hakyll
jmtd [Wed, 21 Aug 2019 15:38:08 +0000 (11:38 -0400)]
some beginning code to migrate an ikiwiki to hakyll

5 years agolol
jmtd [Fri, 16 Aug 2019 13:21:33 +0000 (09:21 -0400)]
lol

5 years agosaw typesetter-css and was reminded of my appeal against the anti-theme as default
jmtd [Fri, 16 Aug 2019 13:18:35 +0000 (09:18 -0400)]
saw typesetter-css and was reminded of my appeal against the anti-theme as default

5 years ago(no commit message)
lkcl@d317c3c240102454f3d5ffa9210ae2178eb5af3a [Tue, 25 Jun 2019 15:48:24 +0000 (11:48 -0400)]

5 years agoAdding my work-in-progress blog to the list
https://launchpad.net/~skellat [Mon, 17 Jun 2019 01:32:02 +0000 (21:32 -0400)]
Adding my work-in-progress blog to the list

5 years agoNo longer hosting these on Branchable.
Amitai Schleier [Fri, 7 Jun 2019 21:12:46 +0000 (17:12 -0400)]
No longer hosting these on Branchable.

5 years agoMerge branch 'master' of ssh://git.ikiwiki.info
Joey Hess [Thu, 6 Jun 2019 21:18:22 +0000 (17:18 -0400)]
Merge branch 'master' of ssh://git.ikiwiki.info

5 years agoUpdated German program translation from Sebastian Kuhnert.
Joey Hess [Thu, 6 Jun 2019 21:17:58 +0000 (17:17 -0400)]
Updated German program translation from Sebastian Kuhnert.

5 years agoFix link in previous.
Amitai Schleier [Wed, 5 Jun 2019 17:52:41 +0000 (13:52 -0400)]
Fix link in previous.

5 years agoReply to fancypodcast question.
Amitai Schleier [Wed, 5 Jun 2019 17:50:22 +0000 (13:50 -0400)]
Reply to fancypodcast question.

5 years agoUpdated German basewiki and directives translation from Sebastian Kuhnert.
Joey Hess [Wed, 5 Jun 2019 16:09:08 +0000 (12:09 -0400)]
Updated German basewiki and directives translation from Sebastian Kuhnert.

5 years agoOpen up the discussion
https://launchpad.net/~skellat [Sun, 2 Jun 2019 04:56:41 +0000 (00:56 -0400)]
Open up the discussion

5 years agoCatch up to highlight 3.51 API change.
Amitai Schleier [Mon, 27 May 2019 03:45:10 +0000 (23:45 -0400)]
Catch up to highlight 3.51 API change.

As of 3.51, searchFile() is no longer provided in highlight's Perl
bindings (at least on NetBSD and OS X, as built from pkgsrc). This
leaves us falling through to getConfDir(), which has been gone
rather longer.

From highlight git, it appears searchFile() and getFiletypesConfPath()
both originated in the 3.14 release. The latter is still available in
3.51, and returns the same result searchFile() used to. Switch to it.

5 years agoAdd my ikiwiki/blog
canvon [Tue, 21 May 2019 13:19:34 +0000 (09:19 -0400)]
Add my ikiwiki/blog

5 years ago(no commit message)
jsewell@560d759be38e126eba7f1c40503adf786fa28229 [Fri, 10 May 2019 17:26:11 +0000 (13:26 -0400)]

5 years ago(no commit message)
jsewell@560d759be38e126eba7f1c40503adf786fa28229 [Tue, 7 May 2019 15:05:05 +0000 (11:05 -0400)]

5 years agoResponse to jsewell's bug report.
Amitai Schleier [Mon, 6 May 2019 11:43:17 +0000 (07:43 -0400)]
Response to jsewell's bug report.

5 years ago(no commit message)
second-try-ikilogin@ac12e40a987a7e7baaf5623cd9a082f9925fb4a1 [Mon, 6 May 2019 01:48:31 +0000 (21:48 -0400)]

5 years ago(no commit message)
jsewell@560d759be38e126eba7f1c40503adf786fa28229 [Mon, 29 Apr 2019 14:19:12 +0000 (10:19 -0400)]

5 years agoadd gitbranch template, prompted by Integeri. Thanks
jmtd [Wed, 24 Apr 2019 19:19:32 +0000 (15:19 -0400)]
add gitbranch template, prompted by Integeri. Thanks

5 years agoFix syntax.
intrigeri [Wed, 10 Apr 2019 21:02:16 +0000 (17:02 -0400)]
Fix syntax.

5 years agoSubmit branch for review.
intrigeri [Wed, 10 Apr 2019 21:01:07 +0000 (17:01 -0400)]
Submit branch for review.

5 years agoupdate my comment to reflect new commits on that branch
jmtd [Sat, 30 Mar 2019 21:34:11 +0000 (17:34 -0400)]
update my comment to reflect new commits on that branch

5 years agoinitial implementation (I was unable to use untrusted git push to add this comment)
jmtd [Fri, 29 Mar 2019 11:17:45 +0000 (07:17 -0400)]
initial implementation (I was unable to use untrusted git push to add this comment)

5 years ago(no commit message)
mike@8d1a742254a41aaff8dd19404183dce96fac24ba [Thu, 7 Mar 2019 00:05:56 +0000 (20:05 -0400)]

5 years ago(no commit message)
krukova.ann@14e9655c363b07d848ae6d37ce799ad41f0c51fb [Wed, 6 Mar 2019 10:59:07 +0000 (06:59 -0400)]

5 years ago(no commit message)
krukova.ann@14e9655c363b07d848ae6d37ce799ad41f0c51fb [Wed, 6 Mar 2019 10:57:50 +0000 (06:57 -0400)]

5 years agoMerge remote-tracking branch 'origin/master'
Simon McVittie [Thu, 28 Feb 2019 18:03:18 +0000 (18:03 +0000)]
Merge remote-tracking branch 'origin/master'

5 years agoAnnounce 3.20190228 and 3.20170111.1
Simon McVittie [Thu, 28 Feb 2019 14:14:12 +0000 (14:14 +0000)]
Announce 3.20190228 and 3.20170111.1

5 years agoAdd an anchor for /security/#cve-2019-9187
Simon McVittie [Thu, 28 Feb 2019 14:11:20 +0000 (14:11 +0000)]
Add an anchor for /security/#cve-2019-9187

5 years agoPrepare 3.20190228 for future release 3.20190228
Simon McVittie [Tue, 26 Feb 2019 21:06:45 +0000 (21:06 +0000)]
Prepare 3.20190228 for future release

5 years agodoc: Document security issues involving LWP::UserAgent
Simon McVittie [Sun, 10 Feb 2019 16:56:41 +0000 (16:56 +0000)]
doc: Document security issues involving LWP::UserAgent

Recommend the LWPx::ParanoidAgent module where appropriate.
It is particularly important for openid, since unauthenticated users
can control which URLs that plugin will contact. Conversely, it is
non-critical for blogspam, since the URL to be contacted is under
the wiki administrator's control.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agouseragent: Automatically choose whether to use LWPx::ParanoidAgent
Simon McVittie [Sun, 10 Feb 2019 17:22:06 +0000 (17:22 +0000)]
useragent: Automatically choose whether to use LWPx::ParanoidAgent

The simple implementation of this, which I'd prefer to use, would be:
if we can import LWPx::ParanoidAgent, use it; otherwise, use
LWP::UserAgent.

However, aggregate has historically worked with proxies, and
LWPx::ParanoidAgent quite reasonably refuses to work with proxies
(because it can't know whether those proxies are going to do the same
filtering that LWPx::ParanoidAgent would).

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agouseragent: Don't allow non-HTTP protocols to be used
Simon McVittie [Sun, 10 Feb 2019 16:30:07 +0000 (16:30 +0000)]
useragent: Don't allow non-HTTP protocols to be used

This prevents the aggregate plugin from being used to read the contents
of local files via file:/// URLs.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoThis reverts commit 727147aa6e50229178fb853f26c9c340fa789799
anarcat [Tue, 26 Feb 2019 05:35:32 +0000 (01:35 -0400)]
This reverts commit 727147aa6e50229178fb853f26c9c340fa789799

5 years ago(no commit message)
machine_brain [Tue, 26 Feb 2019 00:01:58 +0000 (20:01 -0400)]

5 years agouseragent: Raise an exception if the LWP module can't be loaded
Simon McVittie [Sun, 10 Feb 2019 16:29:19 +0000 (16:29 +0000)]
useragent: Raise an exception if the LWP module can't be loaded

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agopo: Always filter .po files
Simon McVittie [Sat, 1 Dec 2018 21:18:23 +0000 (21:18 +0000)]
po: Always filter .po files

The input to filter hooks is meant to be the content of a source file
on disk. If we only filter once per (page, destpage) pair, and a page
is inlined into the same destpage more than once, then the second
occurrence will render as the result of htmlizing .po source as if
it was Markdown (or whatever the type of the corresponding master page
is), which is never going to end well.

The alreadyfiltered mechanism was added in commit 1e874b3f to avoid
preprocessing loops, but I'm not sure where it could lead to a loop:
filter hooks are only called from IkiWiki::filter, which is only called
on page content from disk or on proposed content being previewed.
According to <https://bugs.debian.org/911356#41>, deleting the
alreadyfiltered mechanism resolves the problem, as well as simplifying
the code.

Closes: #911356
Tested-by: intrigeri
5 years agoRecommend against cvsps3 (haven't tried it).
Amitai Schleier [Thu, 14 Feb 2019 04:59:32 +0000 (23:59 -0500)]
Recommend against cvsps3 (haven't tried it).

5 years agoAnnounce v3.20190207
Simon McVittie [Thu, 7 Feb 2019 11:32:21 +0000 (11:32 +0000)]
Announce v3.20190207

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoPrepare new release 3.20190207
Simon McVittie [Thu, 7 Feb 2019 11:08:02 +0000 (11:08 +0000)]
Prepare new release

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoreview
Simon McVittie [Sun, 3 Feb 2019 19:22:07 +0000 (19:22 +0000)]
review

5 years agocomment
Simon McVittie [Sun, 3 Feb 2019 18:53:23 +0000 (18:53 +0000)]
comment

5 years agotag as reviewed
smcv [Sun, 3 Feb 2019 18:40:29 +0000 (14:40 -0400)]
tag as reviewed

5 years agorespond
smcv [Sun, 3 Feb 2019 18:39:51 +0000 (14:39 -0400)]
respond

5 years agoExclude reviewed patches from this list
smcv [Sun, 3 Feb 2019 18:28:21 +0000 (14:28 -0400)]
Exclude reviewed patches from this list

5 years agoclose
Simon McVittie [Sun, 3 Feb 2019 17:10:45 +0000 (17:10 +0000)]
close

5 years agoappend javascript after CSS
Antoine Beaupré [Mon, 6 Nov 2017 19:15:22 +0000 (14:15 -0500)]
append javascript after CSS

Javascript resources should be presented to browsers after CSS, and
"after the fold" (ATF) according to the best practices:

https://developers.google.com/speed/docs/insights/mobile#PutStylesBeforeScripts

This change allows the browser to download Javascript files in
parallel, by including Javascript on the *closing* </body> tag instead
of the opening tag.

We also improve the regex to tolerate spaces before the body tag, as
some templates have (proper) indentation for the tag.

5 years agoRemove unreachable git repositories
Simon McVittie [Sun, 2 Sep 2018 11:49:16 +0000 (12:49 +0100)]
Remove unreachable git repositories

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoMark as applied
Simon McVittie [Sun, 3 Feb 2019 16:54:20 +0000 (16:54 +0000)]
Mark as applied

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoremove the "add comment" button from printed media
Antoine Beaupré [Thu, 11 Oct 2018 18:32:41 +0000 (14:32 -0400)]
remove the "add comment" button from printed media

5 years agoAdd a missing changelog entry.
Amitai Schleier [Sun, 3 Feb 2019 16:34:43 +0000 (10:34 -0600)]
Add a missing changelog entry.

5 years agoUpdate changelog
Simon McVittie [Sun, 3 Feb 2019 16:27:38 +0000 (16:27 +0000)]
Update changelog

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoAllow Breezy as alternative to Bazaar.
Jelmer Vernooij [Mon, 8 Oct 2018 06:52:28 +0000 (07:52 +0100)]
Allow Breezy as alternative to Bazaar.

(cherry picked from commit a07f048d9fc99928ebbb74b34f5d1932ff3d7884)

5 years agocomments.t: Assert that comments get permalink metadata
Simon McVittie [Sun, 3 Feb 2019 16:06:36 +0000 (16:06 +0000)]
comments.t: Assert that comments get permalink metadata

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agocomments.t: Exercise post-2009 comment naming
Simon McVittie [Sun, 3 Feb 2019 16:05:13 +0000 (16:05 +0000)]
comments.t: Exercise post-2009 comment naming

Since commit 6af6c89d, comments are in files whose names contain a hash.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoold regexp would have failed for old comment page names
smcv [Sun, 3 Feb 2019 15:55:34 +0000 (11:55 -0400)]
old regexp would have failed for old comment page names

5 years agogit-cgi.t: Exercise an alphanumeric, but non-ASCII, root page
Simon McVittie [Sun, 3 Feb 2019 13:19:57 +0000 (13:19 +0000)]
git-cgi.t: Exercise an alphanumeric, but non-ASCII, root page

My previous attempt to reproduce this bug used a non-alphanumeric
ASCII character. This is not currently considered to be a valid
value for rootpage, although for a "do what I mean" approach, perhaps
we should accept it and pass it through titlepage() or linkpage().

Using Chinese characters (which are considered to match [[:alnum:]]
even though the Chinese script is not, strictly speaking, an alphabet),
as in the original bug report, reproduces the bug.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agoFix inline plugin for non-ASCII rootpage
Feng Shu [Sun, 2 Dec 2018 00:38:34 +0000 (08:38 +0800)]
Fix inline plugin for non-ASCII rootpage

5 years agot: Exercise Chinese and Cyrillic page titles
Simon McVittie [Sun, 3 Feb 2019 13:07:01 +0000 (13:07 +0000)]
t: Exercise Chinese and Cyrillic page titles

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agotrail: Allow unescaped punctuation in pagenames
Simon McVittie [Sun, 3 Feb 2019 12:52:42 +0000 (12:52 +0000)]
trail: Allow unescaped punctuation in pagenames

By processing the pagenames through linkpage, we let users specify
page names that contain non-alphanumerics in a more natural way.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agotrail.t: Exercise numeric escapes in pagenames parameter
Simon McVittie [Sun, 3 Feb 2019 11:58:25 +0000 (11:58 +0000)]
trail.t: Exercise numeric escapes in pagenames parameter

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agolinkpage.t: Assert we can link to pages with literal underscore
Simon McVittie [Sun, 3 Feb 2019 12:48:40 +0000 (12:48 +0000)]
linkpage.t: Assert we can link to pages with literal underscore

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agot: Consistently remove temp directory before testing, not after
Simon McVittie [Sun, 3 Feb 2019 12:25:20 +0000 (12:25 +0000)]
t: Consistently remove temp directory before testing, not after

When a test fails, it's useful to be able to inspect the output.

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agobuild: Add `make reset-generated`
Simon McVittie [Sun, 3 Feb 2019 12:34:34 +0000 (12:34 +0000)]
build: Add `make reset-generated`

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agopagetitle.t, linkpage.t, titlepage.t: Exercise Unicode more
Simon McVittie [Sun, 3 Feb 2019 11:48:43 +0000 (11:48 +0000)]
pagetitle.t, linkpage.t, titlepage.t: Exercise Unicode more

Signed-off-by: Simon McVittie <smcv@debian.org>
5 years agolink to recently-added tests
smcv [Thu, 31 Jan 2019 20:41:17 +0000 (16:41 -0400)]
link to recently-added tests

5 years agoI'm confused about what the bug is, and what's being fixed. Can you give a complete...
smcv [Thu, 31 Jan 2019 20:38:04 +0000 (16:38 -0400)]
I'm confused about what the bug is, and what's being fixed. Can you give a complete test or example?

5 years agoclose bug
Simon McVittie [Thu, 31 Jan 2019 20:30:41 +0000 (20:30 +0000)]
close bug