From: Joey Hess <joey@kodama.kitenet.net>
Date: Mon, 6 Oct 2008 20:10:47 +0000 (-0400)
Subject: remove: Avoid $_ breakage. (Stupid, stupid perl.)
X-Git-Tag: 2.67~61
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/fea76a11bc3673bc6fb523cffd8c325982bf44f7

remove: Avoid $_ breakage. (Stupid, stupid perl.)

This avoids another one of those $_ scoping issues where a deep call to a
function that changes $_ clobbers the array that is being looped over.
---

diff --git a/IkiWiki/Plugin/remove.pm b/IkiWiki/Plugin/remove.pm
index cf95026c8..68bf9d1ee 100644
--- a/IkiWiki/Plugin/remove.pm
+++ b/IkiWiki/Plugin/remove.pm
@@ -98,7 +98,9 @@ sub removal_confirm ($$@) { #{{{
 	my $attachment=shift;
 	my @pages=@_;
 
-	check_canremove($_, $q, $session) foreach @pages;
+	foreach my $page (@pages) {
+		check_canremove($page, $q, $session);
+	}
 
    	# Save current form state to allow returning to it later
 	# without losing any edits.
diff --git a/debian/changelog b/debian/changelog
index fc1eb4819..2b51dd2d6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+ikiwiki (2.67) UNRELEASED; urgency=low
+
+  * remove: Avoid $_ breakage. (Stupid, stupid perl.)
+
+ -- Joey Hess <joeyh@debian.org>  Mon, 06 Oct 2008 16:07:50 -0400
+
 ikiwiki (2.66) unstable; urgency=low
 
   * recentchanges: Fix redirects to non-page files.