From: intrigeri Date: Wed, 22 Dec 2010 11:50:50 +0000 (+0100) Subject: Rename new bug so that it appears on the po plugin page. X-Git-Tag: 3.20101231~50 X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/fd6d4fda6a95f8318c33aed66c4fcf05aad72b86 Rename new bug so that it appears on the po plugin page. --- diff --git a/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn b/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn new file mode 100644 index 000000000..a6287714b --- /dev/null +++ b/doc/bugs/po:_plugin_should_not_override_the_title_on_the_homepage.mdwn @@ -0,0 +1,19 @@ +The po plugin systematically overrides the title of the homepage with the wikiname. This prevents explicitly changing it with a meta directive. It should rather check whether it was overridden before setting it back. + +Here is a simple patch for that: + + diff --git a/Plugin/po.pm b/Plugin/po.pm + index 6395ebd..a048c6a 100644 + --- a/Plugin/po.pm + +++ b/Plugin/po.pm + @@ -333,7 +333,7 @@ sub pagetemplate (@) { + && $masterpage eq "index") { + $template->param('parentlinks' => []); + } + - if (ishomepage($page) && $template->query(name => "title")) { + + if (ishomepage($page) && $template->query(name => "title") && !$template->query(name => "title_overridden")) { + $template->param(title => $config{wikiname}); + } + } + +Thanks. diff --git a/doc/bugs/po_plugin_should_not_override_the_title_on_the_homepage.mdwn b/doc/bugs/po_plugin_should_not_override_the_title_on_the_homepage.mdwn deleted file mode 100644 index a6287714b..000000000 --- a/doc/bugs/po_plugin_should_not_override_the_title_on_the_homepage.mdwn +++ /dev/null @@ -1,19 +0,0 @@ -The po plugin systematically overrides the title of the homepage with the wikiname. This prevents explicitly changing it with a meta directive. It should rather check whether it was overridden before setting it back. - -Here is a simple patch for that: - - diff --git a/Plugin/po.pm b/Plugin/po.pm - index 6395ebd..a048c6a 100644 - --- a/Plugin/po.pm - +++ b/Plugin/po.pm - @@ -333,7 +333,7 @@ sub pagetemplate (@) { - && $masterpage eq "index") { - $template->param('parentlinks' => []); - } - - if (ishomepage($page) && $template->query(name => "title")) { - + if (ishomepage($page) && $template->query(name => "title") && !$template->query(name => "title_overridden")) { - $template->param(title => $config{wikiname}); - } - } - -Thanks.