From: smcv <smcv@web>
Date: Fri, 4 Jul 2014 08:11:48 +0000 (-0400)
Subject: positive review
X-Git-Tag: debian/3.20140815~28^2~45
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/e740ff3a4be827f1289ce855d704704db7a60feb?hp=6d90e56c8dbb1e380f0e621305fd014767e9364b

positive review
---

diff --git a/doc/bugs/linkmap_displays_underscore_escapes.mdwn b/doc/bugs/linkmap_displays_underscore_escapes.mdwn
index 75b917163..41ea070a2 100644
--- a/doc/bugs/linkmap_displays_underscore_escapes.mdwn
+++ b/doc/bugs/linkmap_displays_underscore_escapes.mdwn
@@ -17,9 +17,7 @@ the attached [[!taglink patch]] fixes this; from its commit message:
 
 the output will look much better (at least in my wikis) with the "[[bugs/pagetitle function does not respect meta titles]]" issue fixed.
 
-> I agree that it's (likely to be) a bug to not use `pagetitle()`. I
-> haven't reviewed this particular implementation yet but I'll try to
-> do that soon.
+> [[Looks good to me|users/smcv/yesplease]].
 >
 > I don't think it's correct for `pagetitle()` to output `\[[!meta title]]`
 > though, as discussed on the linked bug: it appears in an assortment of