From: smcv <smcv@web>
Date: Mon, 30 Jun 2014 09:49:44 +0000 (-0400)
Subject: review, suggest a change
X-Git-Tag: debian/3.20140815~28^2~57
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/c10c6c1c4db528877113ea808dbecb1cd3cd4682?ds=inline;hp=a4d3db605a921b6c99d1b5082450090e31911afc

review, suggest a change
---

diff --git a/doc/bugs/pythonproxy-utf8_again.mdwn b/doc/bugs/pythonproxy-utf8_again.mdwn
index 14d5cb98e..b5564d6c1 100644
--- a/doc/bugs/pythonproxy-utf8_again.mdwn
+++ b/doc/bugs/pythonproxy-utf8_again.mdwn
@@ -34,3 +34,15 @@ patch.
 > it seems to me that the issue is related to the way exceptions are encoded.
 >
 > the suggested patch still applies and solves the issue. --[[chrysn]]
+
+>> In this patch band:
+>>
+>>     -        xml = _IkiWikiExtPluginXMLRPCHandler._read(in_fd).decode('utf8')
+>>     +        response = _IkiWikiExtPluginXMLRPCHandler._read(in_fd)
+>>     +        if isinstance(response, unicode):
+>>     +            xml = response.encode('utf8')
+>>
+>> I think you mean `response.decode`, not `response.encode`.
+>>
+>> Other than that it looks good to me. I like the use of `repr` in debug
+>> messages. --[[smcv]]