From: Simon McVittie <smcv@debian.org>
Date: Mon, 9 Jan 2017 11:37:10 +0000 (+0000)
Subject: Use rel=nofollow microformat for dynamic (CGI-related) URLs
X-Git-Tag: 3.20170110~19
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/9e7f0a6c59ec89c32af64d1577e314dd68b8e7f6

Use rel=nofollow microformat for dynamic (CGI-related) URLs

Some of these might be relatively expensive to dereference or result
in messages being logged, and there's no reason why a search engine
should need to index them. (In particular, we'd probably prefer search
engines to index the rendered page, not its source code.)
---

diff --git a/IkiWiki/Plugin/comments.pm b/IkiWiki/Plugin/comments.pm
index 0858f69f1..46e1b268f 100644
--- a/IkiWiki/Plugin/comments.pm
+++ b/IkiWiki/Plugin/comments.pm
@@ -126,7 +126,7 @@ sub htmlize {
 sub htmlize_pending {
 	my %params = @_;
 	return sprintf(gettext("this comment needs %s"),
-		'<a href="'.
+		'<a rel="nofollow" href="'.
 		IkiWiki::cgiurl(do => "commentmoderation").'">'.
 		gettext("moderation").'</a>');
 }
@@ -286,7 +286,7 @@ sub preprocess_moderation {
 		unless defined $params{desc};
 
 	if (length $config{cgiurl}) {
-		return '<a href="'.
+		return '<a rel="nofollow" href="'.
 			IkiWiki::cgiurl(do => 'commentmoderation').
 			'">'.$params{desc}.'</a>';
 	}
@@ -946,7 +946,7 @@ sub pagetemplate (@) {
 				);
 			}
 			elsif (commentsopen($page)) {
-				$link = "<a href=\"".addcommenturl($page)."\">".
+				$link = "<a rel=\"nofollow\" href=\"".addcommenturl($page)."\">".
 					#translators: Here "Comment" is a verb;
 					#translators: the user clicks on it to
 					#translators: post a comment.
diff --git a/IkiWiki/Plugin/passwordauth.pm b/IkiWiki/Plugin/passwordauth.pm
index c966087ce..fb3fd9ee1 100644
--- a/IkiWiki/Plugin/passwordauth.pm
+++ b/IkiWiki/Plugin/passwordauth.pm
@@ -305,7 +305,7 @@ sub formbuilder_setup (@) {
 						noimageinline => 1));
 			}
 			else {
-				$form->text("<a href=\"".
+				$form->text("<a rel=\"nofollow\" href=\"".
 					IkiWiki::cgiurl(do => "edit", page => $userpage).
 					"\">".gettext("Create your user page")."</a>");
 			}
diff --git a/templates/editcomment.tmpl b/templates/editcomment.tmpl
index e177db959..703564eb6 100644
--- a/templates/editcomment.tmpl
+++ b/templates/editcomment.tmpl
@@ -8,7 +8,7 @@
 <TMPL_UNLESS NAME=USERNAME>
 <TMPL_IF NAME=ALLOWAUTHOR>
 <label for="author" class="block">Name:</label>
-<TMPL_VAR NAME=FIELD-AUTHOR> (optional, or <a href="<TMPL_VAR SIGNINURL>">signin</a>)
+<TMPL_VAR NAME=FIELD-AUTHOR> (optional, or <a rel="nofollow" href="<TMPL_VAR SIGNINURL>">signin</a>)
 <br/>
 <label for="url" class="block">Website:</label>
 <TMPL_VAR NAME=FIELD-URL> (optional)
@@ -17,7 +17,7 @@
 <TMPL_VAR NAME=FIELD-EMAIL> <TMPL_VAR FIELD-ANONSUBSCRIBE>
 <br />
 <TMPL_ELSE>
-(You might want to <a href="<TMPL_VAR SIGNINURL>">Signin</a> first?)
+(You might want to <a rel="nofollow" href="<TMPL_VAR SIGNINURL>">Signin</a> first?)
 <br />
 </TMPL_IF>
 </TMPL_UNLESS>
diff --git a/templates/page.tmpl b/templates/page.tmpl
index 183d733e1..a1991f6e4 100644
--- a/templates/page.tmpl
+++ b/templates/page.tmpl
@@ -74,13 +74,13 @@
 <li><a href="<TMPL_VAR RECENTCHANGESURL>">RecentChanges</a></li>
 </TMPL_IF>
 <TMPL_IF HISTORYURL>
-<li><a href="<TMPL_VAR HISTORYURL>">History</a></li>
+<li><a rel="nofollow" href="<TMPL_VAR HISTORYURL>">History</a></li>
 </TMPL_IF>
 <TMPL_IF GETSOURCEURL>
-<li><a href="<TMPL_VAR GETSOURCEURL>">Source</a></li>
+<li><a rel="nofollow" href="<TMPL_VAR GETSOURCEURL>">Source</a></li>
 </TMPL_IF>
 <TMPL_IF PREFSURL>
-<li><a href="<TMPL_VAR PREFSURL>">Preferences</a></li>
+<li><a rel="nofollow" href="<TMPL_VAR PREFSURL>">Preferences</a></li>
 </TMPL_IF>
 <TMPL_IF ACTIONS>
 <TMPL_LOOP ACTIONS>
@@ -147,7 +147,7 @@
 <TMPL_VAR COMMENTS>
 <TMPL_IF ADDCOMMENTURL>
 <div class="addcomment">
-<a href="<TMPL_VAR ADDCOMMENTURL>">Add a comment</a>
+<a rel="nofollow" href="<TMPL_VAR ADDCOMMENTURL>">Add a comment</a>
 </div>
 <TMPL_ELSE>
 <div class="addcomment">Comments on this page are closed.</div>