From: Joey Hess <joeyh@joeyh.name>
Date: Mon, 21 Jan 2019 15:59:08 +0000 (-0400)
Subject: followup
X-Git-Tag: 3.20190207~42
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/94bfecfb7ad3decb0b38baddccdf07e87e7a4551

followup
---

diff --git a/doc/bugs/permalink_not_set_for_comments.mdwn b/doc/bugs/permalink_not_set_for_comments.mdwn
index 9ca8200b5..2e74a2622 100644
--- a/doc/bugs/permalink_not_set_for_comments.mdwn
+++ b/doc/bugs/permalink_not_set_for_comments.mdwn
@@ -14,3 +14,12 @@ permalink:
 
 `comments_pagename` is `comment_` so the above code needs a comment page to contain
 two underscores. I think that is the root of the bug. --[[Joey]]
+
+> Removed the trailing underscore in the regexp, so it should be fixed,
+> though I have not tested the fix. Leaving this bug open until it's
+> confirmed fixed. (I deployed it to branchable.)
+> 
+> This will only fix the stored permalink metadata for a comment when its get
+> preprocessed again, not immediately. That's ok for notifyemail,
+> but other uses of permalink might need a wiki rebuild to get the bug fix.
+> --[[Joey]]