From: Joey Hess <joey@kitenet.net>
Date: Tue, 15 Jun 2010 17:33:43 +0000 (-0400)
Subject: fix labels for form elements
X-Git-Tag: 3.20100623~61
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/919df4ae9c0372506feebee41821e4de2c78cb91?hp=4e18d4415b49bbcc4a43db22ee4473a8c99f0eb2

fix labels for form elements

The label for attribute must correspond to the element id (not name).
And it needs to be unique inside the loop.
---

diff --git a/templates/commentmoderation.tmpl b/templates/commentmoderation.tmpl
index 10f2b36df..dfa63c20b 100644
--- a/templates/commentmoderation.tmpl
+++ b/templates/commentmoderation.tmpl
@@ -4,7 +4,7 @@
 <input type="hidden" name="do" value="commentmoderation" />
 <input type="hidden" name="sid" value="<TMPL_VAR SID>" />
 <input type="submit" value="Submit" />
-<input type="checkbox" name="rejectalldefer" value="1" />
+<input id="rejectalldefer" type="checkbox" name="rejectalldefer" value="1" />
 <label for="rejectalldefer">Reject all comments marked <em>Defer</em></label>
 <br />
 <TMPL_LOOP COMMENTS>
@@ -12,18 +12,18 @@
 <div>
 <TMPL_VAR VIEW>
 </div>
-<input type="radio" value="Defer" name="<TMPL_VAR ID>" checked="checked" />
-<label for="Defer">Defer</label>
-<input type="radio" value="Accept" name="<TMPL_VAR ID>" />
-<label for="Accept">Accept</label>
-<input type="radio" value="Reject" name="<TMPL_VAR ID>" />
-<label for="Reject">Reject</label>
+<input id="defer_<TMPL_VAR ID>" type="radio" value="Defer" name="<TMPL_VAR ID>" checked="checked" />
+<label for="defer_<TMPL_VAR ID>">Defer</label>
+<input id="dccept_<TMPL_VAR ID>" type="radio" value="Accept" name="<TMPL_VAR ID>" />
+<label for="dccept_<TMPL_VAR ID>">Accept</label>
+<input id="reject_<TMPL_VAR ID>" type="radio" value="Reject" name="<TMPL_VAR ID>" />
+<label for="reject_<TMPL_VAR ID>">Reject</label>
 </div>
 <br />
 </TMPL_LOOP>
 <input type="submit" value="Submit" />
-<input type="checkbox" name="rejectalldefer" value="1" />
-<label for="rejectalldefer">Reject all comments marked <em>Defer</em></label>
+<input id="rejectalldefer2" type="checkbox" name="rejectalldefer" value="1" />
+<label for="rejectalldefer2">Reject all comments marked <em>Defer</em></label>
 </form>
 <TMPL_ELSE>
 <p>