From: joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>
Date: Thu, 4 Oct 2007 08:58:47 +0000 (+0000)
Subject: comment
X-Git-Tag: 2.10~76
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/868d78293f68d54daf704b80558564c2259c35b7

comment
---

diff --git a/doc/todo/git-rev-list_requires_relative_path___40__fixes_git_ctime__41__.mdwn b/doc/todo/git-rev-list_requires_relative_path___40__fixes_git_ctime__41__.mdwn
index 9594cff4d..981a8f374 100644
--- a/doc/todo/git-rev-list_requires_relative_path___40__fixes_git_ctime__41__.mdwn
+++ b/doc/todo/git-rev-list_requires_relative_path___40__fixes_git_ctime__41__.mdwn
@@ -13,4 +13,12 @@
  	 	my ($sha1) = run_or_non('git-rev-list', '--max-count=1', 'HEAD', $file);
  	 	if ($sha1) {
 
-[[tag patch]]
\ No newline at end of file
+I actually see a bug in this patch. :-) If srcdir = "foo" and the wiki
+contains a "foo/bar" and a "bar", this will make it, in the non-ctime case,
+get the sha1 of the wrong file, "bar", when "foo/bar" is asked for.
+
+Better to strip the path out in getctime, I guess.
+
+--[[Joey]]
+
+[[tag patch]]