From: Joey Hess <joeyh@joeyh.name>
Date: Mon, 21 Jan 2019 15:44:29 +0000 (-0400)
Subject: bug report
X-Git-Tag: 3.20190207~45
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/4cb6f48aff6645227dae5c7852d3122e4046142b

bug report
---

diff --git a/doc/bugs/permalink_not_set_for_comments.mdwn b/doc/bugs/permalink_not_set_for_comments.mdwn
new file mode 100644
index 000000000..9ca8200b5
--- /dev/null
+++ b/doc/bugs/permalink_not_set_for_comments.mdwn
@@ -0,0 +1,16 @@
+Changes to comments result in notifyemail sending emails with broken urls like 
+"http://whatever/foo/comment_1_10a49d69282155c5c3e66dc58f64f956/"
+
+notifyemail uses meta permalink if set, so it must not be set for comment
+pages.
+
+In the comments plugin, there's this code, which is supposed to set
+permalink:
+
+        if ($params{page} =~ m/\/\Q$config{comments_pagename}\E\d+_/) {
+                $pagestate{$page}{meta}{permalink} = urlto(IkiWiki::dirname($params{page})).
+                        "#".page_to_id($params{page});
+        }
+
+`comments_pagename` is `comment_` so the above code needs a comment page to contain
+two underscores. I think that is the root of the bug. --[[Joey]]