From: joey <joey@0fa5a96a-9a0e-0410-b3b2-a0fd24251071>
Date: Fri, 2 Mar 2007 01:07:48 +0000 (+0000)
Subject: comments
X-Git-Tag: 1.45~74
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/12db25595bbed45a51134d2d60cfb3ac4b23c977

comments
---

diff --git a/doc/patchqueue/format_escape.mdwn b/doc/patchqueue/format_escape.mdwn
index 94b6c4932..41666b6e2 100644
--- a/doc/patchqueue/format_escape.mdwn
+++ b/doc/patchqueue/format_escape.mdwn
@@ -7,6 +7,10 @@ I added an extra named parameter to the htmlize hook, which feels sort of
 wrong, since none of the other hooks take parameters. Let me know what 
 you think. --Ethan
 
+Seems fairly reasonable, actually. Shouldn't the `$type` come from `$page`
+instead of `$destpage` though? Only other obvious change is to make the
+escape parameter optional, and only call it if set. --[[Joey]]
+
 <pre>
 diff -urX ignorepats clean-ikidev/IkiWiki/Plugin/mdwn.pm ikidev/IkiWiki/Plugin/mdwn.pm
 --- clean-ikidev/IkiWiki/Plugin/mdwn.pm 2007-02-25 12:26:54.031200000 -0800
@@ -78,4 +82,4 @@ diff -urX ignorepats clean-ikidev/IkiWiki.pm ikidev/IkiWiki.pm
                         return $ret;
                 }
                 else {
-</pre>
\ No newline at end of file
+</pre>