From: Joey Hess Date: Thu, 2 Oct 2008 21:42:33 +0000 (-0400) Subject: rename X-Git-Tag: 2.66~6 X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/0b89d442331bd62b4dc2da4f7fcbca59d5ca21eb rename --- diff --git a/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn b/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn deleted file mode 100644 index a1b38257a..000000000 --- a/doc/bugs/ikiwiki_is_not_truly_localizable.mdwn +++ /dev/null @@ -1,47 +0,0 @@ -A lot of strings in ikiwiki are hardcoded and not taken for locales resources through gettext. This is bad because ikiwiki is thus difficult to spread for non-english users. - -I mean that, for instance in CGI.pm, line like: - -`my @buttons=("Save Page", "Preview", "Cancel");` - -should be written as - -`my @buttons=(gettext("Save Page"), gettext("Preview"), gettext("Cancel"));` - -> Yes, these need to be fixed. But note that the localised texts come back -> into ikiwiki and are used in various places, including plugins. -> Including, possibly, third-party plugins. So localising the buttons would -> seem to require converting from the translations back into the C locale -> when the form is posted. --[[Joey]] - ->> Wouldn't it be more easy to change all calls to the corrects ones (including in plugins) ? ->> For instance in the same file (CGI.pm): `elsif ($form->submitted eq gettext("Save Page")) {`. ->> That way no conversion to the C locale is needed. ->> gettext use should just be publicized in documentation (at least in [[plugins/write]]). --[[bbb]] - ->>> It would be easy, but it could break third-party plugins that hardcode ->>> the english strings. It's also probably less efficient to run gettext ->>> over and over. --[[Joey]] - -In standards templates things seems wrongly written too. For instance in page.tmpl line like: - -`
  • Edit
    • ` - -should be written as - -`
    • ` - -with EDITURL_TEXT variable initialized in Render.pm through a gettext call. - -Am I wrong ? - -> No, that's not a sane way to localise the templates. The templates can be -> translated by making a copy and modifying it, or by using a tool to -> generate .mo files from the templates, and generate translated templates -> from .po files. (See [[todo/l10n]] for one attempt.) But pushing the -> localisation of random strings in the templates through the ikiwiki -> program defeats the purpose of having templates at all. --[[Joey]] - -If not I can spend some time preparing patches for such corrections if it can help. - --- [[/users/bbb]] diff --git a/doc/bugs/some_strings_are_not_internationalized.mdwn b/doc/bugs/some_strings_are_not_internationalized.mdwn new file mode 100644 index 000000000..a1b38257a --- /dev/null +++ b/doc/bugs/some_strings_are_not_internationalized.mdwn @@ -0,0 +1,47 @@ +A lot of strings in ikiwiki are hardcoded and not taken for locales resources through gettext. This is bad because ikiwiki is thus difficult to spread for non-english users. + +I mean that, for instance in CGI.pm, line like: + +`my @buttons=("Save Page", "Preview", "Cancel");` + +should be written as + +`my @buttons=(gettext("Save Page"), gettext("Preview"), gettext("Cancel"));` + +> Yes, these need to be fixed. But note that the localised texts come back +> into ikiwiki and are used in various places, including plugins. +> Including, possibly, third-party plugins. So localising the buttons would +> seem to require converting from the translations back into the C locale +> when the form is posted. --[[Joey]] + +>> Wouldn't it be more easy to change all calls to the corrects ones (including in plugins) ? +>> For instance in the same file (CGI.pm): `elsif ($form->submitted eq gettext("Save Page")) {`. +>> That way no conversion to the C locale is needed. +>> gettext use should just be publicized in documentation (at least in [[plugins/write]]). --[[bbb]] + +>>> It would be easy, but it could break third-party plugins that hardcode +>>> the english strings. It's also probably less efficient to run gettext +>>> over and over. --[[Joey]] + +In standards templates things seems wrongly written too. For instance in page.tmpl line like: + +`
  • Edit
    • ` + +should be written as + +`
    • ` + +with EDITURL_TEXT variable initialized in Render.pm through a gettext call. + +Am I wrong ? + +> No, that's not a sane way to localise the templates. The templates can be +> translated by making a copy and modifying it, or by using a tool to +> generate .mo files from the templates, and generate translated templates +> from .po files. (See [[todo/l10n]] for one attempt.) But pushing the +> localisation of random strings in the templates through the ikiwiki +> program defeats the purpose of having templates at all. --[[Joey]] + +If not I can spend some time preparing patches for such corrections if it can help. + +-- [[/users/bbb]]