From: Amitai Schlair <schmonz-web-ikiwiki@schmonz.com>
Date: Sun, 23 Aug 2015 02:20:03 +0000 (-0400)
Subject: Fix [[!meta name=foo]] by closing the open quote.
X-Git-Tag: 3.20160121~91
X-Git-Url: http://git.vanrenterghem.biz/git.ikiwiki.info.git/commitdiff_plain/09916a90ed9f22212ac62078132fd2375ed0017f?ds=inline

Fix [[!meta name=foo]] by closing the open quote.
---

diff --git a/IkiWiki/Plugin/meta.pm b/IkiWiki/Plugin/meta.pm
index e7b96bdf1..ea099f955 100644
--- a/IkiWiki/Plugin/meta.pm
+++ b/IkiWiki/Plugin/meta.pm
@@ -294,6 +294,7 @@ sub preprocess (@) {
 	elsif ($key eq 'name') {
 		push @{$metaheaders{$page}}, scrub('<meta name="'.
 			encode_entities($value).
+			'" '.
 			join(' ', map { "$_=\"$params{$_}\"" } keys %params).
 			' />', $page, $destpage);
 	}
diff --git a/t/meta.t b/t/meta.t
index ab25c2f83..c95e23531 100755
--- a/t/meta.t
+++ b/t/meta.t
@@ -125,12 +125,11 @@ write_build_read_compare(
 #	qr{<link href="http://wonka\.link\.example" />},
 #);
 
-# XXX buggy? is this my bug? maybe twitter:foo would just work if this worked
-#write_build_read_compare(
-#	'name',
-#	q{[[!meta name="thingy" value1="hi" value2="hello"]]},
-#	qr{<meta name="thingy" value1="hi" value2="hello" />},
-#);
+write_build_read_compare(
+	'name',
+	q{[[!meta name="thingy" value1="hi" value2="hello"]]},
+	qr{<meta name="thingy" value[0-9]{1}=".+?" value[0-9]{1}=".+?" />},
+);
 
 write_build_read_compare(
 	'keywords',
@@ -149,11 +148,11 @@ write_build_read_compare(
 #	'[[!meta twitter:card="player"]]',
 #	qr{<meta name="twitter:card" content="player" />},
 #);
-#
-#write_build_read_compare(
-#	'twittercard2',
-#	'[[!meta name="twitter:card" content="player"]]',
-#	qr{<meta name="twitter:card" content="player" />},
-#);
+
+write_build_read_compare(
+	'twittercard2',
+	'[[!meta name="twitter:card" content="player"]]',
+	qr{<meta name="twitter:card" content="player" />},
+);
 
 done_testing();