Photos
Blog
Projects
vanrenterghem.biz
projects
/
git.ikiwiki.info.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
b2a8f0f
)
review other 2
author
Joey Hess
<joey@kitenet.net>
Tue, 22 Feb 2011 21:37:38 +0000
(17:37 -0400)
committer
Joey Hess
<joey@kitenet.net>
Tue, 22 Feb 2011 21:37:38 +0000
(17:37 -0400)
doc/todo/feed_enhancements_for_inline_pages.mdwn
patch
|
blob
|
history
diff --git
a/doc/todo/feed_enhancements_for_inline_pages.mdwn
b/doc/todo/feed_enhancements_for_inline_pages.mdwn
index 46b6a251202c7317b8ac6e65e8efd45a7e43ad8b..ec7c8c6686ad3e111b34b26cfe8466fe8bceca13 100644
(file)
--- a/
doc/todo/feed_enhancements_for_inline_pages.mdwn
+++ b/
doc/todo/feed_enhancements_for_inline_pages.mdwn
@@
-56,7
+56,14
@@
requirement described anywhere. Rather than restricting the user input,
I propose a patch that prevents double slashes from appearing in links
created by `urlto()` by fixing the routine itself.
I propose a patch that prevents double slashes from appearing in links
created by `urlto()` by fixing the routine itself.
+> If this is fixed I would rather not put the overhead of fixing it in
+> every call to `urlto`. And I'm not sure this is a comprehensive
+> fix to every problem a trailing slash in the url could cause. --[[Joey]]
+
The inline plugin is also updated (in a separate patch) to use `urlto()`
rather than hand-coding the feed urls. You might want to keep this
change even if you discard the urlto patch.
The inline plugin is also updated (in a separate patch) to use `urlto()`
rather than hand-coding the feed urls. You might want to keep this
change even if you discard the urlto patch.
+> IIRC, I was missing a proof that this always resulted in identical urls,
+> which is necessary to prevent flooding. I need such a proof before I can
+> apply that. --[[Joey]]