Minor tidy-ups.

diff --git a/IkiWiki/Plugin/git.pm b/IkiWiki/Plugin/git.pm
index 46fa7d2e09977d1ac067262a7366ed00bb90ea70..457975d953225f7d916282086008014aeff45e67 100644 (file)
--- a/IkiWiki/Plugin/git.pm
+++ b/IkiWiki/Plugin/git.pm
@@ -840,7 +840,7 @@ sub rcs_receive () {
 sub rcs_preprevert (@) {
     # Determine what the effects are of reverting the patch with the
     # ID given by 'rev'. Returns the same structure as rcs_receive.
 sub rcs_preprevert (@) {
     # Determine what the effects are of reverting the patch with the
     # ID given by 'rev'. Returns the same structure as rcs_receive.

-    # FIXME note test_changes expects 'cgi' and 'session' parameters.
+    # Note test_changes expects 'cgi' and 'session' parameters.

     my %params = @_;
     my $rev = $params{rev};
 
     my %params = @_;
     my $rev = $params{rev};
 


@@ -870,10 +870,7 @@ sub rcs_showpatch (@) {
     my %params = @_;
     my $rev = $params{rev};
 
     my %params = @_;
     my $rev = $params{rev};
 

-    # FIXME check
-    my @r = run_or_die('git', 'show', $rev);
-
-    return join "\n", @r;
+    return join "\n", run_or_die('git', 'show', $rev);

 }
 
 1
 }
 
 1

diff --git a/IkiWiki/Plugin/recentchanges.pm b/IkiWiki/Plugin/recentchanges.pm
index 4a8d1bf800a104131446d0ce7186be0f6f0a8f3d..9a62cb2437b52abe15b60b65b7005c6df187cbd9 100644 (file)
--- a/IkiWiki/Plugin/recentchanges.pm
+++ b/IkiWiki/Plugin/recentchanges.pm
@@ -107,12 +107,11 @@ sub sessioncgi ($$) {
         IkiWiki::enable_commit_hook();
 
         if($r) {
         IkiWiki::enable_commit_hook();
 
         if($r) {

-            die "FIXME revert '$rev' failed.";
+            die "Revert '$rev' failed.";

         } else {
             require IkiWiki::Render;
             IkiWiki::refresh();
             IkiWiki::saveindex();
         } else {
             require IkiWiki::Render;
             IkiWiki::refresh();
             IkiWiki::saveindex();

-            # FIXME indicate success.

         }
     } else {
         $form->title(sprintf(gettext("confirm reversion of %s"), $rev));
         }
     } else {
         $form->title(sprintf(gettext("confirm reversion of %s"), $rev));