]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/commit
Try revert operations (on a branch) before approving them
authorSimon McVittie <smcv@debian.org>
Mon, 19 Dec 2016 13:48:56 +0000 (13:48 +0000)
committerSimon McVittie <smcv@debian.org>
Wed, 28 Dec 2016 21:32:12 +0000 (21:32 +0000)
commita8a7462382ff235086743f06a92a9ab9100083b4
tree0d69d59b5c84950aa17f8ca08df4bc5ba4f1118c
parent469c842fd56ce811d431058714d9c2700a5314f8
Try revert operations (on a branch) before approving them

Otherwise, we have a time-of-check/time-of-use vulnerability:
rcs_preprevert previously looked at what changed in the commit we are
reverting, not at what would result from reverting it now. In
particular, if some files were renamed since the commit we are
reverting, a revert of changes that were within the designated
subdirectory and allowed by check_canchange() might now affect
files that are outside the designated subdirectory or disallowed
by check_canchange().

It is not sufficient to disable rename detection, since git older
than 2.8.0rc0 (in particular the version in Debian stable) silently
accepts and ignores the relevant options.

OVE-20161226-0002
IkiWiki/Plugin/git.pm
debian/changelog
doc/security.mdwn