]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/commit
Try revert operations (on a branch) before approving them
authorSimon McVittie <smcv@debian.org>
Mon, 26 Dec 2016 18:45:02 +0000 (18:45 +0000)
committerSimon McVittie <smcv@debian.org>
Wed, 11 Jan 2017 15:32:59 +0000 (15:32 +0000)
commita4e4cacc2d1e2c314f8b6791c3a212fc3ff62c3f
tree726eff6a01b4df7aa03580bf17272e3e7da3c8d4
parentf2253db46c049fad6a20622df5229079010cf784
Try revert operations (on a branch) before approving them

Otherwise, we have a time-of-check/time-of-use vulnerability:
rcs_preprevert previously looked at what changed in the commit we are
reverting, not at what would result from reverting it now. In
particular, if some files were renamed since the commit we are
reverting, a revert of changes that were within the designated
subdirectory and allowed by check_canchange() might now affect
files that are outside the designated subdirectory or disallowed
by check_canchange().

OVE-20161226-0002
IkiWiki/Plugin/git.pm