]> git.vanrenterghem.biz Git - git.ikiwiki.info.git/commit
Wrapper: allocate new environment dynamically
authorSimon McVittie <smcv@debian.org>
Wed, 11 May 2016 08:18:14 +0000 (09:18 +0100)
committerSimon McVittie <smcv@debian.org>
Wed, 11 May 2016 08:18:14 +0000 (09:18 +0100)
commit5f6f9a1beab327be2728d44c1996408176f6800e
tree2c9cda07a8776dea92bc12a4b80648132d4b0ae2
parent062dbf1373dcf1646ef58400f011dc3b148aa862
Wrapper: allocate new environment dynamically

Otherwise, if third-party plugins extend newenviron by more than
3 entries, we could overflow the array. It seems unlikely that any
third-party plugin manipulates newenviron in practice, so this
is mostly theoretical. Just in case, I have deliberately avoided
using "i" as the variable name, so that any third-party plugin
that was manipulating newenviron directly will now result in the
wrapper failing to compile.

I have not assumed that realloc(NULL, ...) works as an equivalent of
malloc(...), in case there are still operating systems where that
doesn't work.
IkiWiki/Receive.pm
IkiWiki/Wrapper.pm
debian/changelog
t/cvs.t
t/wrapper-environ.t [new file with mode: 0755]